From patchwork Wed Oct 9 15:13:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manish Badarkhe X-Patchwork-Id: 3009381 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 63039BF924 for ; Wed, 9 Oct 2013 15:14:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 58DC920254 for ; Wed, 9 Oct 2013 15:14:22 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E93920251 for ; Wed, 9 Oct 2013 15:14:21 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VTvSr-0000Ue-OG; Wed, 09 Oct 2013 15:14:17 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VTvSp-0006Ut-1v; Wed, 09 Oct 2013 15:14:15 +0000 Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VTvSk-0006Sa-Uw for linux-arm-kernel@lists.infradead.org; Wed, 09 Oct 2013 15:14:11 +0000 Received: by mail-pa0-f51.google.com with SMTP id kp14so1175917pab.10 for ; Wed, 09 Oct 2013 08:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=y/Ft4xg7BWvtqyR4SbjEYilZpiqxnEA9YQrH6K7ikgI=; b=cLE4eHI9pjVs2GSM8Q6Zq2J1aWIHwT2wU5XGtS6sryr3xCDLhtCJ8rcxBIn98P3VNx dS/nN7xEvFFklEgsIVAOjI6lPOJtVrB7d5Dm+UDZWQRR3DVdsGkBnCbd3Ss29pVo2BW7 2EZdEJ7BmJcaeFACDDyF9L99juEtyHRCBmi7a7mf5N2ATegmPAIDT9KBl1ONh/JsrIb8 ok6VCi4ZWRbaih/+l+pqHj7Gn3N09MeystCjOB4v9ktdi4rPWvq/PexygQmrfnGx149B LlvTPouwRsEXY/0Bebb/w6A5APHxMHL14Vc1fauwo+Gs05kxm9dPB8JruXoqMSD6dJIS +7Uw== X-Received: by 10.66.119.78 with SMTP id ks14mr10068992pab.140.1381331626246; Wed, 09 Oct 2013 08:13:46 -0700 (PDT) Received: from localhost.localdomain ([113.193.145.88]) by mx.google.com with ESMTPSA id om2sm47198752pbc.30.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 09 Oct 2013 08:13:44 -0700 (PDT) From: Manish Badarkhe To: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: fix false return check from "regulator_set_voltage" Date: Wed, 9 Oct 2013 20:43:37 +0530 Message-Id: <1381331617-14703-1-git-send-email-badarkhe.manish@gmail.com> X-Mailer: git-send-email 1.7.10.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131009_111411_087942_57E60F95 X-CRM114-Status: UNSURE ( 9.64 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.0 (--) Cc: rjw@sisk.pl, viresh.kumar@linaro.org, badarkhe.manish@gmail.com, kgene.kim@samsung.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently, code checks false return value from "regulator_set_voltage" to show failure message. Modify the code to check proper return value from "regulator_set_voltage". Signed-off-by: Manish Badarkhe Acked-by: Viresh Kumar --- Based on master branch of linux-mainline. :100644 100644 0fac344... 1537f32... M drivers/cpufreq/exynos-cpufreq.c drivers/cpufreq/exynos-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c index 0fac344..1537f32 100644 --- a/drivers/cpufreq/exynos-cpufreq.c +++ b/drivers/cpufreq/exynos-cpufreq.c @@ -141,7 +141,7 @@ post_notify: if ((freqs.new < freqs.old) || ((freqs.new > freqs.old) && safe_arm_volt)) { /* down the voltage after frequency change */ - regulator_set_voltage(arm_regulator, arm_volt, + ret = regulator_set_voltage(arm_regulator, arm_volt, arm_volt); if (ret) { pr_err("%s: failed to set cpu voltage to %d\n",