| Message ID | 1381943025-1036-1-git-send-email-s.nawrocki@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday, October 17, 2013 2:04 AM, Sylwester Nawrocki wrote: > > Fix argument passed to the register setup helper function so > the phy is actually disabled. Now due to cut&paste error 1 is > passed to both phy_power_on() and phy_power_off(). > > Reported by: Kyungmin Park <kyungmin.park@samsung.com> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Reviewed-by: Jingoo Han <jg1.han@samsung.com> Best regards, Jingoo Han > --- > > This fixes a cut&paste typo which snicked in while doing very last > adaptation to latest version of the phy framework. > > Thanks, > Sylwester > --- > drivers/phy/phy-exynos-mipi-video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c > index b73b86a..0c5efab 100644 > --- a/drivers/phy/phy-exynos-mipi-video.c > +++ b/drivers/phy/phy-exynos-mipi-video.c > @@ -93,7 +93,7 @@ static int exynos_mipi_video_phy_power_off(struct phy *phy) > struct video_phy_desc *phy_desc = phy_get_drvdata(phy); > struct exynos_mipi_video_phy *state = to_mipi_video_phy(phy_desc); > > - return __set_phy_state(state, phy_desc->index, 1); > + return __set_phy_state(state, phy_desc->index, 0); > } > > static struct phy *exynos_mipi_video_phy_xlate(struct device *dev, > -- > 1.7.9.5
Hi Greg, On Wednesday 16 October 2013 10:33 PM, Sylwester Nawrocki wrote: > Fix argument passed to the register setup helper function so > the phy is actually disabled. Now due to cut&paste error 1 is > passed to both phy_power_on() and phy_power_off(). Can you take this patch? Acked-by: Kishon Vijay Abraham I <kishon@ti.com> > > Reported by: Kyungmin Park <kyungmin.park@samsung.com> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > > This fixes a cut&paste typo which snicked in while doing very last > adaptation to latest version of the phy framework. > > Thanks, > Sylwester > --- > drivers/phy/phy-exynos-mipi-video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c > index b73b86a..0c5efab 100644 > --- a/drivers/phy/phy-exynos-mipi-video.c > +++ b/drivers/phy/phy-exynos-mipi-video.c > @@ -93,7 +93,7 @@ static int exynos_mipi_video_phy_power_off(struct phy *phy) > struct video_phy_desc *phy_desc = phy_get_drvdata(phy); > struct exynos_mipi_video_phy *state = to_mipi_video_phy(phy_desc); > > - return __set_phy_state(state, phy_desc->index, 1); > + return __set_phy_state(state, phy_desc->index, 0); > } > > static struct phy *exynos_mipi_video_phy_xlate(struct device *dev, >
diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c index b73b86a..0c5efab 100644 --- a/drivers/phy/phy-exynos-mipi-video.c +++ b/drivers/phy/phy-exynos-mipi-video.c @@ -93,7 +93,7 @@ static int exynos_mipi_video_phy_power_off(struct phy *phy) struct video_phy_desc *phy_desc = phy_get_drvdata(phy); struct exynos_mipi_video_phy *state = to_mipi_video_phy(phy_desc); - return __set_phy_state(state, phy_desc->index, 1); + return __set_phy_state(state, phy_desc->index, 0); } static struct phy *exynos_mipi_video_phy_xlate(struct device *dev,
Fix argument passed to the register setup helper function so the phy is actually disabled. Now due to cut&paste error 1 is passed to both phy_power_on() and phy_power_off(). Reported by: Kyungmin Park <kyungmin.park@samsung.com> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- This fixes a cut&paste typo which snicked in while doing very last adaptation to latest version of the phy framework. Thanks, Sylwester --- drivers/phy/phy-exynos-mipi-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)