From patchwork Mon Oct 21 13:42:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 3077371 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8E248BF924 for ; Mon, 21 Oct 2013 13:43:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 433FC2042A for ; Mon, 21 Oct 2013 13:43:38 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82D2620295 for ; Mon, 21 Oct 2013 13:43:33 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VYFla-0006nA-7v; Mon, 21 Oct 2013 13:43:30 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VYFlX-0003F0-U7; Mon, 21 Oct 2013 13:43:27 +0000 Received: from mailout3.w1.samsung.com ([210.118.77.13]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VYFlU-0003E5-HB for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2013 13:43:26 +0000 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MV000H1MU2EWH00@mailout3.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2013 14:42:59 +0100 (BST) X-AuditID: cbfec7f4-b7f0a6d000007b1b-d5-52652f63bf0f Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 11.FC.31515.36F25625; Mon, 21 Oct 2013 14:42:59 +0100 (BST) Received: from AMDC1943.digital.local ([106.116.151.171]) by eusync4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MV000AMCU3K8C20@eusync4.samsung.com>; Mon, 21 Oct 2013 14:42:59 +0100 (BST) From: Krzysztof Kozlowski To: Ben Dooks , Kukjin Kim , Mark Brown Subject: [PATCH 1/2] spi/s3c64xx: Do not ignore return value of spi_master_resume/suspend Date: Mon, 21 Oct 2013 15:42:49 +0200 Message-id: <1382362971-16763-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNJMWRmVeSWpSXmKPExsVy+t/xa7rJ+qlBBl0XDCwmrTvAZDH14RM2 i9cvDC16F1xlszjb9IbdYtPja6wWl3fNYbOYcX4fk0Xjx5vsFofftLM6cHn8XfWC2WPTqk42 j81L6j36tqxi9Pi8SS6ANYrLJiU1J7MstUjfLoEr48HNY4wFTZwVP6//YW5gPMnexcjJISFg InFmyjsoW0ziwr31bF2MXBxCAksZJb4sPsoM4fQxSbw/vQ2sik3AWGLz8iVsILaIQJbE7X9b wIqYBSYzSZx+uZMRJCEsEC3xbyWEzSKgKrHs4CxmEJtXwF3i4oddQHEOoHUKEnMm2Uxg5F7A yLCKUTS1NLmgOCk911CvODG3uDQvXS85P3cTIySAvuxgXHzM6hCjAAejEg9vgEtKkBBrYllx Ze4hRgkOZiUR3s8fgUK8KYmVValF+fFFpTmpxYcYmTg4pRoYg5NmftzB8VPzUGzz7T0CW57G dj5d+mJ262Hj5cv667yr71X/nHxJxPPszVBRl5Vna+rvd5xi2yjLeSNz4q4HzzgOKnhbRs/6 9udYoLTDT/mw3yGnxHrUQ87pNioeuLdu3brm+jsHvpx8bnqzuWP6+Tssi/Jt1W8wbz09/UFA z7TAHPv3LKuP7FViKc5INNRiLipOBAC5N52T/gEAAA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131021_094324_682624_59A3E87A X-CRM114-Status: GOOD ( 11.41 ) X-Spam-Score: -7.3 (-------) Cc: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Kyungmin Park , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP During PM resume and suspend do not ignore the return value of spi_master_suspend() or spi_master_resume(). Instead pass it further. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Kyungmin Park Reviewed-by: Sylwester Nawrocki --- drivers/spi/spi-s3c64xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 512b889..59f4fd9 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1480,7 +1480,9 @@ static int s3c64xx_spi_suspend(struct device *dev) struct spi_master *master = dev_get_drvdata(dev); struct s3c64xx_spi_driver_data *sdd = spi_master_get_devdata(master); - spi_master_suspend(master); + int ret = spi_master_suspend(master); + if (ret) + return ret; /* Disable the clock */ clk_disable_unprepare(sdd->src_clk); @@ -1506,9 +1508,7 @@ static int s3c64xx_spi_resume(struct device *dev) s3c64xx_spi_hwinit(sdd, sdd->port_id); - spi_master_resume(master); - - return 0; + return spi_master_resume(master); } #endif /* CONFIG_PM_SLEEP */