From patchwork Mon Oct 28 22:54:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 3104751 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2D5A79F2B7 for ; Mon, 28 Oct 2013 22:54:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6FCE920348 for ; Mon, 28 Oct 2013 22:54:51 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CFAF20200 for ; Mon, 28 Oct 2013 22:54:50 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vavhv-0004Sz-IH; Mon, 28 Oct 2013 22:54:47 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vavhs-0007e1-RV; Mon, 28 Oct 2013 22:54:44 +0000 Received: from top.free-electrons.com ([176.31.233.9] helo=mail.free-electrons.com) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vavhq-0007cR-0Q for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2013 22:54:42 +0000 Received: by mail.free-electrons.com (Postfix, from userid 106) id 52246856; Mon, 28 Oct 2013 23:54:27 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from localhost.localdomain (unknown [190.2.98.212]) by mail.free-electrons.com (Postfix) with ESMTPA id 536F87E0; Mon, 28 Oct 2013 23:54:24 +0100 (CET) From: Ezequiel Garcia To: , Subject: [PATCH 1/2] dma: mv_xor: Remove unneeded NULL address check Date: Mon, 28 Oct 2013 19:54:14 -0300 Message-Id: <1383000855-8377-1-git-send-email-ezequiel.garcia@free-electrons.com> X-Mailer: git-send-email 1.8.1.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131028_185442_146558_1B8E7F85 X-CRM114-Status: UNSURE ( 6.01 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.7 (-) Cc: Thomas Petazzoni , sachin.kamat@linaro.org, dan.j.williams@intel.com, vinod.koul@intel.com, Ezequiel Garcia X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This mmio address is checked at probe-time, which makes this test redundant. Let's just remove it. Signed-off-by: Ezequiel Garcia Acked-by: Thomas Petazzoni --- drivers/dma/mv_xor.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index 536dcb8..d00d58e 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1076,10 +1076,6 @@ mv_xor_channel_add(struct mv_xor_device *xordev, } mv_chan->mmr_base = xordev->xor_base; - if (!mv_chan->mmr_base) { - ret = -ENOMEM; - goto err_free_dma; - } tasklet_init(&mv_chan->irq_tasklet, mv_xor_tasklet, (unsigned long) mv_chan);