diff mbox

[1/1] mmc: core: fix build warning

Message ID 1383142380-25091-1-git-send-email-b29396@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Aisheng Dong Oct. 30, 2013, 2:13 p.m. UTC
drivers/mmc/core/mmc_ops.c: In function '__mmc_switch':
drivers/mmc/core/mmc_ops.c:484:11: warning: 'status' may be used uninitialized in this function [-Wuninitialized]

Signed-off-by: Dong Aisheng <b29396@freescale.com>
---
 drivers/mmc/core/mmc_ops.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Ulf Hansson Oct. 30, 2013, 2:55 p.m. UTC | #1
Dong Aisheng <b29396@freescale.com> skrev:
>drivers/mmc/core/mmc_ops.c: In function '__mmc_switch':
>drivers/mmc/core/mmc_ops.c:484:11: warning: 'status' may be used
>uninitialized in this function [-Wuninitialized]
>
>Signed-off-by: Dong Aisheng <b29396@freescale.com>

Hi Dong,

I have already sent a patch for this, it was more or less me causing it.:-)

Kind regards
Ulf Hansson
>---
> drivers/mmc/core/mmc_ops.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
>index aae8d8b..651260c 100644
>--- a/drivers/mmc/core/mmc_ops.c
>+++ b/drivers/mmc/core/mmc_ops.c
>@@ -414,7 +414,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8
>index, u8 value,
> 	int err;
> 	struct mmc_command cmd = {0};
> 	unsigned long timeout;
>-	u32 status;
>+	u32 uninitialized_var(status);
> 	bool ignore_crc = false;
> 
> 	BUG_ON(!card);
Aisheng Dong Oct. 31, 2013, 5:02 a.m. UTC | #2
On Wed, Oct 30, 2013 at 07:55:32AM -0700, Ulf Hansson wrote:
> 
> 
> Dong Aisheng <b29396@freescale.com> skrev:
> >drivers/mmc/core/mmc_ops.c: In function '__mmc_switch':
> >drivers/mmc/core/mmc_ops.c:484:11: warning: 'status' may be used
> >uninitialized in this function [-Wuninitialized]
> >
> >Signed-off-by: Dong Aisheng <b29396@freescale.com>
> 
> Hi Dong,
> 
> I have already sent a patch for this, it was more or less me causing it.:-)
> 
> Kind regards
> Ulf Hansson

Hi Ulf,

Got it, thanks for the information. :-)

Regards
Dong Aisheng
> >---
> > drivers/mmc/core/mmc_ops.c |    2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
> >index aae8d8b..651260c 100644
> >--- a/drivers/mmc/core/mmc_ops.c
> >+++ b/drivers/mmc/core/mmc_ops.c
> >@@ -414,7 +414,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8
> >index, u8 value,
> > 	int err;
> > 	struct mmc_command cmd = {0};
> > 	unsigned long timeout;
> >-	u32 status;
> >+	u32 uninitialized_var(status);
> > 	bool ignore_crc = false;
> > 
> > 	BUG_ON(!card);
> 
>
diff mbox

Patch

diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
index aae8d8b..651260c 100644
--- a/drivers/mmc/core/mmc_ops.c
+++ b/drivers/mmc/core/mmc_ops.c
@@ -414,7 +414,7 @@  int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
 	int err;
 	struct mmc_command cmd = {0};
 	unsigned long timeout;
-	u32 status;
+	u32 uninitialized_var(status);
 	bool ignore_crc = false;
 
 	BUG_ON(!card);