From patchwork Sat Nov 2 15:39:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 3130851 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 340869F43F for ; Sat, 2 Nov 2013 15:42:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 74B6D2027D for ; Sat, 2 Nov 2013 15:42:04 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72483201B7 for ; Sat, 2 Nov 2013 15:42:03 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VcdJl-0008RW-II; Sat, 02 Nov 2013 15:40:54 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VcdJU-0001tw-V4; Sat, 02 Nov 2013 15:40:36 +0000 Received: from mail-pd0-x234.google.com ([2607:f8b0:400e:c02::234]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VcdJR-0001s9-Kv for linux-arm-kernel@lists.infradead.org; Sat, 02 Nov 2013 15:40:34 +0000 Received: by mail-pd0-f180.google.com with SMTP id p10so5056842pdj.11 for ; Sat, 02 Nov 2013 08:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0Evp7Ay5dgXUJjAGc54iQZxk7mKfX1PlkQ+QRGz47UU=; b=HFt36+8GZu9YzB0w/XY+mqW1YZ8drUIxytOo3Y+j9+DIru6AJO++5yLjMuqKx83z8x G32lQ6+Z5nw3UCECGZDMxKIU+5lukMXGSs8znewRPfq9pR+8K1v5NX10h/JrZDNq8xzc D1IQFabdD4/wICf3dQA4husLm9jSWOMlR1lbZ+DG5kAXl2SnQvYE9Q0mgxWTRkrNUfjq MywUb2/pmJozS31ubq3f6UGrZKf6w0+h/Bsdmv8YElgHeI5QgsXsdfyXgQFETLxpD6Z5 8HlofqAxWdG4nOZhTY1gaG3/NstzaKTGEUG5qKisOOPqQamkvbl7aclPRATKfAE8f2VK Bm4Q== X-Received: by 10.68.225.9 with SMTP id rg9mr8717231pbc.122.1383406810495; Sat, 02 Nov 2013 08:40:10 -0700 (PDT) Received: from localhost.localdomain ([49.200.27.40]) by mx.google.com with ESMTPSA id qp10sm20456849pab.13.2013.11.02.08.40.01 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 02 Nov 2013 08:40:09 -0700 (PDT) From: "Lad, Prabhakar" To: Sekhar Nori , Linus Walleij , devicetree@vger.kernel.org Subject: [PATCH v4 2/6] gpio: davinci: remove unnecessary printk Date: Sat, 2 Nov 2013 21:09:31 +0530 Message-Id: <1383406775-14902-3-git-send-email-prabhakar.csenng@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1383406775-14902-1-git-send-email-prabhakar.csenng@gmail.com> References: <1383406775-14902-1-git-send-email-prabhakar.csenng@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131102_114033_773196_BC05E583 X-CRM114-Status: GOOD ( 11.51 ) X-Spam-Score: -2.0 (--) Cc: Mark Rutland , Alex Elder , davinci-linux-open-source@linux.davincidsp.com, Grygorii Strashko , Russell King , Pawel Moll , Ian Campbell , Stephen Warren , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , linux-gpio@vger.kernel.org, Lad Prabhakar , Rob Landley , Grant Likely , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: "Lad, Prabhakar" the devm_*() helper prints error messages in case of errors no need to do the same in the driver. Signed-off-by: Lad, Prabhakar --- drivers/gpio/gpio-davinci.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 6c90cfb..95c6df1 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -389,11 +389,9 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) } clk = devm_clk_get(dev, "gpio"); - if (IS_ERR(clk)) { - printk(KERN_ERR "Error %ld getting gpio clock?\n", - PTR_ERR(clk)); + if (IS_ERR(clk)) return PTR_ERR(clk); - } + clk_prepare_enable(clk); /*