| Message ID | 1383814773-5231-1-git-send-email-jszhang@marvell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Nov 07, 2013 at 04:59:33PM +0800, Jisheng Zhang wrote: > This symbol is used only in this file. The patch fix the following > sparse warning: > warning: symbol 'of_cpu_clk_setup' was not declared. Should it be static? > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > --- > drivers/clk/mvebu/clk-cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jason Cooper <jason@lakedaemon.net> thx, Jason.
On 07/11/2013 09:59, Jisheng Zhang wrote: > This symbol is used only in this file. The patch fix the following > sparse warning: > warning: symbol 'of_cpu_clk_setup' was not declared. Should it be static? > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Thanks, Gregory > --- > drivers/clk/mvebu/clk-cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c > index 1466865..8ebf757 100644 > --- a/drivers/clk/mvebu/clk-cpu.c > +++ b/drivers/clk/mvebu/clk-cpu.c > @@ -101,7 +101,7 @@ static const struct clk_ops cpu_ops = { > .set_rate = clk_cpu_set_rate, > }; > > -void __init of_cpu_clk_setup(struct device_node *node) > +static void __init of_cpu_clk_setup(struct device_node *node) > { > struct cpu_clk *cpuclk; > void __iomem *clock_complex_base = of_iomap(node, 0); >
On Thu, Nov 07, 2013 at 04:59:33PM +0800, Jisheng Zhang wrote: > This symbol is used only in this file. The patch fix the following > sparse warning: > warning: symbol 'of_cpu_clk_setup' was not declared. Should it be static? > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > --- > drivers/clk/mvebu/clk-cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to mvebu/clk with Gregory and my Acks destined for the clock tree. thx, Jason.
diff --git a/drivers/clk/mvebu/clk-cpu.c b/drivers/clk/mvebu/clk-cpu.c index 1466865..8ebf757 100644 --- a/drivers/clk/mvebu/clk-cpu.c +++ b/drivers/clk/mvebu/clk-cpu.c @@ -101,7 +101,7 @@ static const struct clk_ops cpu_ops = { .set_rate = clk_cpu_set_rate, }; -void __init of_cpu_clk_setup(struct device_node *node) +static void __init of_cpu_clk_setup(struct device_node *node) { struct cpu_clk *cpuclk; void __iomem *clock_complex_base = of_iomap(node, 0);
This symbol is used only in this file. The patch fix the following sparse warning: warning: symbol 'of_cpu_clk_setup' was not declared. Should it be static? Signed-off-by: Jisheng Zhang <jszhang@marvell.com> --- drivers/clk/mvebu/clk-cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)