From patchwork Fri Nov 8 10:11:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 3157251 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AD184BEEB2 for ; Fri, 8 Nov 2013 10:13:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9D2DC20375 for ; Fri, 8 Nov 2013 10:13:43 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B1B0202F8 for ; Fri, 8 Nov 2013 10:13:42 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vej3i-0004OF-WB; Fri, 08 Nov 2013 10:12:59 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vej3Q-0007k8-Ko; Fri, 08 Nov 2013 10:12:40 +0000 Received: from mail-pb0-x22e.google.com ([2607:f8b0:400e:c01::22e]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vej3N-0007iE-6e for linux-arm-kernel@lists.infradead.org; Fri, 08 Nov 2013 10:12:38 +0000 Received: by mail-pb0-f46.google.com with SMTP id un15so1951323pbc.5 for ; Fri, 08 Nov 2013 02:12:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gNnHO0v1CffIFiAroDv8sa2sfWu+JuSJKxWvBRhYRko=; b=AQtO8jZ/iZ0Nl2bLF82NYUUEv3bqvp/wXwcpYviUUKHukekR5688fhWeitYqr7o0zL BgQj+HK/8b/v9aMADhwYpSEaUNo88oautin9FZuG806Glgfc6Zk1dOdh0v1ceRNZdZ1a Erd1iNmS3ID7lpZNINE1QG4jMsy7Z7vCDM4232qPmWGtwcrVAwmLLW1iuyDaYH2EkO51 TVMAlArppUunXZSfjsiwbJ7A1KSkWxb1+uEGA0LdfiNwVFvLwjntUPcXiR2F7E2ZxJ1/ o5XA3ZheisMpRcVreIUUMIkXDzHgFGSNYDniFmpVQ8EiQGnz7+hBUjFkng7nnpxIDM9v sKiQ== X-Received: by 10.68.218.68 with SMTP id pe4mr14145931pbc.181.1383905535556; Fri, 08 Nov 2013 02:12:15 -0800 (PST) Received: from localhost.localdomain ([182.156.67.248]) by mx.google.com with ESMTPSA id fa4sm13061280pab.17.2013.11.08.02.12.07 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 08 Nov 2013 02:12:14 -0800 (PST) From: Prabhakar Lad To: Sekhar Nori , Linus Walleij , Grygorii Strashko Subject: [PATCH v5 1/7] gpio: davinci: remove unnecessary printk Date: Fri, 8 Nov 2013 15:41:44 +0530 Message-Id: <1383905510-31760-2-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1383905510-31760-1-git-send-email-prabhakar.csengg@gmail.com> References: <1383905510-31760-1-git-send-email-prabhakar.csengg@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131108_051237_358654_8C09DA5C X-CRM114-Status: GOOD ( 12.11 ) X-Spam-Score: -2.0 (--) Cc: Mark Rutland , devicetree@vger.kernel.org, DLOS , Pawel Moll , linux-doc@vger.kernel.org, Stephen Warren , LKML , Rob Herring , linux-gpio@vger.kernel.org, Prabhakar Lad , Rob Landley , Grant Likely , Ian Campbell , LAK X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: "Lad, Prabhakar" the devm_*() helper prints error messages in case of errors no need to do the same in the driver. Signed-off-by: Lad, Prabhakar --- drivers/gpio/gpio-davinci.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 84be701..7230c43 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c @@ -389,11 +389,9 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) } clk = devm_clk_get(dev, "gpio"); - if (IS_ERR(clk)) { - printk(KERN_ERR "Error %ld getting gpio clock?\n", - PTR_ERR(clk)); + if (IS_ERR(clk)) return PTR_ERR(clk); - } + clk_prepare_enable(clk); /*