| Message ID | 1384905197-3566-5-git-send-email-lho@apm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, > + txbooster = <0x2 0x2 0x2 0x2 0x2 0x2>; > + txskew = <0xa 0xa 0xa 0xa 0xa 0xa>; [Loc Ho] These isn't correct. They should be txboostgain and txeyetuning. I will fix these in the next version. -Loc
On Tue, Nov 19, 2013 at 11:53:17PM +0000, Loc Ho wrote: > arm64: Add APM X-Gene SoC 6.0Gbps SATA PHY DTS entries > > This patch adds the DTS entries for the APM X-Gene SoC 6.0Gbps SATA PHY > driver. The PHY for controller 0 and 1 are enabled by default. > > Signed-off-by: Loc Ho <lho@apm.com> > Signed-off-by: Tuan Phan <tphan@apm.com> > Signed-off-by: Suman Tripathi <stripathi@apm.com> > --- > arch/arm64/boot/dts/apm-storm.dtsi | 28 ++++++++++++++++++++++++++++ > 1 files changed, 28 insertions(+), 0 deletions(-) > > diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi > index 359d7b6..1d1c8bc 100644 > --- a/arch/arm64/boot/dts/apm-storm.dtsi > +++ b/arch/arm64/boot/dts/apm-storm.dtsi > @@ -193,5 +193,33 @@ > reg = <0x0 0x17000014 0x0 0x100>; > mask = <0x1>; > }; > + > + sataphy0: sataphy@1f210000 { > + compatible = "apm,xgene-ahci-phy"; > + reg = <0x0 0x1f210000 0x0 0x10000>; > + #phy-cells = <0>; > + status = "na"; s/"na"/"disabled"/g > + txbooster = <0x2 0x2 0x2 0x2 0x2 0x2>; > + txskew = <0xa 0xa 0xa 0xa 0xa 0xa>; > + }; > + > + sataphy1: sataphy@1f220000 { > + compatible = "apm,xgene-ahci-phy"; > + reg = <0x0 0x1f220000 0x0 0x10000>; > + #phy-cells = <0>; > + status = "ok"; > + txbooster = <0x2 0x2 0x2 0x2 0x2 0x2>; > + txskew = <0xa 0xa 0xa 0x5 0x5 0x5>; I don't recall seeing txskew in the binding document or code, but I see you've noticed too. > + }; > + > + sataphy2: sataphy@1f230000 { > + compatible = "apm,xgene-ahci-phy2"; > + reg = <0x0 0x1f230000 0x0 0x10000 > + 0x0 0x1f2d0000 0x0 0x10000>; Nit: please bracket entries individually: reg = <0x0 0x1f230000 0x0 0x10000>, <0x0 0x1f2d0000 0x0 0x10000>; Thanks, Mark.
Hello. On 20-11-2013 3:53, Loc Ho wrote: > arm64: Add APM X-Gene SoC 6.0Gbps SATA PHY DTS entries > This patch adds the DTS entries for the APM X-Gene SoC 6.0Gbps SATA PHY > driver. The PHY for controller 0 and 1 are enabled by default. > Signed-off-by: Loc Ho <lho@apm.com> > Signed-off-by: Tuan Phan <tphan@apm.com> > Signed-off-by: Suman Tripathi <stripathi@apm.com> > --- > arch/arm64/boot/dts/apm-storm.dtsi | 28 ++++++++++++++++++++++++++++ > 1 files changed, 28 insertions(+), 0 deletions(-) > diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi > index 359d7b6..1d1c8bc 100644 > --- a/arch/arm64/boot/dts/apm-storm.dtsi > +++ b/arch/arm64/boot/dts/apm-storm.dtsi > @@ -193,5 +193,33 @@ > reg = <0x0 0x17000014 0x0 0x100>; > mask = <0x1>; > }; > + > + sataphy0: sataphy@1f210000 { The nodes should better be named like "sata-phy@1f210000" to better comply with the "ethernet-phy" name we see in the ePAPR spec. WBR, Sergei
On Wednesday 20 November 2013, Sergei Shtylyov wrote: > > --- a/arch/arm64/boot/dts/apm-storm.dtsi > > +++ b/arch/arm64/boot/dts/apm-storm.dtsi > > @@ -193,5 +193,33 @@ > > reg = <0x0 0x17000014 0x0 0x100>; > > mask = <0x1>; > > }; > > + > > + sataphy0: sataphy@1f210000 { > > The nodes should better be named like "sata-phy@1f210000" to better comply > with the "ethernet-phy" name we see in the ePAPR spec. Well, since the phy can be used for other devices, I'd rather name it just "phy", or possibly "serdes". The fact that it happens to be used for sata here should not influence the naming when both the phy driver and the hardware are completely generic. Arnd
diff --git a/arch/arm64/boot/dts/apm-storm.dtsi b/arch/arm64/boot/dts/apm-storm.dtsi index 359d7b6..1d1c8bc 100644 --- a/arch/arm64/boot/dts/apm-storm.dtsi +++ b/arch/arm64/boot/dts/apm-storm.dtsi @@ -193,5 +193,33 @@ reg = <0x0 0x17000014 0x0 0x100>; mask = <0x1>; }; + + sataphy0: sataphy@1f210000 { + compatible = "apm,xgene-ahci-phy"; + reg = <0x0 0x1f210000 0x0 0x10000>; + #phy-cells = <0>; + status = "na"; + txbooster = <0x2 0x2 0x2 0x2 0x2 0x2>; + txskew = <0xa 0xa 0xa 0xa 0xa 0xa>; + }; + + sataphy1: sataphy@1f220000 { + compatible = "apm,xgene-ahci-phy"; + reg = <0x0 0x1f220000 0x0 0x10000>; + #phy-cells = <0>; + status = "ok"; + txbooster = <0x2 0x2 0x2 0x2 0x2 0x2>; + txskew = <0xa 0xa 0xa 0x5 0x5 0x5>; + }; + + sataphy2: sataphy@1f230000 { + compatible = "apm,xgene-ahci-phy2"; + reg = <0x0 0x1f230000 0x0 0x10000 + 0x0 0x1f2d0000 0x0 0x10000>; + #phy-cells = <0>; + status = "ok"; + txbooster = <0x3 0x3 0x3 0x3 0x3 0x3>; + txskew = <0xa 0xa 0xa 0xc 0xc 0xc>; + }; }; };