diff mbox

[2/2] ASoC: atmel: sam9x5_wm8731: remove platform_set_drvdata

Message ID 1385439472-23352-2-git-send-email-voice.shen@atmel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Bo Shen Nov. 26, 2013, 4:17 a.m. UTC
When call snd_soc_register_card, it will set driver data to this
device through dev_set_drvdata, then in driver, no need to call
platform_set_drvdata again, so remove it.

Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
 sound/soc/atmel/sam9x5_wm8731.c |    2 --
 1 file changed, 2 deletions(-)

Comments

Richard Genoud Nov. 26, 2013, 11:42 a.m. UTC | #1
2013/11/26 Bo Shen <voice.shen@atmel.com>:
> When call snd_soc_register_card, it will set driver data to this
> device through dev_set_drvdata, then in driver, no need to call
> platform_set_drvdata again, so remove it.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
>  sound/soc/atmel/sam9x5_wm8731.c |    2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/atmel/sam9x5_wm8731.c b/sound/soc/atmel/sam9x5_wm8731.c
> index 6dc33ac..4af6836 100644
> --- a/sound/soc/atmel/sam9x5_wm8731.c
> +++ b/sound/soc/atmel/sam9x5_wm8731.c
> @@ -154,8 +154,6 @@ static int sam9x5_wm8731_driver_probe(struct platform_device *pdev)
>         of_node_put(codec_np);
>         of_node_put(cpu_np);
>
> -       platform_set_drvdata(pdev, card);
> -
>         ret = snd_soc_register_card(card);
>         if (ret) {
>                 dev_err(&pdev->dev,
> --
> 1.7.9.5
>
Ok for me

Tested-by: Richard Genoud <richard.genoud@gmail.com>
diff mbox

Patch

diff --git a/sound/soc/atmel/sam9x5_wm8731.c b/sound/soc/atmel/sam9x5_wm8731.c
index 6dc33ac..4af6836 100644
--- a/sound/soc/atmel/sam9x5_wm8731.c
+++ b/sound/soc/atmel/sam9x5_wm8731.c
@@ -154,8 +154,6 @@  static int sam9x5_wm8731_driver_probe(struct platform_device *pdev)
 	of_node_put(codec_np);
 	of_node_put(cpu_np);
 
-	platform_set_drvdata(pdev, card);
-
 	ret = snd_soc_register_card(card);
 	if (ret) {
 		dev_err(&pdev->dev,