From patchwork Tue Dec 3 03:43:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 3273631 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 533C2C0D4A for ; Tue, 3 Dec 2013 04:21:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5548020136 for ; Tue, 3 Dec 2013 04:21:24 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25FCE20127 for ; Tue, 3 Dec 2013 04:21:23 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VngwQ-0007jW-7V; Tue, 03 Dec 2013 03:46:31 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Vngvh-0000FR-9g; Tue, 03 Dec 2013 03:45:45 +0000 Received: from comal.ext.ti.com ([198.47.26.152]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VnguW-0008Uz-GS for linux-arm-kernel@lists.infradead.org; Tue, 03 Dec 2013 03:44:43 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id rB33i23d018192; Mon, 2 Dec 2013 21:44:02 -0600 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id rB33i2Yb022141; Mon, 2 Dec 2013 21:44:02 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.2.342.3; Mon, 2 Dec 2013 21:44:02 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id rB33i1Ca005054; Mon, 2 Dec 2013 21:44:02 -0600 From: Felipe Balbi To: Linux OMAP Mailing List Subject: [PATCH v2 11/15] mfd: menelaus: Start to use irqdomain Date: Mon, 2 Dec 2013 21:43:04 -0600 Message-ID: <1386042188-12246-11-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.8.4.GIT In-Reply-To: <1386042188-12246-1-git-send-email-balbi@ti.com> References: <1386042188-12246-1-git-send-email-balbi@ti.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131202_224432_702506_68516C0A X-CRM114-Status: GOOD ( 18.30 ) X-Spam-Score: -6.9 (------) Cc: sameo@linux.intel.com, Aaro Koskinen , Tony Lindgren , Linux Kernel Mailing List , Felipe Balbi , lee.jones@linaro.org, Linux ARM Kernel Mailing List X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP introduce an irq_chip and irq_domain for menelaus driver. Following patches will convert uses to traditional request_threaded_irq(). while at that, some better error handling had to be added, so we could free irq descs we allocated. Signed-off-by: Felipe Balbi --- drivers/mfd/menelaus.c | 127 ++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 120 insertions(+), 7 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index aa3c579..e4f33b7 100644 --- a/drivers/mfd/menelaus.c +++ b/drivers/mfd/menelaus.c @@ -34,6 +34,7 @@ #include #include #include +#include #include #include #include @@ -47,6 +48,7 @@ #include #define DRIVER_NAME "menelaus" +#define MENELAUS_NR_IRQS 16 #define MENELAUS_I2C_ADDRESS 0x72 @@ -168,11 +170,19 @@ struct menelaus_chip { u8 rtc_control; unsigned uie:1; #endif + int irq_base; unsigned vcore_hw_mode:1; u8 mask1, mask2; + u8 ack1, ack2; + void (*handlers[16])(struct menelaus_chip *); void (*mmc_callback)(void *data, u8 mask); void *mmc_callback_data; + + unsigned mask1_pending:1; + unsigned mask2_pending:1; + unsigned ack1_pending:1; + unsigned ack2_pending:1; }; static struct menelaus_chip *the_menelaus; @@ -235,6 +245,83 @@ static int menelaus_ack_irq(struct menelaus_chip *m, int irq) return menelaus_write_reg(m, MENELAUS_INT_ACK1, 1 << irq); } +static void menelaus_irq_ack(struct irq_data *data) +{ + struct menelaus_chip *m = irq_data_get_irq_chip_data(data); + int irq = data->irq - m->irq_base; + + if (irq > 7) { + m->ack2 |= BIT(irq); + m->ack2_pending = true; + } else { + m->ack1 |= BIT(irq); + m->ack1_pending = true; + } +} + +static void menelaus_irq_mask(struct irq_data *data) +{ + struct menelaus_chip *m = irq_data_get_irq_chip_data(data); + int irq = data->irq - m->irq_base; + + if (irq > 7) { + m->mask2 |= BIT(irq); + m->mask2_pending = true; + } else { + m->mask1 |= BIT(irq); + m->mask1_pending = true; + } +} + +static void menelaus_irq_unmask(struct irq_data *data) +{ + struct menelaus_chip *m = irq_data_get_irq_chip_data(data); + int irq = data->irq - m->irq_base; + + if (irq > 7) { + m->mask2 &= ~BIT(irq); + m->mask2_pending = true; + } else { + m->mask1 &= ~BIT(irq); + m->mask1_pending = true; + } +} + +static void menelaus_irq_bus_lock(struct irq_data *data) +{ + struct menelaus_chip *m = irq_data_get_irq_chip_data(data); + + mutex_lock(&m->lock); +} + +static void menelaus_irq_bus_sync_unlock(struct irq_data *data) +{ + struct menelaus_chip *m = irq_data_get_irq_chip_data(data); + + if (m->ack1_pending) + menelaus_write_reg(m, MENELAUS_INT_ACK1, m->ack1); + + if (m->ack2_pending) + menelaus_write_reg(m, MENELAUS_INT_ACK2, m->ack2); + + if (m->mask1_pending) + menelaus_write_reg(m, MENELAUS_INT_MASK1, m->mask1); + + if (m->mask2_pending) + menelaus_write_reg(m, MENELAUS_INT_MASK2, m->mask2); + + mutex_unlock(&m->lock); +} + +static struct irq_chip menelaus_irq_chip = { + .name = "menelaus", + .irq_ack = menelaus_irq_ack, + .irq_mask = menelaus_irq_mask, + .irq_unmask = menelaus_irq_unmask, + .irq_bus_lock = menelaus_irq_bus_lock, + .irq_bus_sync_unlock = menelaus_irq_bus_sync_unlock, +}; + /* Adds a handler for an interrupt. Does not run in interrupt context */ static int menelaus_add_irq_work(struct menelaus_chip *m, int irq, void (*handler)(struct menelaus_chip *)) @@ -1186,8 +1273,11 @@ static int menelaus_probe(struct i2c_client *client, const struct i2c_device_id *id) { struct menelaus_chip *m; + struct device_node *node = client->dev.of_node; int rev = 0, val; int err = 0; + int irq_base; + int i; struct menelaus_platform_data *menelaus_pdata = dev_get_platdata(&client->dev); @@ -1205,12 +1295,32 @@ static int menelaus_probe(struct i2c_client *client, the_menelaus = m; m->client = client; + mutex_init(&m->lock); + + irq_base = irq_alloc_descs(-1, 0, MENELAUS_NR_IRQS, 0); + if (irq_base < 0) { + dev_err(&client->dev, "failed to allocate irq descs\n"); + return irq_base; + } + + irq_domain_add_legacy(node, MENELAUS_NR_IRQS, irq_base, 0, + &irq_domain_simple_ops, m); + + m->irq_base = irq_base; + + for (i = irq_base; i < irq_base + MENELAUS_NR_IRQS; i++) { + irq_set_chip_data(i, m); + irq_set_chip_and_handler(i, &menelaus_irq_chip, + handle_simple_irq); + irq_set_nested_thread(i, 1); + set_irq_flags(i, IRQF_VALID); + } /* If a true probe check the device */ rev = menelaus_read_reg(m, MENELAUS_REV); if (rev < 0) { pr_err(DRIVER_NAME ": device not found"); - return -ENODEV; + goto fail_free_descs; } /* Ack and disable all Menelaus interrupts */ @@ -1230,17 +1340,15 @@ static int menelaus_probe(struct i2c_client *client, if (err) { dev_dbg(&client->dev, "can't get IRQ %d, err %d\n", client->irq, err); - return err; + goto fail_free_descs; } } - mutex_init(&m->lock); - pr_info("Menelaus rev %d.%d\n", rev >> 4, rev & 0x0f); val = menelaus_read_reg(m, MENELAUS_VCORE_CTRL1); if (val < 0) - goto fail; + goto fail_free_irq; if (val & (1 << 7)) m->vcore_hw_mode = 1; else @@ -1249,14 +1357,18 @@ static int menelaus_probe(struct i2c_client *client, if (menelaus_pdata != NULL && menelaus_pdata->late_init != NULL) { err = menelaus_pdata->late_init(&client->dev); if (err < 0) - goto fail; + goto fail_free_irq; } menelaus_rtc_init(m); return 0; -fail: +fail_free_irq: free_irq(client->irq, m); + +fail_free_descs: + irq_free_descs(irq_base, MENELAUS_NR_IRQS); + return err; } @@ -1265,6 +1377,7 @@ static int menelaus_remove(struct i2c_client *client) struct menelaus_chip *m = i2c_get_clientdata(client); free_irq(client->irq, m); + irq_free_descs(m->irq_base, MENELAUS_NR_IRQS); the_menelaus = NULL; return 0; }