From patchwork Tue Dec 10 09:09:43 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 3316321 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E992FC0D4A for ; Tue, 10 Dec 2013 09:11:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CB3362017A for ; Tue, 10 Dec 2013 09:11:38 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12A3D2016D for ; Tue, 10 Dec 2013 09:11:34 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqJLO-0002mF-Iq; Tue, 10 Dec 2013 09:11:06 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqJLJ-0000Xu-JM; Tue, 10 Dec 2013 09:11:01 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqJL5-0000UQ-Hf for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2013 09:10:48 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MXL00CLY2T9DQ30@mailout1.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2013 09:10:21 +0000 (GMT) X-AuditID: cbfec7f5-b7fd16d000007299-9c-52a6da7c8233 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id E5.9B.29337.C7AD6A25; Tue, 10 Dec 2013 09:10:20 +0000 (GMT) Received: from AMDC1943.digital.local ([106.116.151.171]) by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0MXL003K82T4IM60@eusync3.samsung.com>; Tue, 10 Dec 2013 09:10:20 +0000 (GMT) From: Krzysztof Kozlowski To: Sangbeom Kim , Liam Girdwood , Mark Brown , Samuel Ortiz , Lee Jones , Jiri Kosina , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] regulator: s5m8767: Fix driver probe fail on BUCK7/8 regulators Date: Tue, 10 Dec 2013 10:09:43 +0100 Message-id: <1386666583-3280-2-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1386666583-3280-1-git-send-email-k.kozlowski@samsung.com> References: <1386666583-3280-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjluLIzCtJLcpLzFFi42I5/e/4Vd2aW8uCDN4c0baY+vAJm8XrF4YW Z5vesFvc/3qU0eLblQ4mi02Pr7FaXN41h81i7ZG77Banu1ktLq74wmTxfv9lJgduj52z7rJ7 bFrVyeZx59oeNo95JwM9Ni+p9+jbsorR4/MmuQD2KC6blNSczLLUIn27BK6MTxOnsxW85q2Y 92YPUwPjee4uRg4OCQETiYZG6S5GTiBTTOLCvfVsXYxcHEICSxklms/dZgdJCAn0MUnMbC8E sdkEjCU2L18CViQisIBJ4ti7i6wgDrNAL6PEg3e/GEGqhAXCJH4tbmQH2cAioCpx4okXSJhX wE1i4qZ2ZojFChJzJtmAhDkF3CVebO9mhdjlJvHsaA/7BEbeBYwMqxhFU0uTC4qT0nON9IoT c4tL89L1kvNzNzFCwvDrDsalx6wOMQpwMCrx8Er8WxokxJpYVlyZe4hRgoNZSYR39cllQUK8 KYmVValF+fFFpTmpxYcYmTg4pRoYVx63vyr0v+NBq3PIApYPxszNrMu/Sl96kTLRwJinf57w i7fPZ9e/2CFnf7puknenu2/B2ujcuwW8vfo+XgUL81Z4bjD/aBzg8KqD/+sdvrUbm35qOG+d r7XIZnbWa9uIPb4mCreniEimvGsQrVPc9Xz9IbatvRciDmROllj+SOnZF7sNT7wFlViKMxIN tZiLihMBUuicbSECAAA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131210_041047_765618_3F890EE2 X-CRM114-Status: GOOD ( 10.50 ) X-Spam-Score: -6.9 (------) Cc: Krzysztof Kozlowski , Kyungmin Park , Marek Szyprowski X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The BUCK7 and BUCK8 were not supported by s5m8767 driver. If they were configured in DTS then the driver probing would fail with EINVAL: [ 0.288474] VCC_SUB_1.35V: failed to apply 1350000uV constraint [ 0.288671] s5m8767-pmic s5m8767-pmic: regulator init failed for 35 [ 0.294931] s5m8767-pmic: probe of s5m8767-pmic failed with error -22 This patch adds support for BUCK7 and BUCK8 regulators using standard regmap get/set voltage sel functions. Signed-off-by: Krzysztof Kozlowski Cc: Kyungmin Park Cc: Marek Szyprowski --- drivers/regulator/s5m8767.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/s5m8767.c b/drivers/regulator/s5m8767.c index 58eb7a6c45e6..397917611ecd 100644 --- a/drivers/regulator/s5m8767.c +++ b/drivers/regulator/s5m8767.c @@ -120,8 +120,8 @@ static const struct sec_voltage_desc *reg_voltage_map[] = { [S5M8767_BUCK4] = &buck_voltage_val2, [S5M8767_BUCK5] = &buck_voltage_val1, [S5M8767_BUCK6] = &buck_voltage_val1, - [S5M8767_BUCK7] = NULL, - [S5M8767_BUCK8] = NULL, + [S5M8767_BUCK7] = &buck_voltage_val3, + [S5M8767_BUCK8] = &buck_voltage_val3, [S5M8767_BUCK9] = &buck_voltage_val3, }; @@ -418,9 +418,12 @@ static struct regulator_ops s5m8767_ops = { }; static struct regulator_ops s5m8767_buck78_ops = { + .list_voltage = regulator_list_voltage_linear, .is_enabled = s5m8767_reg_is_enabled, .enable = s5m8767_reg_enable, .disable = s5m8767_reg_disable, + .get_voltage_sel = regulator_get_voltage_sel_regmap, + .set_voltage_sel = regulator_set_voltage_sel_regmap, }; #define s5m8767_regulator_desc(_name) { \