From patchwork Tue Dec 10 20:24:57 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Balbi X-Patchwork-Id: 3320261 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A90909F1F0 for ; Tue, 10 Dec 2013 20:26:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D97932022D for ; Tue, 10 Dec 2013 20:26:23 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A033A20109 for ; Tue, 10 Dec 2013 20:26:22 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqTsh-0006Uu-Np; Tue, 10 Dec 2013 20:26:11 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqTsc-00056N-Ei; Tue, 10 Dec 2013 20:26:06 +0000 Received: from devils.ext.ti.com ([198.47.26.153]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1VqTsY-00054p-Vg for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2013 20:26:04 +0000 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id rBAKPfgh008599; Tue, 10 Dec 2013 14:25:41 -0600 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id rBAKPeT2016421; Tue, 10 Dec 2013 14:25:41 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.2.342.3; Tue, 10 Dec 2013 14:25:40 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id rBAKPen6018799; Tue, 10 Dec 2013 14:25:40 -0600 From: Felipe Balbi To: Kishon Vijay Abraham I Subject: [PATCH] phy: omap_usb2: fix module dependency Date: Tue, 10 Dec 2013 14:24:57 -0600 Message-ID: <1386707097-25650-1-git-send-email-balbi@ti.com> X-Mailer: git-send-email 1.8.4.GIT MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20131210_152603_126356_626E2F8B X-CRM114-Status: UNSURE ( 9.21 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -7.1 (-------) Cc: Tony Lindgren , Linux OMAP Mailing List , Linux USB Mailing List , Felipe Balbi , Linux ARM Kernel Mailing List X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Due to over-use of select statements, we could fall into a situation where CONFIG_USB_PHY would be enabled while CONFIG_USB_SUPPORT wouldn't. This would generate a situation where usb_bind_phy() would not be defined and kernel build for some OMAP2PLUS platforms would fail. Fix this by replacing a 'select' with a more proper 'depends on'. Reported-by: Russell King Signed-off-by: Felipe Balbi --- drivers/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index a344f3d..d8b1a9a 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -24,9 +24,9 @@ config PHY_EXYNOS_MIPI_VIDEO config OMAP_USB2 tristate "OMAP USB2 PHY Driver" depends on ARCH_OMAP2PLUS + depends on OMAP_CONTROL_USB select GENERIC_PHY select USB_PHY - select OMAP_CONTROL_USB help Enable this to support the transceiver that is part of SOC. This driver takes care of all the PHY functionality apart from comparator.