| Message ID | 1386817322-11265-3-git-send-email-a.kesavan@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Kukjin, On Thursday 12 of December 2013 08:32:02 Abhilash Kesavan wrote: > Fix wrong clock number in mdma0 node. > > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> > --- > arch/arm/boot/dts/exynos5250.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index 9db5047..177becd 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -559,7 +559,7 @@ > compatible = "arm,pl330", "arm,primecell"; > reg = <0x10800000 0x1000>; > interrupts = <0 33 0>; > - clocks = <&clock 271>; > + clocks = <&clock 346>; > clock-names = "apb_pclk"; > #dma-cells = <1>; > #dma-channels = <8>; > Can we have your ack for this patch? I'd like to apply the whole series into samsung-clk fixes branch and send a pull request to Mike to get it and one more fix into his tree. Best regards, Tomasz
On 12/18/13 23:49, Tomasz Figa wrote: > Hi Kukjin, > Hi, > On Thursday 12 of December 2013 08:32:02 Abhilash Kesavan wrote: >> Fix wrong clock number in mdma0 node. >> >> Signed-off-by: Abhilash Kesavan<a.kesavan@samsung.com> >> --- >> arch/arm/boot/dts/exynos5250.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi >> index 9db5047..177becd 100644 >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -559,7 +559,7 @@ >> compatible = "arm,pl330", "arm,primecell"; >> reg =<0x10800000 0x1000>; >> interrupts =<0 33 0>; >> - clocks =<&clock 271>; >> + clocks =<&clock 346>; >> clock-names = "apb_pclk"; >> #dma-cells =<1>; >> #dma-channels =<8>; >> > > Can we have your ack for this patch? > Sure, please feel free to add my ack on this series. Acked-by: Kukjin Kim <kgene.kim@samsung.com> > I'd like to apply the whole series into samsung-clk fixes branch and > send a pull request to Mike to get it and one more fix into his tree. > I'm fine, thanks. - Kukjin
Quoting Tomasz Figa (2013-12-18 06:49:10) > Hi Kukjin, > > On Thursday 12 of December 2013 08:32:02 Abhilash Kesavan wrote: > > Fix wrong clock number in mdma0 node. > > > > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> > > --- > > arch/arm/boot/dts/exynos5250.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > > index 9db5047..177becd 100644 > > --- a/arch/arm/boot/dts/exynos5250.dtsi > > +++ b/arch/arm/boot/dts/exynos5250.dtsi > > @@ -559,7 +559,7 @@ > > compatible = "arm,pl330", "arm,primecell"; > > reg = <0x10800000 0x1000>; > > interrupts = <0 33 0>; > > - clocks = <&clock 271>; > > + clocks = <&clock 346>; > > clock-names = "apb_pclk"; > > #dma-cells = <1>; > > #dma-channels = <8>; > > > > Can we have your ack for this patch? > > I'd like to apply the whole series into samsung-clk fixes branch and > send a pull request to Mike to get it and one more fix into his tree. Do these fixes need to go into the current -rc fixes cycle or can they go for 3.14? Regards, Mike > > Best regards, > Tomasz >
Hi Mike, On Wednesday 18 of December 2013 11:32:03 Mike Turquette wrote: > Quoting Tomasz Figa (2013-12-18 06:49:10) > > Hi Kukjin, > > > > On Thursday 12 of December 2013 08:32:02 Abhilash Kesavan wrote: > > > Fix wrong clock number in mdma0 node. > > > > > > Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> > > > --- > > > arch/arm/boot/dts/exynos5250.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > > > index 9db5047..177becd 100644 > > > --- a/arch/arm/boot/dts/exynos5250.dtsi > > > +++ b/arch/arm/boot/dts/exynos5250.dtsi > > > @@ -559,7 +559,7 @@ > > > compatible = "arm,pl330", "arm,primecell"; > > > reg = <0x10800000 0x1000>; > > > interrupts = <0 33 0>; > > > - clocks = <&clock 271>; > > > + clocks = <&clock 346>; > > > clock-names = "apb_pclk"; > > > #dma-cells = <1>; > > > #dma-channels = <8>; > > > > > > > Can we have your ack for this patch? > > > > I'd like to apply the whole series into samsung-clk fixes branch and > > send a pull request to Mike to get it and one more fix into his tree. > > Do these fixes need to go into the current -rc fixes cycle or can they > go for 3.14? I'd say that this should go as an -rc fix, because on some systems on which the firmware may leave the mdma0 clock disabled by default, trying to initialize MDMA0 by PL330 driver might cause booting failure. Can we get your ack on this, so I could apply this and send you a pull request with all fixes? Best regards, Tomasz
diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 9db5047..177becd 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -559,7 +559,7 @@ compatible = "arm,pl330", "arm,primecell"; reg = <0x10800000 0x1000>; interrupts = <0 33 0>; - clocks = <&clock 271>; + clocks = <&clock 346>; clock-names = "apb_pclk"; #dma-cells = <1>; #dma-channels = <8>;
Fix wrong clock number in mdma0 node. Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com> --- arch/arm/boot/dts/exynos5250.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)