diff mbox

[1/2] ARM: tegra: enable ams AS3722 drivers

Message ID 1386855064-10993-1-git-send-email-ldewangan@nvidia.com (mailing list archive)
State New, archived
Headers show

Commit Message

Laxman Dewangan Dec. 12, 2013, 1:31 p.m. UTC
ams AS3722 is the system power manager module IC for the Tegra124 based
Venice2 platform. Enable configs for gpio, pincontrol, rtc, regulator
support from this device.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
 arch/arm/configs/tegra_defconfig |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Comments

Stephen Warren Dec. 12, 2013, 9:20 p.m. UTC | #1
On 12/12/2013 06:31 AM, Laxman Dewangan wrote:
> ams AS3722 is the system power manager module IC for the Tegra124 based
> Venice2 platform. Enable configs for gpio, pincontrol, rtc, regulator
> support from this device.

I've squashed patch 1/2 into Tegra's for-3.14/defconfig branch.

I've applied patch 2/2 to Tegra's for-3.14/dt branch.
Stephen Warren Dec. 12, 2013, 9:51 p.m. UTC | #2
On 12/12/2013 02:20 PM, Stephen Warren wrote:
> On 12/12/2013 06:31 AM, Laxman Dewangan wrote:
>> ams AS3722 is the system power manager module IC for the Tegra124 based
>> Venice2 platform. Enable configs for gpio, pincontrol, rtc, regulator
>> support from this device.
> 
> I've squashed patch 1/2 into Tegra's for-3.14/defconfig branch.
> 
> I've applied patch 2/2 to Tegra's for-3.14/dt branch.

Actually, I'm dropping patch 2/2 since it causes a whole bunch of error
spew during boot:

> [    0.628315] tegra124-pinctrl 70000868.pinmux: invalid group "dap2_dout_pp2" for function "rsvd4"
> [    0.635309] tegra124-pinctrl 70000868.pinmux: does not have pin group dap2_dout_pp2
> [    0.642999] tegra124-pinctrl 70000868.pinmux: could not map group config for "dap2_dout_pp2"

> [    0.731176] as3722-pinctrl as3722-pinctrl: pin gpio0 already requested by as3722-pinctrl; cannot claim for as3722-regulator
> [    0.742312] as3722-pinctrl as3722-pinctrl: pin-0 (as3722-regulator) status -22
> [    0.749526] as3722-pinctrl as3722-pinctrl: could not request pin 0 (gpio0) from group gpio0  on device as3722-pinctrl
> [    0.760133] as3722-regulator as3722-regulator: Error applying setting, reverse things back

> [    0.835838] as3722-regulator as3722-regulator: Failed to find supply vin-ldo1-6
> [    0.843312] as3722-regulator as3722-regulator: regulator 8 register failed -517
> [    0.852263] platform as3722-regulator: Driver as3722-regulator requests probe deferral

> [    0.984920] as3722-pinctrl as3722-pinctrl: pin gpio0 already requested by as3722-pinctrl; cannot claim for as3722-rtc
> [    0.995537] as3722-pinctrl as3722-pinctrl: pin-0 (as3722-rtc) status -22
> [    1.002244] as3722-pinctrl as3722-pinctrl: could not request pin 0 (gpio0) from group gpio0  on device as3722-pinctrl
> [    1.012848] as3722-rtc as3722-rtc: Error applying setting, reverse things back
Laxman Dewangan Dec. 13, 2013, 6:24 a.m. UTC | #3
On Friday 13 December 2013 03:21 AM, Stephen Warren wrote:
> On 12/12/2013 02:20 PM, Stephen Warren wrote:
>> On 12/12/2013 06:31 AM, Laxman Dewangan wrote:
>>> ams AS3722 is the system power manager module IC for the Tegra124 based
>>> Venice2 platform. Enable configs for gpio, pincontrol, rtc, regulator
>>> support from this device.
>> I've squashed patch 1/2 into Tegra's for-3.14/defconfig branch.
>>
>> I've applied patch 2/2 to Tegra's for-3.14/dt branch.
> Actually, I'm dropping patch 2/2 since it causes a whole bunch of error
> spew during boot:
>
>> [    0.628315] tegra124-pinctrl 70000868.pinmux: invalid group "dap2_dout_pp2" for function "rsvd4"
>> [    0.635309] tegra124-pinctrl 70000868.pinmux: does not have pin group dap2_dout_pp2
>> [    0.642999] tegra124-pinctrl 70000868.pinmux: could not map group config for "dap2_dout_pp2"
>> [    0.731176] as3722-pinctrl as3722-pinctrl: pin gpio0 already requested by as3722-pinctrl; cannot claim for as3722-regulator
>> [    0.742312] as3722-pinctrl as3722-pinctrl: pin-0 (as3722-regulator) status -22
>> [    0.749526] as3722-pinctrl as3722-pinctrl: could not request pin 0 (gpio0) from group gpio0  on device as3722-pinctrl
>> [    0.760133] as3722-regulator as3722-regulator: Error applying setting, reverse things back
>> [    0.835838] as3722-regulator as3722-regulator: Failed to find supply vin-ldo1-6
>> [    0.843312] as3722-regulator as3722-regulator: regulator 8 register failed -517
>> [    0.852263] platform as3722-regulator: Driver as3722-regulator requests probe deferral
>> [    0.984920] as3722-pinctrl as3722-pinctrl: pin gpio0 already requested by as3722-pinctrl; cannot claim for as3722-rtc
>> [    0.995537] as3722-pinctrl as3722-pinctrl: pin-0 (as3722-rtc) status -22
>> [    1.002244] as3722-pinctrl as3722-pinctrl: could not request pin 0 (gpio0) from group gpio0  on device as3722-pinctrl
>> [    1.012848] as3722-rtc as3722-rtc: Error applying setting, reverse things back

I did not observe this issue in my log, probably overlooked.
I will repro this and fix/update the issue/patch.

Thanks,
laxman
diff mbox

Patch

diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
index 4461185..5cf4a48 100644
--- a/arch/arm/configs/tegra_defconfig
+++ b/arch/arm/configs/tegra_defconfig
@@ -137,6 +137,7 @@  CONFIG_SPI=y
 CONFIG_SPI_TEGRA114=y
 CONFIG_SPI_TEGRA20_SFLASH=y
 CONFIG_SPI_TEGRA20_SLINK=y
+CONFIG_PINCTRL_AS3722=y
 CONFIG_PINCTRL_PALMAS=y
 CONFIG_GPIO_SYSFS=y
 CONFIG_GPIO_PCA953X_IRQ=y
@@ -149,6 +150,7 @@  CONFIG_CHARGER_TPS65090=y
 CONFIG_POWER_RESET=y
 CONFIG_POWER_RESET_GPIO=y
 CONFIG_SENSORS_LM90=y
+CONFIG_MFD_AS3722=y
 CONFIG_MFD_MAX8907=y
 CONFIG_MFD_PALMAS=y
 CONFIG_MFD_TPS65090=y
@@ -157,6 +159,7 @@  CONFIG_MFD_TPS65910=y
 CONFIG_REGULATOR=y
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
 CONFIG_REGULATOR_VIRTUAL_CONSUMER=y
+CONFIG_REGULATOR_AS3722=y
 CONFIG_REGULATOR_GPIO=y
 CONFIG_REGULATOR_MAX8907=y
 CONFIG_REGULATOR_PALMAS=y
@@ -218,6 +221,7 @@  CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
 CONFIG_LEDS_TRIGGER_TRANSIENT=y
 CONFIG_LEDS_TRIGGER_CAMERA=y
 CONFIG_RTC_CLASS=y
+CONFIG_RTC_DRV_AS3722=y
 CONFIG_RTC_DRV_MAX8907=y
 CONFIG_RTC_DRV_PALMAS=y
 CONFIG_RTC_DRV_TPS6586X=y