diff mbox

iio: at91: document ADC clock properties

Message ID 1387296973-7779-1-git-send-email-b.brezillon@overkiz.com (mailing list archive)
State New, archived
Headers show

Commit Message

Boris BREZILLON Dec. 17, 2013, 4:16 p.m. UTC
Document the clock properties required by the at91 ADC driver.

Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
---
 .../devicetree/bindings/arm/atmel-adc.txt          |    5 +++++
 1 file changed, 5 insertions(+)

Comments

Nicolas Ferre Dec. 19, 2013, 3:54 p.m. UTC | #1
On 17/12/2013 17:16, Boris BREZILLON :
> Document the clock properties required by the at91 ADC driver.
> 
> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

> ---
>  .../devicetree/bindings/arm/atmel-adc.txt          |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
> index d106146..9a1175b 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
> +++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
> @@ -5,6 +5,9 @@ Required properties:
>      <chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
>    - reg: Should contain ADC registers location and length
>    - interrupts: Should contain the IRQ line for the ADC
> +  - clock-names: tuple listing input clock names.
> +	Required elements: "adc_clk", "adc_op_clk".
> +  - clocks: phandles to input clocks.
>    - atmel,adc-channels-used: Bitmask of the channels muxed and enable for this
>      device
>    - atmel,adc-startup-time: Startup Time of the ADC in microseconds as
> @@ -44,6 +47,8 @@ adc0: adc@fffb0000 {
>  	compatible = "atmel,at91sam9260-adc";
>  	reg = <0xfffb0000 0x100>;
>  	interrupts = <20 4>;
> +	clocks = <&adc_clk>, <&adc_op_clk>;
> +	clock-names = "adc_clk", "adc_op_clk";
>  	atmel,adc-channel-base = <0x30>;
>  	atmel,adc-channels-used = <0xff>;
>  	atmel,adc-drdy-mask = <0x10000>;
>
Jonathan Cameron Dec. 22, 2013, 6:05 p.m. UTC | #2
On 12/19/13 15:54, Nicolas Ferre wrote:
> On 17/12/2013 17:16, Boris BREZILLON :
>> Document the clock properties required by the at91 ADC driver.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Looks fine to me.  I'm just waiting on an ack from a device tree maintainer
(or the 3 weeks to pass so I can pick it up anyway ;)

> 
>> ---
>>  .../devicetree/bindings/arm/atmel-adc.txt          |    5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> index d106146..9a1175b 100644
>> --- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> +++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>> @@ -5,6 +5,9 @@ Required properties:
>>      <chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
>>    - reg: Should contain ADC registers location and length
>>    - interrupts: Should contain the IRQ line for the ADC
>> +  - clock-names: tuple listing input clock names.
>> +	Required elements: "adc_clk", "adc_op_clk".
>> +  - clocks: phandles to input clocks.
>>    - atmel,adc-channels-used: Bitmask of the channels muxed and enable for this
>>      device
>>    - atmel,adc-startup-time: Startup Time of the ADC in microseconds as
>> @@ -44,6 +47,8 @@ adc0: adc@fffb0000 {
>>  	compatible = "atmel,at91sam9260-adc";
>>  	reg = <0xfffb0000 0x100>;
>>  	interrupts = <20 4>;
>> +	clocks = <&adc_clk>, <&adc_op_clk>;
>> +	clock-names = "adc_clk", "adc_op_clk";
>>  	atmel,adc-channel-base = <0x30>;
>>  	atmel,adc-channels-used = <0xff>;
>>  	atmel,adc-drdy-mask = <0x10000>;
>>
> 
>
Jonathan Cameron Jan. 11, 2014, 4:29 p.m. UTC | #3
On 22/12/13 18:05, Jonathan Cameron wrote:
> On 12/19/13 15:54, Nicolas Ferre wrote:
>> On 17/12/2013 17:16, Boris BREZILLON :
>>> Document the clock properties required by the at91 ADC driver.
>>>
>>> Signed-off-by: Boris BREZILLON <b.brezillon@overkiz.com>
>>
>> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Looks fine to me.  I'm just waiting on an ack from a device tree maintainer
> (or the 3 weeks to pass so I can pick it up anyway ;)
That's near enough 3 weeks (one day short) so applied to the togreg branch of iio.git.
Thanks
>
>>
>>> ---
>>>   .../devicetree/bindings/arm/atmel-adc.txt          |    5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>>> index d106146..9a1175b 100644
>>> --- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
>>> +++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
>>> @@ -5,6 +5,9 @@ Required properties:
>>>       <chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
>>>     - reg: Should contain ADC registers location and length
>>>     - interrupts: Should contain the IRQ line for the ADC
>>> +  - clock-names: tuple listing input clock names.
>>> +	Required elements: "adc_clk", "adc_op_clk".
>>> +  - clocks: phandles to input clocks.
>>>     - atmel,adc-channels-used: Bitmask of the channels muxed and enable for this
>>>       device
>>>     - atmel,adc-startup-time: Startup Time of the ADC in microseconds as
>>> @@ -44,6 +47,8 @@ adc0: adc@fffb0000 {
>>>   	compatible = "atmel,at91sam9260-adc";
>>>   	reg = <0xfffb0000 0x100>;
>>>   	interrupts = <20 4>;
>>> +	clocks = <&adc_clk>, <&adc_op_clk>;
>>> +	clock-names = "adc_clk", "adc_op_clk";
>>>   	atmel,adc-channel-base = <0x30>;
>>>   	atmel,adc-channels-used = <0xff>;
>>>   	atmel,adc-drdy-mask = <0x10000>;
>>>
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/atmel-adc.txt b/Documentation/devicetree/bindings/arm/atmel-adc.txt
index d106146..9a1175b 100644
--- a/Documentation/devicetree/bindings/arm/atmel-adc.txt
+++ b/Documentation/devicetree/bindings/arm/atmel-adc.txt
@@ -5,6 +5,9 @@  Required properties:
     <chip> can be "at91sam9260", "at91sam9g45" or "at91sam9x5"
   - reg: Should contain ADC registers location and length
   - interrupts: Should contain the IRQ line for the ADC
+  - clock-names: tuple listing input clock names.
+	Required elements: "adc_clk", "adc_op_clk".
+  - clocks: phandles to input clocks.
   - atmel,adc-channels-used: Bitmask of the channels muxed and enable for this
     device
   - atmel,adc-startup-time: Startup Time of the ADC in microseconds as
@@ -44,6 +47,8 @@  adc0: adc@fffb0000 {
 	compatible = "atmel,at91sam9260-adc";
 	reg = <0xfffb0000 0x100>;
 	interrupts = <20 4>;
+	clocks = <&adc_clk>, <&adc_op_clk>;
+	clock-names = "adc_clk", "adc_op_clk";
 	atmel,adc-channel-base = <0x30>;
 	atmel,adc-channels-used = <0xff>;
 	atmel,adc-drdy-mask = <0x10000>;