| Message ID | 1387469182-14398-5-git-send-email-treding@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12/19/2013 09:06 AM, Thierry Reding wrote: > diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi > + sor@54540000 { > + compatible = "nvidia,tegra124-sor"; I don't see a binding document for that compatible value anywhere in next-20131219, nor in your drm/for-next branch. Still, the DT content/schema is essentially identical to many others that already exist, so I won't block applying the series because of that. Please do write a binding document though! > + dpaux@545c0000 { > + compatible = "nvidia,tegra124-dpaux"; Same comment.
On Thu, Dec 19, 2013 at 01:46:13PM -0700, Stephen Warren wrote: > On 12/19/2013 09:06 AM, Thierry Reding wrote: > > > diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi > > > + sor@54540000 { > > + compatible = "nvidia,tegra124-sor"; > > I don't see a binding document for that compatible value anywhere in > next-20131219, nor in your drm/for-next branch. Still, the DT > content/schema is essentially identical to many others that already > exist, so I won't block applying the series because of that. Please do > write a binding document though! > > > + dpaux@545c0000 { > > + compatible = "nvidia,tegra124-dpaux"; > > Same comment. The binding documentation for those nodes is part of the eDP patch that's still awaiting internal review, that's why it hasn't appeared yet in linux-next or my drm/for-next branch. I'm hoping that will happen any day now, though. Thierry
diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi index 0a4e5271b5f9..39d77aa936f9 100644 --- a/arch/arm/boot/dts/tegra124.dtsi +++ b/arch/arm/boot/dts/tegra124.dtsi @@ -44,6 +44,32 @@ resets = <&tegra_car 26>; reset-names = "dc"; }; + + sor@54540000 { + compatible = "nvidia,tegra124-sor"; + reg = <0x54540000 0x00040000>; + interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&tegra_car TEGRA124_CLK_SOR0>, + <&tegra_car TEGRA124_CLK_PLL_D_OUT0>, + <&tegra_car TEGRA124_CLK_PLL_DP>, + <&tegra_car TEGRA124_CLK_CLK_M>; + clock-names = "sor", "parent", "dp", "safe"; + resets = <&tegra_car 182>; + reset-names = "sor"; + status = "disabled"; + }; + + dpaux@545c0000 { + compatible = "nvidia,tegra124-dpaux"; + reg = <0x545c0000 0x00040000>; + interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&tegra_car TEGRA124_CLK_DPAUX>, + <&tegra_car TEGRA124_CLK_PLL_DP>; + clock-names = "dpaux", "parent"; + resets = <&tegra_car 181>; + reset-names = "dpaux"; + status = "disabled"; + }; }; gic: interrupt-controller@50041000 {
Signed-off-by: Thierry Reding <treding@nvidia.com> --- arch/arm/boot/dts/tegra124.dtsi | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)