diff mbox

[PATCHv4,2/4] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio Interface node for VF610.

Message ID 1387501387-2151-2-git-send-email-Li.Xiubo@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Xiubo Li Dec. 20, 2013, 1:03 a.m. UTC
This patch adds the SAI's edma mux Tx and Rx support.

Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Signed-off-by: Jingchang Lu <b35083@freescale.com>
---
 arch/arm/boot/dts/vf610.dtsi | 3 +++
 1 file changed, 3 insertions(+)

Comments

Mark Brown Dec. 20, 2013, 11:08 a.m. UTC | #1
On Fri, Dec 20, 2013 at 09:03:05AM +0800, Xiubo Li wrote:
> This patch adds the SAI's edma mux Tx and Rx support.

DTS changes should be merged via arm-soc.
Xiubo Li Dec. 20, 2013, 11:12 a.m. UTC | #2
> Subject: Re: [PATCHv4 2/4] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio
> Interface node for VF610.
> 
> On Fri, Dec 20, 2013 at 09:03:05AM +0800, Xiubo Li wrote:
> > This patch adds the SAI's edma mux Tx and Rx support.
> 
> DTS changes should be merged via arm-soc.

Okey, Got it.

Thanks,

Best Regards
Xiubo
Xiubo Li Dec. 20, 2013, 11:30 a.m. UTC | #3
Hi,

  Could someone help review and merge this DTS patch please ?

  Thanks very much!

Best Regards,
Xiubo



> Subject: [PATCHv4 2/4] ARM: dts: Add Freescale SAI ALSA SoC Digital Audio
> Interface node for VF610.
> 
> This patch adds the SAI's edma mux Tx and Rx support.
> 
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> Signed-off-by: Jingchang Lu <b35083@freescale.com>
> ---
>  arch/arm/boot/dts/vf610.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> index e84d84c..2d6ddd0 100644
> --- a/arch/arm/boot/dts/vf610.dtsi
> +++ b/arch/arm/boot/dts/vf610.dtsi
> @@ -166,6 +166,9 @@
>  				interrupts = <0 86 0x04>;
>  				clocks = <&clks VF610_CLK_SAI2>;
>  				clock-names = "sai";
> +				dma-names = "tx", "rx";
> +				dmas = <&edma0 0 VF610_EDMA_MUXID0_SAI2_TX>,
> +					<&edma0 0 VF610_EDMA_MUXID0_SAI2_RX>;
>  				status = "disabled";
>  			};
> 
> --
> 1.8.4
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
Shawn Guo Dec. 27, 2013, 8:53 a.m. UTC | #4
On Fri, Dec 20, 2013 at 09:03:05AM +0800, Xiubo Li wrote:
> This patch adds the SAI's edma mux Tx and Rx support.
> 
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> Signed-off-by: Jingchang Lu <b35083@freescale.com>
> ---
>  arch/arm/boot/dts/vf610.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> index e84d84c..2d6ddd0 100644
> --- a/arch/arm/boot/dts/vf610.dtsi
> +++ b/arch/arm/boot/dts/vf610.dtsi
> @@ -166,6 +166,9 @@
>  				interrupts = <0 86 0x04>;
>  				clocks = <&clks VF610_CLK_SAI2>;
>  				clock-names = "sai";
> +				dma-names = "tx", "rx";
> +				dmas = <&edma0 0 VF610_EDMA_MUXID0_SAI2_TX>,
> +					<&edma0 0 VF610_EDMA_MUXID0_SAI2_RX>;

Where are these VF610_EDMA_MUXID0_* macros defined?  I cannot find them
in my tree.

Shawn

>  				status = "disabled";
>  			};
>  
> -- 
> 1.8.4
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Xiubo Li Dec. 27, 2013, 9:08 a.m. UTC | #5
Hi Shawn,

> > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> > index e84d84c..2d6ddd0 100644
> > --- a/arch/arm/boot/dts/vf610.dtsi
> > +++ b/arch/arm/boot/dts/vf610.dtsi
> > @@ -166,6 +166,9 @@
> >  				interrupts = <0 86 0x04>;
> >  				clocks = <&clks VF610_CLK_SAI2>;
> >  				clock-names = "sai";
> > +				dma-names = "tx", "rx";
> > +				dmas = <&edma0 0 VF610_EDMA_MUXID0_SAI2_TX>,
> > +					<&edma0 0 VF610_EDMA_MUXID0_SAI2_RX>;
> 
> Where are these VF610_EDMA_MUXID0_* macros defined?  I cannot find them
> in my tree.
>

Sorry, this is depended on the eDMA driver, which is still doing the upstream
work by another colleague.

I will let you know if the eDMA driver has been merged in.


Thanks,

Best Regards,
Xiubo
diff mbox

Patch

diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index e84d84c..2d6ddd0 100644
--- a/arch/arm/boot/dts/vf610.dtsi
+++ b/arch/arm/boot/dts/vf610.dtsi
@@ -166,6 +166,9 @@ 
 				interrupts = <0 86 0x04>;
 				clocks = <&clks VF610_CLK_SAI2>;
 				clock-names = "sai";
+				dma-names = "tx", "rx";
+				dmas = <&edma0 0 VF610_EDMA_MUXID0_SAI2_TX>,
+					<&edma0 0 VF610_EDMA_MUXID0_SAI2_RX>;
 				status = "disabled";
 			};