| Message ID | 1387891931-9854-4-git-send-email-pdeschrijver@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12/24/2013 06:32 AM, Peter De Schrijver wrote: > Add efuse bindings for Tegra20, Tegra30, Tegra114 and Tegra124. This patch doesn't add bindings, it adds nodes to device trees. Bindings are the schemas that dictate how the nodes are to be constructed, not the nodes themselves. On that topic, this series needs to create Documentation/devicetree/bindings/fuse/nvidia,tegra20-fuse.txt etc. > diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi > + efuse@7000f800 { ... > + }; > + > cpus { This node isn't sorted correctly. It should be between sdhci@700b0600 and ahub@70300000, not after the ahub. > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > + efuse@7000F800 { "fuse" might be a better node name; "efuse" is presumably the name of the instance, not the type of object. Please use lower-case for hex constants; both here and in the reg property.
On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: > On 12/24/2013 06:32 AM, Peter De Schrijver wrote: [...] > > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > > > + efuse@7000F800 { > > "fuse" might be a better node name; "efuse" is presumably the name of > the instance, not the type of object. There's another occurrence I noticed recently where we haven't followed that rule. The PMIC node on Venice2 for instance is called as3722. Perhaps that should also be renamed. Thierry
On 01/08/2014 06:39 AM, Thierry Reding wrote: > On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: >> On 12/24/2013 06:32 AM, Peter De Schrijver wrote: > [...] >>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi >> >>> + efuse@7000F800 { >> >> "fuse" might be a better node name; "efuse" is presumably the name of >> the instance, not the type of object. > > There's another occurrence I noticed recently where we haven't followed > that rule. The PMIC node on Venice2 for instance is called as3722. > Perhaps that should also be renamed. Yes, we should fix that. Care to send a patch?
On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote: > On 01/08/2014 06:39 AM, Thierry Reding wrote: > > On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: > >> On 12/24/2013 06:32 AM, Peter De Schrijver wrote: > > [...] > >>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > >> > >>> + efuse@7000F800 { > >> > >> "fuse" might be a better node name; "efuse" is presumably the name of > >> the instance, not the type of object. > > > > There's another occurrence I noticed recently where we haven't followed > > that rule. The PMIC node on Venice2 for instance is called as3722. > > Perhaps that should also be renamed. > > Yes, we should fix that. Care to send a patch? Will do. Thierry
On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote: > On 01/08/2014 06:39 AM, Thierry Reding wrote: > > On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: > >> On 12/24/2013 06:32 AM, Peter De Schrijver wrote: > > [...] > >>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > >> > >>> + efuse@7000F800 { > >> > >> "fuse" might be a better node name; "efuse" is presumably the name of > >> the instance, not the type of object. > > > > There's another occurrence I noticed recently where we haven't followed > > that rule. The PMIC node on Venice2 for instance is called as3722. > > Perhaps that should also be renamed. > > Yes, we should fix that. Care to send a patch? Ugh... I've just been going through some of the other DTS files and see that quite a lot of other places aren't following this rule either. The Beaver DTS has things like: rt5640: rt5640@1c { ... }; which I guess "should have been" rt5640: codec@1c { /* or even audio-codec@1c */ ... }; and pmic: tps65911@2d { ... }; > which would be another candidate for pmic@2d. Perhaps it isn't worth fixing them all up after all? Thierry
On 01/08/2014 01:09 PM, Thierry Reding wrote: > On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote: >> On 01/08/2014 06:39 AM, Thierry Reding wrote: >>> On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: >>>> On 12/24/2013 06:32 AM, Peter De Schrijver wrote: >>> [...] >>>>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi >>>> >>>>> + efuse@7000F800 { >>>> >>>> "fuse" might be a better node name; "efuse" is presumably the name of >>>> the instance, not the type of object. >>> >>> There's another occurrence I noticed recently where we haven't followed >>> that rule. The PMIC node on Venice2 for instance is called as3722. >>> Perhaps that should also be renamed. >> >> Yes, we should fix that. Care to send a patch? > > Ugh... I've just been going through some of the other DTS files and see > that quite a lot of other places aren't following this rule either. The ... > Perhaps it isn't worth fixing them all up after all? I guess that just means the patch will be a little bigger; it doesn't seem like that's a good reason not to fix the issue.
On Wed, Jan 08, 2014 at 03:41:52PM -0700, Stephen Warren wrote: > On 01/08/2014 01:09 PM, Thierry Reding wrote: > > On Wed, Jan 08, 2014 at 11:50:35AM -0700, Stephen Warren wrote: > >> On 01/08/2014 06:39 AM, Thierry Reding wrote: > >>> On Mon, Jan 06, 2014 at 01:40:51PM -0700, Stephen Warren wrote: > >>>> On 12/24/2013 06:32 AM, Peter De Schrijver wrote: > >>> [...] > >>>>> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > >>>> > >>>>> + efuse@7000F800 { > >>>> > >>>> "fuse" might be a better node name; "efuse" is presumably the name of > >>>> the instance, not the type of object. > >>> > >>> There's another occurrence I noticed recently where we haven't followed > >>> that rule. The PMIC node on Venice2 for instance is called as3722. > >>> Perhaps that should also be renamed. > >> > >> Yes, we should fix that. Care to send a patch? > > > > Ugh... I've just been going through some of the other DTS files and see > > that quite a lot of other places aren't following this rule either. The > ... > > Perhaps it isn't worth fixing them all up after all? > > I guess that just means the patch will be a little bigger; it doesn't > seem like that's a good reason not to fix the issue. Alright, I'll make a pass over all the DTS files that we have and try to restore some consistency. Thierry
diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi index 389e987..68c616e 100644 --- a/arch/arm/boot/dts/tegra114.dtsi +++ b/arch/arm/boot/dts/tegra114.dtsi @@ -481,6 +481,12 @@ clock-names = "pclk", "clk32k_in"; }; + efuse@7000f800 { + compatible = "nvidia,tegra114-efuse"; + reg = <0x7000f800 0x400>; + clocks = <&tegra_car TEGRA114_CLK_FUSE>; + }; + iommu@70019010 { compatible = "nvidia,tegra114-smmu", "nvidia,tegra30-smmu"; reg = <0x70019010 0x02c diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi index ec0698a..97bd8e0 100644 --- a/arch/arm/boot/dts/tegra124.dtsi +++ b/arch/arm/boot/dts/tegra124.dtsi @@ -524,6 +524,12 @@ }; }; + efuse@7000f800 { + compatible = "nvidia,tegra124-efuse"; + reg = <0x7000f800 0x400>; + clocks = <&tegra_car TEGRA124_CLK_FUSE>; + }; + cpus { #address-cells = <1>; #size-cells = <0>; diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi index 480ecda..f647aaa 100644 --- a/arch/arm/boot/dts/tegra20.dtsi +++ b/arch/arm/boot/dts/tegra20.dtsi @@ -541,6 +541,12 @@ #size-cells = <0>; }; + efuse@7000F800 { + compatible = "nvidia,tegra20-efuse"; + reg = <0x7000F800 0x400>; + clocks = <&tegra_car TEGRA20_CLK_FUSE>; + }; + pcie-controller@80003000 { compatible = "nvidia,tegra20-pcie"; device_type = "pci"; diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi index ed8e770..828465e 100644 --- a/arch/arm/boot/dts/tegra30.dtsi +++ b/arch/arm/boot/dts/tegra30.dtsi @@ -623,6 +623,12 @@ nvidia,ahb = <&ahb>; }; + efuse@7000f800 { + compatible = "nvidia,tegra30-efuse"; + reg = <0x7000f800 0x400>; + clocks = <&tegra_car TEGRA30_CLK_FUSE>; + }; + ahub@70080000 { compatible = "nvidia,tegra30-ahub"; reg = <0x70080000 0x200
Add efuse bindings for Tegra20, Tegra30, Tegra114 and Tegra124. Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com> --- arch/arm/boot/dts/tegra114.dtsi | 6 ++++++ arch/arm/boot/dts/tegra124.dtsi | 6 ++++++ arch/arm/boot/dts/tegra20.dtsi | 6 ++++++ arch/arm/boot/dts/tegra30.dtsi | 6 ++++++ 4 files changed, 24 insertions(+), 0 deletions(-)