| Message ID | 1389323046-4521-1-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 01/10/2014 06:04 AM, Pankaj Dubey wrote: > If used 64 bit compiler GCC warns that: > drivers/net/ethernet/smsc/smc91x.c:1897:7: > warning: cast from pointer to integer of different > size [-Wpointer-to-int-cast] > This patch fixes this by changing typecase from "unsigned int" to "unsigned long" Only "typecast". > CC: "David S. Miller" <davem@davemloft.net> > CC: Jingoo Han <jg1.han@samsung.com> > CC: netdev@vger.kernel.org > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> WBR, Sergei
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Date: Fri, 10 Jan 2014 23:42:41 +0300 > Hello. > > On 01/10/2014 06:04 AM, Pankaj Dubey wrote: > >> If used 64 bit compiler GCC warns that: > >> drivers/net/ethernet/smsc/smc91x.c:1897:7: >> warning: cast from pointer to integer of different >> size [-Wpointer-to-int-cast] > >> This patch fixes this by changing typecase from "unsigned int" to >> "unsigned long" > > Only "typecast". Applied with this typo fixed, thanks.
diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index 0c9b5d9..42e79b4 100644 --- a/drivers/net/ethernet/smsc/smc91x.c +++ b/drivers/net/ethernet/smsc/smc91x.c @@ -1894,7 +1894,7 @@ static int smc_probe(struct net_device *dev, void __iomem *ioaddr, SMC_SELECT_BANK(lp, 1); val = SMC_GET_BASE(lp); val = ((val & 0x1F00) >> 3) << SMC_IO_SHIFT; - if (((unsigned int)ioaddr & (0x3e0 << SMC_IO_SHIFT)) != val) { + if (((unsigned long)ioaddr & (0x3e0 << SMC_IO_SHIFT)) != val) { netdev_warn(dev, "%s: IOADDR %p doesn't match configuration (%x).\n", CARDNAME, ioaddr, val); }
If used 64 bit compiler GCC warns that: drivers/net/ethernet/smsc/smc91x.c:1897:7: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] This patch fixes this by changing typecase from "unsigned int" to "unsigned long" CC: "David S. Miller" <davem@davemloft.net> CC: Jingoo Han <jg1.han@samsung.com> CC: netdev@vger.kernel.org Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> --- drivers/net/ethernet/smsc/smc91x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)