From patchwork Thu Jan 23 19:32:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Gortmaker X-Patchwork-Id: 3531051 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6E12DC02DC for ; Thu, 23 Jan 2014 19:34:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BF9DB201BC for ; Thu, 23 Jan 2014 19:33:55 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 667C620179 for ; Thu, 23 Jan 2014 19:33:54 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W6Q1g-0001Df-9U; Thu, 23 Jan 2014 19:33:20 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1W6Q1S-0002lX-DH; Thu, 23 Jan 2014 19:33:06 +0000 Received: from mail1.windriver.com ([147.11.146.13]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1W6Q1Q-0002js-EL for linux-arm-kernel@lists.infradead.org; Thu, 23 Jan 2014 19:33:05 +0000 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.5) with ESMTP id s0NJWWUY008191 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 23 Jan 2014 11:32:33 -0800 (PST) Received: from e6530.corp.ad.wrs.com (128.224.146.231) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.2.347.0; Thu, 23 Jan 2014 11:32:31 -0800 From: Paul Gortmaker To: Subject: [PATCH-next] drivers/clk: make max77686 driver bool for now Date: Thu, 23 Jan 2014 14:32:15 -0500 Message-ID: <1390505535-30229-1-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 1.8.5.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140123_143304_613769_A2B50260 X-CRM114-Status: UNSURE ( 7.04 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.5 (--) Cc: Mike Turquette , Tomasz Figa , SeongJae Park , Paul Gortmaker , Kyungmin Park , linux-next@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 3966c947f45911e093114371462687134d5e8d40 ("clk: max77686: Refactor driver data handling") added a call to __clk_get_hw() but this function is not exported (as __ is typically a private/internal thing). Hence this driver fails to build modular, and has been causing allmodconfig build breakage in arch outside of just ARM. Since the only defconfig that uses it sets it as =y, lets just make it non-modular for now. Mike says that changes are pending to export similar functionality in the future[1], so at that point in time, it can be returned to tristate if desired. [1] https://lkml.org/lkml/2014/1/20/21 Reported-by: SeongJae Park Cc: SeongJae Park Cc: Tomasz Figa Cc: Kyungmin Park Cc: Mike Turquette Signed-off-by: Paul Gortmaker diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index efb508a..009fb9b 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -40,7 +40,7 @@ config COMMON_CLK_VERSATILE - Versatile Express config COMMON_CLK_MAX77686 - tristate "Clock driver for Maxim 77686 MFD" + bool "Clock driver for Maxim 77686 MFD" depends on MFD_MAX77686 ---help--- This driver supports Maxim 77686 crystal oscillator clock.