From patchwork Mon Feb 3 22:34:33 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Soren Brinkmann X-Patchwork-Id: 3572221 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BF435C02DC for ; Mon, 3 Feb 2014 22:38:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F36FD2015E for ; Mon, 3 Feb 2014 22:38:03 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F39D20158 for ; Mon, 3 Feb 2014 22:38:03 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WAS7f-0008D6-7S; Mon, 03 Feb 2014 22:36:11 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WAS7I-0004tw-ME; Mon, 03 Feb 2014 22:35:48 +0000 Received: from mail-qc0-x233.google.com ([2607:f8b0:400d:c01::233]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WAS6m-0004n0-LP for linux-arm-kernel@lists.infradead.org; Mon, 03 Feb 2014 22:35:18 +0000 Received: by mail-qc0-f179.google.com with SMTP id e16so12142241qcx.38 for ; Mon, 03 Feb 2014 14:34:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=XSlyXD3UuJuuXx2G8MpvRQoUwk4Z+esTiv+bwEM+yQ4=; b=BENqyZiNjEVdG3iU58weArzpJTU+Oyn1tuwXbWTdwROxBG/qWWiknlIKUDw7nYHv70 pDNbenHwG3b6jWUOWV+PirdkYZbSsUipxFXRIPbIJeGouhgNZrt+Dpj7CZlC0/SVs7Os a5AiNRMA6yoHVlkF/O0vcP0Pybv2vp96abhrrK3zXj1em6sEiEBJrHh2VI/2+XFKjz87 7m9Xr3j0Zd/evFtXeClQUDezQJjIhPfdpSuUP873YOI+nOAvqkFrTPrxiGPylBDIFm6+ Mq+QZM6seFra3jYIyCwK0I05DkjuvZaNlfY7bK2qQXTlQ5D2FTAMe1KyNCS7AYvnkhLY IWOw== X-Received: by 10.140.89.52 with SMTP id u49mr57202691qgd.93.1391466894853; Mon, 03 Feb 2014 14:34:54 -0800 (PST) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id h12sm29294809qge.0.2014.02.03.14.34.53 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 03 Feb 2014 14:34:54 -0800 (PST) From: Soren Brinkmann To: Thomas Gleixner , Daniel Lezcano , Michal Simek Subject: [PATCH v3 3/7] clocksource/cadence_ttc: Call clockevents_update_freq() with IRQs enabled Date: Mon, 3 Feb 2014 14:34:33 -0800 Message-Id: <1391466877-28908-4-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1391466877-28908-1-git-send-email-soren.brinkmann@xilinx.com> References: <1391466877-28908-1-git-send-email-soren.brinkmann@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140203_173516_882710_5CC148E2 X-CRM114-Status: GOOD ( 10.01 ) X-Spam-Score: -1.9 (-) Cc: =?UTF-8?q?S=C3=B6ren=20Brinkmann?= , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The timer core takes care of serialization and IRQs. Hence the driver is no longer required to disable interrupts when calling clockevents_update_freq(). Signed-off-by: Soren Brinkmann --- drivers/clocksource/cadence_ttc_timer.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/clocksource/cadence_ttc_timer.c b/drivers/clocksource/cadence_ttc_timer.c index 63f176de0d02..f05b9fdc7425 100644 --- a/drivers/clocksource/cadence_ttc_timer.c +++ b/drivers/clocksource/cadence_ttc_timer.c @@ -321,25 +321,12 @@ static int ttc_rate_change_clockevent_cb(struct notifier_block *nb, switch (event) { case POST_RATE_CHANGE: - { - unsigned long flags; - - /* - * clockevents_update_freq should be called with IRQ disabled on - * the CPU the timer provides events for. The timer we use is - * common to both CPUs, not sure if we need to run on both - * cores. - */ - local_irq_save(flags); - clockevents_update_freq(&ttcce->ce, - ndata->new_rate / PRESCALE); - local_irq_restore(flags); - /* update cached frequency */ ttc->freq = ndata->new_rate; + clockevents_update_freq(&ttcce->ce, ndata->new_rate / PRESCALE); + /* fall through */ - } case PRE_RATE_CHANGE: case ABORT_RATE_CHANGE: default: