From patchwork Tue Mar 4 17:17:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Soren Brinkmann X-Patchwork-Id: 3764521 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 604DCBF40C for ; Tue, 4 Mar 2014 17:46:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A071220220 for ; Tue, 4 Mar 2014 17:46:24 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 89E8C20374 for ; Tue, 4 Mar 2014 17:46:23 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WKtQ0-0004ZD-H1; Tue, 04 Mar 2014 17:46:16 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WKtPx-00054w-7S; Tue, 04 Mar 2014 17:46:13 +0000 Received: from mail-ie0-x235.google.com ([2607:f8b0:4001:c03::235]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WKtPu-000543-4a for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2014 17:46:11 +0000 Received: by mail-ie0-f181.google.com with SMTP id tp5so4584277ieb.40 for ; Tue, 04 Mar 2014 09:45:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ygyAv8TTsMpmQ7nE0O/gl8x1x09cJjDNwCJARVgW9hY=; b=umPcMzHzbv2+vSYeB7fwnj7I74S837SIraFdJy/hmtrOqMx1iqPJghasjO8aP0Nq7w XqUeIqXfAhK+pA30RN2RfpgG7xfNddOSN/KECbeMhqN/WtY1Fweh4FFOOny7HIM45JeS hvZdTo/5Nk7sRYe/GMo7ld6bRVItUEiI1SE4bORqqdEC1YHawOL9P9EMi05HHVT4kZd6 A5qlcbslYVWWzKhBy47kStmlQuesGUm36izF9AgS/cu6jcc8iq3x4DhfuRtVOSSnBzPk yiTWti7BUp9v4QeF6eKTX7aoaaaf7YTqRkvqx/HJ30SfunDPZM4uKNpyqzNN4/7KHvwm T/ZQ== X-Received: by 10.50.28.116 with SMTP id a20mr4430569igh.5.1393953465606; Tue, 04 Mar 2014 09:17:45 -0800 (PST) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id dz8sm51767258igb.5.2014.03.04.09.17.44 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 04 Mar 2014 09:17:44 -0800 (PST) From: Soren Brinkmann To: Russell King , Greg Kroah-Hartman , Jiri Slaby Subject: [PATCH RFC 2/6] tty: xemacps: Print warning in clock notifier Date: Tue, 4 Mar 2014 09:17:25 -0800 Message-Id: <1393953449-28551-3-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 1.9.0.1.g4196000 In-Reply-To: <1393953449-28551-1-git-send-email-soren.brinkmann@xilinx.com> References: <1393953449-28551-1-git-send-email-soren.brinkmann@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140304_124610_212895_114A631F X-CRM114-Status: UNSURE ( 9.87 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 1.1 (+) Cc: Peter Crosthwaite , Kevin Hilman , Arnd Bergmann , Michal Simek , linux-kernel@vger.kernel.org, Soren Brinkmann , linux-serial@vger.kernel.org, Olof Johansson , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, KHOP_BIG_TO_CC,RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Print a warning if the clock notifier rejects a clock frequency change to facilitate debugging (see: http://thread.gmane.org/gmane.linux.ports.arm.kernel/304329/focus=304379) Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 8769b68534b1..4eee8031ae25 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -430,8 +430,10 @@ static int xuartps_clk_notifier_cb(struct notifier_block *nb, * frequency. */ if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud, - &bdiv, &cd, &div8)) + &bdiv, &cd, &div8)) { + dev_warn(port->dev, "clock rate change rejected\n"); return NOTIFY_BAD; + } spin_lock_irqsave(&xuartps->port->lock, flags);