From patchwork Fri Mar 7 17:45:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Zabel X-Patchwork-Id: 3793761 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 19255BF540 for ; Fri, 7 Mar 2014 17:46:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4F9F7202EC for ; Fri, 7 Mar 2014 17:46:03 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DDC3202EA for ; Fri, 7 Mar 2014 17:46:02 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WLyqG-00067i-AF; Fri, 07 Mar 2014 17:45:52 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WLyqD-0000gz-Gj; Fri, 07 Mar 2014 17:45:49 +0000 Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WLyqA-0000fX-Hq for linux-arm-kernel@lists.infradead.org; Fri, 07 Mar 2014 17:45:47 +0000 Received: from paszta.hi.pengutronix.de ([2001:6f8:1178:2:96de:80ff:fec2:9969]) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1WLyph-0002Lr-L7; Fri, 07 Mar 2014 18:45:17 +0100 Message-ID: <1394214315.16309.47.camel@paszta.hi.pengutronix.de> Subject: Re: [PATCH 1/2] imx-drm: imx-ldb: Add drm_panel support From: Philipp Zabel To: Russell King - ARM Linux Date: Fri, 07 Mar 2014 18:45:15 +0100 In-Reply-To: <20140307172243.GQ21483@n2100.arm.linux.org.uk> References: <1394114080-27223-1-git-send-email-p.zabel@pengutronix.de> <20140307172243.GQ21483@n2100.arm.linux.org.uk> X-Mailer: Evolution 3.8.5-2+b3 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:6f8:1178:2:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140307_124546_909541_DADE56EE X-CRM114-Status: GOOD ( 16.57 ) X-Spam-Score: -1.9 (-) Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, David Airlie , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, Christian Gmeiner , kernel@pengutronix.de, Grant Likely , Shawn Guo , Fabio Estevam , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Russell, Am Freitag, den 07.03.2014, 17:22 +0000 schrieb Russell King - ARM Linux: > On Thu, Mar 06, 2014 at 02:54:39PM +0100, Philipp Zabel wrote: > > This patch allows to optionally attach the lvds-channel to a panel > > supported by a drm_panel driver instead of supplying the modes via > > device tree. > > Hmm, I think something may be missing in this patch... you're introducing > calls into the drm panel code, but there's nothign which ensures that > code gets built alongside imx-ldb.c. With imx-ldb built as a module, > I get: > > ERROR: "drm_panel_attach" [drivers/staging/imx-drm/imx-ldb.ko] undefined! > ERROR: "of_drm_find_panel" [drivers/staging/imx-drm/imx-ldb.ko] undefined! Thanks for testing. Yes, this Kconfig change is missing from patch 1: I haven't noticed because I've enabled the parallel display driver, which does correctly select DRM_PANEL. regards Philipp diff --git a/drivers/staging/imx-drm/Kconfig b/drivers/staging/imx-drm/Kconfig index 82fb758..8e5b7e9 100644 --- a/drivers/staging/imx-drm/Kconfig +++ b/drivers/staging/imx-drm/Kconfig @@ -35,6 +35,7 @@ config DRM_IMX_TVE config DRM_IMX_LDB tristate "Support for LVDS displays" depends on DRM_IMX && MFD_SYSCON + select DRM_PANEL help Choose this to enable the internal LVDS Display Bridge (LDB) found on i.MX53 and i.MX6 processors.