| Message ID | 1394454858-3139-3-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> Add of_compatible strings for S5M8767 RTC, S5M8767 clock and S2MPS14 > clock MFD cells. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > drivers/mfd/sec-core.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index d163c66edebb..e8ac2e3c1f58 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -57,8 +57,10 @@ static const struct mfd_cell s5m8767_devs[] = { > .name = "s5m8767-pmic", > }, { > .name = "s5m-rtc", > + .of_compatible = "samsung,s5m8767-rtc", > }, { > .name = "s5m8767-clk", > + .of_compatible = "samsung,s5m8767-clk", > } > }; > > @@ -77,6 +79,7 @@ static const struct mfd_cell s2mps14_devs[] = { > .name = "s2mps14-rtc", > }, { > .name = "s2mps14-clk", > + .of_compatible = "samsung,s2mps14-clk", > } > }; Any reason for not applying compatible strings for the other devices?
On Mon, 2014-03-10 at 12:46 +0000, Lee Jones wrote: > > Add of_compatible strings for S5M8767 RTC, S5M8767 clock and S2MPS14 > > clock MFD cells. > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > > drivers/mfd/sec-core.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > > index d163c66edebb..e8ac2e3c1f58 100644 > > --- a/drivers/mfd/sec-core.c > > +++ b/drivers/mfd/sec-core.c > > @@ -57,8 +57,10 @@ static const struct mfd_cell s5m8767_devs[] = { > > .name = "s5m8767-pmic", > > }, { > > .name = "s5m-rtc", > > + .of_compatible = "samsung,s5m8767-rtc", > > }, { > > .name = "s5m8767-clk", > > + .of_compatible = "samsung,s5m8767-clk", > > } > > }; > > > > @@ -77,6 +79,7 @@ static const struct mfd_cell s2mps14_devs[] = { > > .name = "s2mps14-rtc", > > }, { > > .name = "s2mps14-clk", > > + .of_compatible = "samsung,s2mps14-clk", > > } > > }; > > Any reason for not applying compatible strings for the other devices? Partially yes because I do not want to add them for devices which I cannot test (s5m8761, s5m8763) but you're right that there are no obstacles for s2mps11, s5m8767 and s2mps14. I'll fix this in next version.
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index d163c66edebb..e8ac2e3c1f58 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-core.c @@ -57,8 +57,10 @@ static const struct mfd_cell s5m8767_devs[] = { .name = "s5m8767-pmic", }, { .name = "s5m-rtc", + .of_compatible = "samsung,s5m8767-rtc", }, { .name = "s5m8767-clk", + .of_compatible = "samsung,s5m8767-clk", } }; @@ -77,6 +79,7 @@ static const struct mfd_cell s2mps14_devs[] = { .name = "s2mps14-rtc", }, { .name = "s2mps14-clk", + .of_compatible = "samsung,s2mps14-clk", } };
Add of_compatible strings for S5M8767 RTC, S5M8767 clock and S2MPS14 clock MFD cells. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- drivers/mfd/sec-core.c | 3 +++ 1 file changed, 3 insertions(+)