| Message ID | 1394535304-10240-6-git-send-email-denis@eukrea.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 03/11/2014 01:55 PM, Denis Carikli wrote: > Signed-off-by: Denis Carikli <denis@eukrea.com> > --- > Changelog v1->v2: > - The usbphy nodes were made to look like the ones in imx53.dtsi > - The patch was rebased on top of the clock fixes commits. > --- > arch/arm/boot/dts/imx35.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi > index 474a73d..b943123 100644 > --- a/arch/arm/boot/dts/imx35.dtsi > +++ b/arch/arm/boot/dts/imx35.dtsi > @@ -298,6 +298,7 @@ > interrupts = <37>; > clocks = <&clks 73>; > fsl,usbmisc = <&usbmisc 0>; > + fsl,usbphy = <&usbphy0>; Why use Freescale specific prop here, when there's de-facto standard "usb-phy" already? > @@ -307,6 +308,7 @@ > interrupts = <35>; > clocks = <&clks 73>; > fsl,usbmisc = <&usbmisc 1>; > + fsl,usbphy = <&usbphy1>; Likewise. > @@ -355,4 +357,18 @@ > }; > }; > }; > + > + usbphy { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "simple-bus"; > + > + usbphy0: usbphy@0 { Why use the node name with the address part when you don't have "reg" prop? Moreover, I suggest "usb-phy" instead to be more in line with ePAPR [1] specified "ethernet-phy" device nodes. [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf WBR, Sergei
diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi index 474a73d..b943123 100644 --- a/arch/arm/boot/dts/imx35.dtsi +++ b/arch/arm/boot/dts/imx35.dtsi @@ -298,6 +298,7 @@ interrupts = <37>; clocks = <&clks 73>; fsl,usbmisc = <&usbmisc 0>; + fsl,usbphy = <&usbphy0>; status = "disabled"; }; @@ -307,6 +308,7 @@ interrupts = <35>; clocks = <&clks 73>; fsl,usbmisc = <&usbmisc 1>; + fsl,usbphy = <&usbphy1>; status = "disabled"; }; @@ -355,4 +357,18 @@ }; }; }; + + usbphy { + #address-cells = <1>; + #size-cells = <0>; + compatible = "simple-bus"; + + usbphy0: usbphy@0 { + compatible = "usb-nop-xceiv"; + }; + + usbphy1: usbphy@1 { + compatible = "usb-nop-xceiv"; + }; + }; };
Signed-off-by: Denis Carikli <denis@eukrea.com> --- Changelog v1->v2: - The usbphy nodes were made to look like the ones in imx53.dtsi - The patch was rebased on top of the clock fixes commits. --- arch/arm/boot/dts/imx35.dtsi | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)