diff mbox

arm: boot: dts: build keystone devicetree blob

Message ID 1394639330-1288-1-git-send-email-balbi@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Felipe Balbi March 12, 2014, 3:48 p.m. UTC
Currently, even when building keystone only
kernel builds, DTB won't get build because
we lack a Makefile rule to get it compiled.

This patch adds that rule so mainline kernel
users have a chance to use up-to-date DTB on
keystone 2 platforms.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---

note that I just tried this on top of linux-next
(commit 69d5cdda16b3c9767b82d80b07edb9bb056448e3)
and, even though dtb builds fine, I still couldn't
get keystone_defconfig uImage to boot fine.

It's probably my LOADADDR which is wrong.

Santosh, what's the LOADADDR I should be using
for keystone boots ?

 arch/arm/boot/dts/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Santosh Shilimkar March 12, 2014, 4:35 p.m. UTC | #1
On Wednesday 12 March 2014 11:48 PM, Felipe Balbi wrote:
> Currently, even when building keystone only
> kernel builds, DTB won't get build because
> we lack a Makefile rule to get it compiled.
> 
> This patch adds that rule so mainline kernel
> users have a chance to use up-to-date DTB on
> keystone 2 platforms.
> 
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
>
We have been building dtbs with explicit command
instead of dtbs since it was just one dtb so far
supported. Was planning to add the rule once more
boards get added. Now with Lamarr and Edision in
for next merge window, will do that post 3.15-rc1.

> note that I just tried this on top of linux-next
> (commit 69d5cdda16b3c9767b82d80b07edb9bb056448e3)
> and, even though dtb builds fine, I still couldn't
> get keystone_defconfig uImage to boot fine.
> 
> It's probably my LOADADDR which is wrong.
> 
> Santosh, what's the LOADADDR I should be using
> for keystone boots ?
>
LOADADDR is same 0x80008000. You might have missed
to configure the environment u-boot variable to
disable higher address space switch.
'setenv mem_lpae 0'. Also ensure to update
the boot loaders since the default ones comes with
EVM are long back outdated.

Regards,
Santosh
Felipe Balbi March 12, 2014, 4:53 p.m. UTC | #2
On Thu, Mar 13, 2014 at 12:35:41AM +0800, Santosh Shilimkar wrote:
> On Wednesday 12 March 2014 11:48 PM, Felipe Balbi wrote:
> > Currently, even when building keystone only
> > kernel builds, DTB won't get build because
> > we lack a Makefile rule to get it compiled.
> > 
> > This patch adds that rule so mainline kernel
> > users have a chance to use up-to-date DTB on
> > keystone 2 platforms.
> > 
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> >
> We have been building dtbs with explicit command
> instead of dtbs since it was just one dtb so far
> supported. Was planning to add the rule once more
> boards get added. Now with Lamarr and Edision in
> for next merge window, will do that post 3.15-rc1.
> 
> > note that I just tried this on top of linux-next
> > (commit 69d5cdda16b3c9767b82d80b07edb9bb056448e3)
> > and, even though dtb builds fine, I still couldn't
> > get keystone_defconfig uImage to boot fine.
> > 
> > It's probably my LOADADDR which is wrong.
> > 
> > Santosh, what's the LOADADDR I should be using
> > for keystone boots ?
> >
> LOADADDR is same 0x80008000. You might have missed

tried that, didn't help.

> to configure the environment u-boot variable to
> disable higher address space switch.
> 'setenv mem_lpae 0'. Also ensure to update

hmm, that might do it. Will try after upgrading u-boot to latest
release.
Santosh Shilimkar March 21, 2014, 2:40 p.m. UTC | #3
On Wednesday 12 March 2014 12:35 PM, Santosh Shilimkar wrote:
> On Wednesday 12 March 2014 11:48 PM, Felipe Balbi wrote:
>> Currently, even when building keystone only
>> kernel builds, DTB won't get build because
>> we lack a Makefile rule to get it compiled.
>>
>> This patch adds that rule so mainline kernel
>> users have a chance to use up-to-date DTB on
>> keystone 2 platforms.
>>
>> Signed-off-by: Felipe Balbi <balbi@ti.com>
>> ---
>>
> We have been building dtbs with explicit command
> instead of dtbs since it was just one dtb so far
> supported. Was planning to add the rule once more
> boards get added. Now with Lamarr and Edision in
> for next merge window, will do that post 3.15-rc1.
> 
Just to close the loop, I added a patch as part
of my 3.15 fixes which builds all keystone dt
blobs.

Regards,
Santosh
Felipe Balbi March 21, 2014, 2:43 p.m. UTC | #4
On Fri, Mar 21, 2014 at 10:40:00AM -0400, Santosh Shilimkar wrote:
> On Wednesday 12 March 2014 12:35 PM, Santosh Shilimkar wrote:
> > On Wednesday 12 March 2014 11:48 PM, Felipe Balbi wrote:
> >> Currently, even when building keystone only
> >> kernel builds, DTB won't get build because
> >> we lack a Makefile rule to get it compiled.
> >>
> >> This patch adds that rule so mainline kernel
> >> users have a chance to use up-to-date DTB on
> >> keystone 2 platforms.
> >>
> >> Signed-off-by: Felipe Balbi <balbi@ti.com>
> >> ---
> >>
> > We have been building dtbs with explicit command
> > instead of dtbs since it was just one dtb so far
> > supported. Was planning to add the rule once more
> > boards get added. Now with Lamarr and Edision in
> > for next merge window, will do that post 3.15-rc1.
> > 
> Just to close the loop, I added a patch as part
> of my 3.15 fixes which builds all keystone dt
> blobs.

cool, thanks
diff mbox

Patch

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index ae208a6..52c5231 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -82,6 +82,7 @@  dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
 	ecx-2000.dtb
 dtb-$(CONFIG_ARCH_INTEGRATOR) += integratorap.dtb \
 	integratorcp.dtb
+dtb-$(CONFIG_ARCH_KEYSTONE) += k2hk-evm.dtb
 kirkwood := \
 	kirkwood-b3.dtb \
 	kirkwood-cloudbox.dtb \