From patchwork Fri Mar 21 12:18:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 3874241 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 17B25BF540 for ; Fri, 21 Mar 2014 13:40:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4BBBF2027D for ; Fri, 21 Mar 2014 13:40:52 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CEBF2028D for ; Fri, 21 Mar 2014 13:40:51 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WQyQv-0001Jg-VC; Fri, 21 Mar 2014 12:20:23 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WQyQ4-0003dF-0M; Fri, 21 Mar 2014 12:19:28 +0000 Received: from mailout4.w1.samsung.com ([210.118.77.14]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WQyPW-0003ZJ-Gg for linux-arm-kernel@lists.infradead.org; Fri, 21 Mar 2014 12:18:56 +0000 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N2S00DI1CURMN50@mailout4.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Fri, 21 Mar 2014 12:18:27 +0000 (GMT) X-AuditID: cbfec7f5-b7fc96d000004885-c6-532c2e14a54c Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 8A.9A.18565.41E2C235; Fri, 21 Mar 2014 12:18:28 +0000 (GMT) Received: from AMDC1943.digital.local ([106.116.151.171]) by eusync4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N2S00F4DCUOI000@eusync4.samsung.com>; Fri, 21 Mar 2014 12:18:27 +0000 (GMT) From: Krzysztof Kozlowski To: Mike Turquette , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: [PATCH 1/2] clk: s2mps11: Fix possible NULL pointer dereference Date: Fri, 21 Mar 2014 13:18:17 +0100 Message-id: <1395404297-12133-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNJMWRmVeSWpSXmKPExsVy+t/xa7oiejrBBou/M1psnLGe1eL1C0OL s01v2C02Pb7GanF51xw2ixnn9zFZrD1yl93i6YSLbBYLNj5itFg/4zWLRfvfvWwO3B53ru1h 89i8pN6jb8sqRo/Pm+QCWKK4bFJSczLLUov07RK4Mu69PcxWcJCtomXdO9YGxr2sXYycHBIC JhIn3/VD2WISF+6tZ+ti5OIQEljKKHH+2BIop49JYuLDW4wgVWwCxhKbl0MkRASmMkpsXL+I CcRhFljLJLF/2RaWLkYODmEBD4nN99NAGlgEVCUmTV7ADmLzCrhL9P7YDVYiIaAgMWeSzQRG 7gWMDKsYRVNLkwuKk9JzjfSKE3OLS/PS9ZLzczcxQgLo6w7GpcesDjEKcDAq8fBWcGoHC7Em lhVX5h5ilOBgVhLhldPSCRbiTUmsrEotyo8vKs1JLT7EyMTBKdXAWP0vq3RdlUNN+96TsmGb uUxXf/i8oPLtlZSP7VpKhpzs1p/2eVmX7sy5GuNgXjv758ETd2t41arOifcvT2RcXfDlzU6r 8C0nqjy9fnl89v7zMVW2aM0nY5ebidkGK/3vLpp2t/mqiqivzlonr4X7OLaG72aRsV/nVvF4 0f7V/BZ7X31+oDfJRomlOCPRUIu5qDgRABVTA/H+AQAA X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140321_081854_664388_679EBB8E X-CRM114-Status: UNSURE ( 8.89 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -6.9 (------) Cc: Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Tomasz Figa , stable@vger.kernel.org, Kyungmin Park , Tushar Behera , Marek Szyprowski X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If parent device does not have of_node set the s2mps11_clk_parse_dt() returned NULL. This NULL was later passed to of_clk_add_provider() which dereferenced it in pr_debug() call. Signed-off-by: Krzysztof Kozlowski Cc: --- drivers/clk/clk-s2mps11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c index 00a3abe103a5..27c83e45eaed 100644 --- a/drivers/clk/clk-s2mps11.c +++ b/drivers/clk/clk-s2mps11.c @@ -130,7 +130,7 @@ static struct device_node *s2mps11_clk_parse_dt(struct platform_device *pdev) int i; if (!iodev->dev->of_node) - return NULL; + return ERR_PTR(-EINVAL); clk_np = of_find_node_by_name(iodev->dev->of_node, "clocks"); if (!clk_np) {