| Message ID | 1395627736-5338-3-git-send-email-Li.Xiubo@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 23 Mar 2014, Li.Xiubo at freescale.com wrote: > Signed-off-by: Xiubo Li <Li.Xiubo at freescale.com> > --- > arch/arm/boot/dts/vf610-twr.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/vf610-twr.dts > b/arch/arm/boot/dts/vf610-twr.dts index f3af8ea..3fabdb5 100644 --- > a/arch/arm/boot/dts/vf610-twr.dts +++ > b/arch/arm/boot/dts/vf610-twr.dts @@ -213,6 +213,17 @@ > >; > }; > > + pinctrl_pwm0: pwm0grp { + fsl,pins = < + VF610_PAD_PTB0__FTM0_CH0 Hi Xiubo, I think you added this for the tower audio board? Maybe the beeper? Are these lines needed? + VF610_PAD_PTB6__FTM0_CH6 0x1582 + VF610_PAD_PTB7__FTM0_CH7 0x1582 According to my tower schematics, PTB6 routes to the Primary B35/GPIO4, and B40/FTM0CH6/PWM4 and to the jumpers J23. PTB7 routes to B39/FTM0CH7/PWM5, EIRQ3/B55/B56, and jumper J24. I think that most people have some tower serial card which can also route these lines and/or they are sent to the OpenSDA chip which does a ttyACM (USB serial) on all Tower main boards. Did you just add all FTM channels 0-7 in the DTS? Or are each and every one mapped to a pin on the expansion/riser boards. Could we remove the two lines above and use, pinctrl_uart2: uart2grp { fsl,pins = < VF610_PAD_PTB6__UART2_TX 0x21a2 VF610_PAD_PTB7__UART2_RX 0x21a1 >; }; So that the PTB6/7 map to UART2? Or are these indeed a conflict with some audio board (or other)? I think it might be valuable to add the 'ttyLP2' to the vf610-twr. An MMC image could echo 'wrong serial port, set J23/24' for instance to tell people that the serial console was not connected properly (or something else). People may also wish to use a serial interface for other peripherals or as a 2nd debug port. Thanks, Bill Pringlemeir.
Hi Bill Pringlemeir, > > diff --git a/arch/arm/boot/dts/vf610-twr.dts > > b/arch/arm/boot/dts/vf610-twr.dts index f3af8ea..3fabdb5 100644 --- > > a/arch/arm/boot/dts/vf610-twr.dts +++ > > b/arch/arm/boot/dts/vf610-twr.dts @@ -213,6 +213,17 @@ > > >; > > }; > > > > + pinctrl_pwm0: pwm0grp { + fsl,pins = < + VF610_PAD_PTB0__FTM0_CH0 > > Hi Xiubo, > > I think you added this for the tower audio board? Maybe the beeper? For the PWM leds and beepers, for now only the ch0~ch3 are used here. > Are these lines needed? > > + VF610_PAD_PTB6__FTM0_CH6 0x1582 > + VF610_PAD_PTB7__FTM0_CH7 0x1582 > > According to my tower schematics, PTB6 routes to the Primary B35/GPIO4, > and B40/FTM0CH6/PWM4 and to the jumpers J23. PTB7 routes to > B39/FTM0CH7/PWM5, EIRQ3/B55/B56, and jumper J24. I think that most > people have some tower serial card which can also route these lines > and/or they are sent to the OpenSDA chip which does a ttyACM (USB > serial) on all Tower main boards. > > Did you just add all FTM channels 0-7 in the DTS? Or are each and every > one mapped to a pin on the expansion/riser boards. Could we remove the > two lines above and use, > > pinctrl_uart2: uart2grp { > fsl,pins = < > VF610_PAD_PTB6__UART2_TX 0x21a2 > VF610_PAD_PTB7__UART2_RX 0x21a1 > >; > }; > > So that the PTB6/7 map to UART2? Or are these indeed a conflict with > some audio board (or other)? There hasn't any confliction with audio board as far as I know. I think they can be removed. > I think it might be valuable to add the > 'ttyLP2' to the vf610-twr. An MMC image could echo 'wrong serial port, > set J23/24' for instance to tell people that the serial console was not > connected properly (or something else). People may also wish to use a > serial interface for other peripherals or as a 2nd debug port. > Hum, if so I think it's okay. @Shawn, Do you have any comments here ? Thanks, BRs Xiubo > Thanks, > Bill Pringlemeir.
On Wed, Jul 30, 2014 at 10:11:48AM +0800, Xiubo Li-B47053 wrote: > > I think it might be valuable to add the > > 'ttyLP2' to the vf610-twr. An MMC image could echo 'wrong serial port, > > set J23/24' for instance to tell people that the serial console was not > > connected properly (or something else). People may also wish to use a > > serial interface for other peripherals or as a 2nd debug port. > > > > Hum, if so I think it's okay. > > @Shawn, > > Do you have any comments here ? I'm fine with leaving the pins to serial interface, if it makes the most sense to most people, which sounds like the case from your discussion. Shawn
diff --git a/arch/arm/boot/dts/vf610-twr.dts b/arch/arm/boot/dts/vf610-twr.dts index f3af8ea..3fabdb5 100644 --- a/arch/arm/boot/dts/vf610-twr.dts +++ b/arch/arm/boot/dts/vf610-twr.dts @@ -213,6 +213,17 @@ >; }; + pinctrl_pwm0: pwm0grp { + fsl,pins = < + VF610_PAD_PTB0__FTM0_CH0 0x1582 + VF610_PAD_PTB1__FTM0_CH1 0x1582 + VF610_PAD_PTB2__FTM0_CH2 0x1582 + VF610_PAD_PTB3__FTM0_CH3 0x1582 + VF610_PAD_PTB6__FTM0_CH6 0x1582 + VF610_PAD_PTB7__FTM0_CH7 0x1582 + >; + }; + pinctrl_sai2: sai2grp { fsl,pins = < VF610_PAD_PTA16__SAI2_TX_BCLK 0x02ed
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> --- arch/arm/boot/dts/vf610-twr.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)