| Message ID | 1396425058-4012-3-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/02/2014 09:50 AM, Pankaj Dubey wrote: > This patch corrects file path mentioned in file comment message. > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- > arch/arm/mach-exynos/platsmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c > index 03e5e9f..d8d1555 100644 > --- a/arch/arm/mach-exynos/platsmp.c > +++ b/arch/arm/mach-exynos/platsmp.c > @@ -1,4 +1,4 @@ > -/* linux/arch/arm/mach-exynos4/platsmp.c > +/* linux/arch/arm/mach-exynos/platsmp.c > * > * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd. > * http://www.samsung.com > Shouldn't you just remove it entirely? I had the same file names in the whole microblaze tree and some months/years later this was just broken everywhere. That's why it is just easier to remove it entirely. Thanks, Michal
Hi Michal, On 04/02/2014 09:01 PM, Michal Simek wrote: > On 04/02/2014 09:50 AM, Pankaj Dubey wrote: >> This patch corrects file path mentioned in file comment message. >> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> >> --- >> arch/arm/mach-exynos/platsmp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c >> index 03e5e9f..d8d1555 100644 >> --- a/arch/arm/mach-exynos/platsmp.c >> +++ b/arch/arm/mach-exynos/platsmp.c >> @@ -1,4 +1,4 @@ >> -/* linux/arch/arm/mach-exynos4/platsmp.c >> +/* linux/arch/arm/mach-exynos/platsmp.c >> * >> * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd. >> * http://www.samsung.com >> > Shouldn't you just remove it entirely? > I had the same file names in the whole microblaze tree > and some months/years later this was just broken everywhere. > That's why it is just easier to remove it entirely. Thanks for review and suggestion. Removing of file name makes more sense to me also. Will take care of this in some other files also under "mach-exynos" in next version of patch. > > Thanks, > Michal > >
Pankaj Dubey wrote: > > Hi Michal, > > On 04/02/2014 09:01 PM, Michal Simek wrote: > > On 04/02/2014 09:50 AM, Pankaj Dubey wrote: > >> This patch corrects file path mentioned in file comment message. > >> > >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > >> --- > >> arch/arm/mach-exynos/platsmp.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach- > exynos/platsmp.c > >> index 03e5e9f..d8d1555 100644 > >> --- a/arch/arm/mach-exynos/platsmp.c > >> +++ b/arch/arm/mach-exynos/platsmp.c > >> @@ -1,4 +1,4 @@ > >> -/* linux/arch/arm/mach-exynos4/platsmp.c > >> +/* linux/arch/arm/mach-exynos/platsmp.c > >> * > >> * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd. > >> * http://www.samsung.com > >> > > Shouldn't you just remove it entirely? > > I had the same file names in the whole microblaze tree > > and some months/years later this was just broken everywhere. > > That's why it is just easier to remove it entirely. > > Thanks for review and suggestion. > Removing of file name makes more sense to me also. > Will take care of this in some other files also under "mach-exynos" > in next version of patch. > No, basically don't need it. And Sachin/Tushar have posted it before, I didn't agree at that time though. - Kukjin
diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c index 03e5e9f..d8d1555 100644 --- a/arch/arm/mach-exynos/platsmp.c +++ b/arch/arm/mach-exynos/platsmp.c @@ -1,4 +1,4 @@ -/* linux/arch/arm/mach-exynos4/platsmp.c +/* linux/arch/arm/mach-exynos/platsmp.c * * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd. * http://www.samsung.com
This patch corrects file path mentioned in file comment message. Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> --- arch/arm/mach-exynos/platsmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)