From patchwork Fri Apr 4 09:22:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Kurtz X-Patchwork-Id: 3937471 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 077899F357 for ; Fri, 4 Apr 2014 09:23:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 34B8B20381 for ; Fri, 4 Apr 2014 09:23:43 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F0A020374 for ; Fri, 4 Apr 2014 09:23:42 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WW0L1-00062i-J9; Fri, 04 Apr 2014 09:23:03 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WW0Ku-0003T3-Uo; Fri, 04 Apr 2014 09:22:56 +0000 Received: from mail-pd0-x232.google.com ([2607:f8b0:400e:c02::232]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WW0Kk-0003Pf-64 for linux-arm-kernel@lists.infradead.org; Fri, 04 Apr 2014 09:22:48 +0000 Received: by mail-pd0-f178.google.com with SMTP id x10so3078768pdj.37 for ; Fri, 04 Apr 2014 02:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qzpe9ERsKBxX3T5/cMsV831/jEzz9fKpDpq8eiKzaD0=; b=KWc5cdpzBFOOHfAe9pMF9+ORG109r1qQZTUza/CCPLC2EoQwrSYLP2m0c6aA5g8qTS pKDYfAwChXU56I5mbuLJ6xF8OpG7EXli5pDNZCfPlAMCibWlST6OvTAK+0H4u8X4L2Yn jgbpPMO697hti7pHcahbi/SF0v+hOM1iAyoTw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qzpe9ERsKBxX3T5/cMsV831/jEzz9fKpDpq8eiKzaD0=; b=MW+9RydfXh2/SLIADetb+PjW/yfOMaoq1DsU6r1bZyTkLBknBrpnvxSP7LyulAoWhX PUlsYvdjz686DeR5y7b8cui8aW7MOtNqJUpJqXQesEp+Ox371P5PF3wKEd3P9Baj/STD SpQsvkhmD03AvetBfO9y5q+YdovjU+feVqbx3zWDSkbWxOv7ahMlPIfMlLuxcDYFEUZy Zc8FVmLlTl1/yiNUHYzakUWN/idcbe1dExoPsOWmNChv3dzCMwS5yCKnc2/0gjqLcPVv wJDFKQQoWq8ws926d0/ZSs1V2I5CAr66wVVV689uEun4ty8xrgbOFOS8pINHsDJNhDhF tLog== X-Gm-Message-State: ALoCoQlAuqu0QHWhUp7xw+1wfFGHNrqyqEidRsyZf94/u2Tj6NxF7UmM44zJuiEXphu5tR6N6Pnh X-Received: by 10.66.163.164 with SMTP id yj4mr13859150pab.91.1396603339716; Fri, 04 Apr 2014 02:22:19 -0700 (PDT) Received: from djkurtzt530-glaptop.hitronhub.home (123-193-35-201.dynamic.kbronet.com.tw. [123.193.35.201]) by mx.google.com with ESMTPSA id kc9sm16484867pbc.25.2014.04.04.02.22.15 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 04 Apr 2014 02:22:18 -0700 (PDT) From: Daniel Kurtz To: Inki Dae , dri-devel@lists.freedesktop.org Subject: [PATCH 2/2] drm/exynos/fbdev: don't set mode_config.fb_base Date: Fri, 4 Apr 2014 17:22:02 +0800 Message-Id: <1396603322-13585-2-git-send-email-djkurtz@chromium.org> X-Mailer: git-send-email 1.9.1.423.g4596e3a In-Reply-To: <1396603322-13585-1-git-send-email-djkurtz@chromium.org> References: <1396603322-13585-1-git-send-email-djkurtz@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140404_052246_364249_9920B00B X-CRM114-Status: GOOD ( 11.36 ) X-Spam-Score: -2.0 (--) Cc: Kukjin Kim , Joonyoung Shim , David Airlie , Seung-Woo Kim , linux-kernel@vger.kernel.org, Daniel Kurtz , Kyungmin Park , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP AFAICT, the fb_base of a drm_device's mode_config is never used. It isn't accessed by core drm, it isn't used by fbmem, and it isn't exposed to user space. Furthermore, it is probably supposed to be a physical address, not the dma address mapped to the display controller, so this is just wrong. Signed-off-by: Daniel Kurtz --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index 2dcc589..3270a36 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -121,7 +121,6 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, offset = fbi->var.xoffset * (fb->bits_per_pixel >> 3); offset += fbi->var.yoffset * fb->pitches[0]; - dev->mode_config.fb_base = (resource_size_t)buffer->dma_addr; fbi->screen_base = buffer->kvaddr + offset; fbi->screen_size = size;