From patchwork Sat Apr 5 00:23:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Soren Brinkmann X-Patchwork-Id: 3941601 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 36FBA9F1EE for ; Sat, 5 Apr 2014 00:25:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6246820381 for ; Sat, 5 Apr 2014 00:25:56 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 733CE20225 for ; Sat, 5 Apr 2014 00:25:55 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WWEQ2-0006on-P6; Sat, 05 Apr 2014 00:25:11 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WWEPr-0002uh-QT; Sat, 05 Apr 2014 00:24:59 +0000 Received: from mail-qc0-x231.google.com ([2607:f8b0:400d:c01::231]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WWEPN-0002n3-Ag for linux-arm-kernel@lists.infradead.org; Sat, 05 Apr 2014 00:24:40 +0000 Received: by mail-qc0-f177.google.com with SMTP id w7so4222923qcr.36 for ; Fri, 04 Apr 2014 17:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=/YM10S/WDu70gr7PjMmuuW6hpMm8GXtSE2soyDFTx18=; b=vpLnr+x1fBxlvfngmZVcG2kWqOtduOWT/LDEyOQthjvLBbza5JrO1K17lU0rOJA+gW F2n2tl6U2g5dUwBR6cJrmP/46zhgesrS/Uz1iiqbfbVP9TKmmoE7/TtyqpXpmW4pJBSv 5wnAFJ3wZf3EGePb7kPpXJTsWvSk7JVrPejbLhz/OM9jU81ubpa6eecvzeAinMAPat0T KGbzmAZmMrtlDVnCMdId4lEDC2mnkM6+5J+hTWRVLz+mGlsmK8Dcwi2oJv8H7oD32VS5 zfEHQV9GF36Ihfhv/fScDqWWLVR2t2o2+Nv2Whidbw4ZHsebXDprlhBL2dUQBdmM92K3 f7fg== X-Received: by 10.140.80.209 with SMTP id c75mr16923056qgd.79.1396657447917; Fri, 04 Apr 2014 17:24:07 -0700 (PDT) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id c5sm13158434qge.21.2014.04.04.17.24.06 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 04 Apr 2014 17:24:06 -0700 (PDT) From: Soren Brinkmann To: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Russell King , Michal Simek , Greg Kroah-Hartman , Jiri Slaby , Grant Likely Subject: [RESEND PATCH v3 4/9] tty: xuartps: Print warning in clock notifier Date: Fri, 4 Apr 2014 17:23:40 -0700 Message-Id: <1396657425-31029-4-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 1.9.1.1.gbb9f595 In-Reply-To: <1396657425-31029-1-git-send-email-soren.brinkmann@xilinx.com> References: <1396657425-31029-1-git-send-email-soren.brinkmann@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140404_202429_672721_15C03205 X-CRM114-Status: UNSURE ( 9.55 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) Cc: One Thousand Gnomes , Peter Crosthwaite , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Soren Brinkmann X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Print a warning if the clock notifier rejects a clock frequency change to facilitate debugging (see: http://thread.gmane.org/gmane.linux.ports.arm.kernel/304329/focus=304379) Signed-off-by: Soren Brinkmann Tested-by: Michal Simek --- Changes in v3: None Changes in v2: None drivers/tty/serial/xilinx_uartps.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 787a12064fa0..814391038abb 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -429,8 +429,10 @@ static int xuartps_clk_notifier_cb(struct notifier_block *nb, * frequency. */ if (!xuartps_calc_baud_divs(ndata->new_rate, xuartps->baud, - &bdiv, &cd, &div8)) + &bdiv, &cd, &div8)) { + dev_warn(port->dev, "clock rate change rejected\n"); return NOTIFY_BAD; + } spin_lock_irqsave(&xuartps->port->lock, flags);