| Message ID | 1396884272-8307-1-git-send-email-grygorii.strashko@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 07 April 2014 11:24 AM, Grygorii Strashko wrote: > I2C nodes should always have #address-cells and #size-cells defined. > Hence, ensure that all i2cX nodes have #address-cells and #size-cells > properties defined. > > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- Right. BTW, have you seen some issue without this patch ? Just curious what prompted you to create this patch and whether it needs to be sent as fix during rc's. Regards, Santosh
On 04/07/2014 08:50 PM, Santosh Shilimkar wrote: > On Monday 07 April 2014 11:24 AM, Grygorii Strashko wrote: >> I2C nodes should always have #address-cells and #size-cells defined. >> Hence, ensure that all i2cX nodes have #address-cells and #size-cells >> properties defined. >> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> >> --- > Right. BTW, have you seen some issue without this patch ? > Just curious what prompted you to create this patch and whether > it needs to be sent as fix during rc's. I think, it can wait for next. Without this patch warnings will be produced in case of adding child node to the bus in DT: Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc/i2c@2530800/pca@20 Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc/i2c@2530800/pca@20 I'll updated patch description and resend. Regards, -grygorii
diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi index 90823eb..f730392 100644 --- a/arch/arm/boot/dts/keystone.dtsi +++ b/arch/arm/boot/dts/keystone.dtsi @@ -115,6 +115,8 @@ clock-frequency = <100000>; clocks = <&clki2c>; interrupts = <GIC_SPI 286 IRQ_TYPE_EDGE_RISING>; + #address-cells = <1>; + #size-cells = <0>; }; i2c2: i2c@2530800 { @@ -123,6 +125,8 @@ clock-frequency = <100000>; clocks = <&clki2c>; interrupts = <GIC_SPI 289 IRQ_TYPE_EDGE_RISING>; + #address-cells = <1>; + #size-cells = <0>; }; spi0: spi@21000400 {
I2C nodes should always have #address-cells and #size-cells defined. Hence, ensure that all i2cX nodes have #address-cells and #size-cells properties defined. Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- arch/arm/boot/dts/keystone.dtsi | 4 ++++ 1 file changed, 4 insertions(+)