From patchwork Tue Apr 8 21:43:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 3951221 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5B83CBFF02 for ; Tue, 8 Apr 2014 21:47:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9E5E2201F4 for ; Tue, 8 Apr 2014 21:47:25 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B275820155 for ; Tue, 8 Apr 2014 21:47:24 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WXdp5-0007Qz-G5; Tue, 08 Apr 2014 21:44:52 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WXdoj-0000e6-9U; Tue, 08 Apr 2014 21:44:29 +0000 Received: from mail-ie0-f177.google.com ([209.85.223.177]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WXdnt-0000XO-UM for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2014 21:43:40 +0000 Received: by mail-ie0-f177.google.com with SMTP id rl12so1532339iec.8 for ; Tue, 08 Apr 2014 14:43:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7Hg4xMCmPA5YKbzFm9GjwCV81ZtUTB+xQaXEmxERZdI=; b=hXMb06lYg9mX4/k8Bzs8Yps8GFnBhUMi6RzaJ11zeRt7v+ijnhjQR9+nmTbHLgo2qC JSBqsBeA3BzR93H6ufv+acewPd8csA5D/amJDNjC/RZQOHV/UPDxinpy5BFgoXvze9FR vKs52qQA7+r2JOn8E83PG9O/BqF/KasJjbImjJBLnozK3jy4NFmwpAk17LP1bW1jejCA yixSkbd/lxAUJE1GGMvU76biDZEHON/PE/jkgNKgSSw0y/bPRYeXK5IWC6ewKUS4gvgy wyu7BVnGa+yuCj+nmAJv+tU36eekBr0432BbR3df6kQF5mCuVaDWaayKtSJIaU9l5/zq OaFw== X-Gm-Message-State: ALoCoQlnxjapXbJmT9RI9Qufu2/SboNpKNKNUuCtPG0GnY4sbDfTvVI5/RVKBHrsfPYJlLwI0ruf X-Received: by 10.50.66.227 with SMTP id i3mr6770998igt.19.1396993392772; Tue, 08 Apr 2014 14:43:12 -0700 (PDT) Received: from localhost.localdomain (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPSA id j9sm6126805igu.10.2014.04.08.14.43.11 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 08 Apr 2014 14:43:12 -0700 (PDT) From: Alex Elder To: mturquette@linaro.org, mporter@linaro.org, bcm@fixthebug.org Subject: [PATCH v4 1/7] clk: bcm281xx: warn if ccu_wait_bit() fails Date: Tue, 8 Apr 2014 16:43:39 -0500 Message-Id: <1396993425-30683-2-git-send-email-elder@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1396993425-30683-1-git-send-email-elder@linaro.org> References: <1396993425-30683-1-git-send-email-elder@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140408_174338_043260_3B2ED296 X-CRM114-Status: UNSURE ( 9.42 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Don't let a failure of ccu_wait_bit() go unnoticed. Signed-off-by: Alex Elder --- drivers/clk/bcm/clk-kona.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c index db11a87..4b4e35a 100644 --- a/drivers/clk/bcm/clk-kona.c +++ b/drivers/clk/bcm/clk-kona.c @@ -207,6 +207,9 @@ __ccu_wait_bit(struct ccu_data *ccu, u32 reg_offset, u32 bit, bool want) return true; udelay(1); } + pr_warn("%s: %s/0x%04x bit %u was never %s\n", __func__, + ccu->name, reg_offset, bit, want ? "set" : "clear"); + return false; }