| Message ID | 1397366353-29395-2-git-send-email-shc_work@mail.ru (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Apr 13, 2014 at 09:19:05AM +0400, Alexander Shiyan wrote: > This patch moves GPIOs definitions for "fixed-clock" into a separate > pingroup. > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > --- > arch/arm/boot/dts/imx51-babbage.dts | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts > index eddb62d..651a8c8 100644 > --- a/arch/arm/boot/dts/imx51-babbage.dts > +++ b/arch/arm/boot/dts/imx51-babbage.dts > @@ -125,6 +125,8 @@ > > clk_26M: codec_clock { > compatible = "fixed-clock"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_clkcodec>; Are you sure that pinctrl-* settings work for a fixed-clock? My impression is that it only works for the device that Linux creates struct device and probes for. Shawn > reg=<0>; > #clock-cells = <0>; > clock-frequency = <26000000>; > @@ -337,7 +339,6 @@ > MX51_PAD_GPIO1_6__GPIO1_6 0x100 > MX51_PAD_CSPI1_SS0__GPIO4_24 0x85 > MX51_PAD_CSPI1_SS1__GPIO4_25 0x85 > - MX51_PAD_CSPI1_RDY__GPIO4_26 0x80000000 > >; > }; > > @@ -350,6 +351,12 @@ > >; > }; > > + pinctrl_clkcodec: clkcodecgrp { > + fsl,pins = < > + MX51_PAD_CSPI1_RDY__GPIO4_26 0x80000000 > + >; > + }; > + > pinctrl_ecspi1: ecspi1grp { > fsl,pins = < > MX51_PAD_CSPI1_MISO__ECSPI1_MISO 0x185 > -- > 1.8.3.2 > > >
Sun, 13 Apr 2014 16:18:07 +0800 ?? Shawn Guo <shawn.guo@freescale.com>: > On Sun, Apr 13, 2014 at 09:19:05AM +0400, Alexander Shiyan wrote: > > This patch moves GPIOs definitions for "fixed-clock" into a separate > > pingroup. > > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > > --- > > arch/arm/boot/dts/imx51-babbage.dts | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts > > index eddb62d..651a8c8 100644 > > --- a/arch/arm/boot/dts/imx51-babbage.dts > > +++ b/arch/arm/boot/dts/imx51-babbage.dts > > @@ -125,6 +125,8 @@ > > > > clk_26M: codec_clock { > > compatible = "fixed-clock"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_clkcodec>; > > Are you sure that pinctrl-* settings work for a fixed-clock? My > impression is that it only works for the device that Linux creates > struct device and probes for. Hmm, you are right. In this case, it would be logical to move the pinctrl definition for this GPIO to the codec node. ---
diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts index eddb62d..651a8c8 100644 --- a/arch/arm/boot/dts/imx51-babbage.dts +++ b/arch/arm/boot/dts/imx51-babbage.dts @@ -125,6 +125,8 @@ clk_26M: codec_clock { compatible = "fixed-clock"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_clkcodec>; reg=<0>; #clock-cells = <0>; clock-frequency = <26000000>; @@ -337,7 +339,6 @@ MX51_PAD_GPIO1_6__GPIO1_6 0x100 MX51_PAD_CSPI1_SS0__GPIO4_24 0x85 MX51_PAD_CSPI1_SS1__GPIO4_25 0x85 - MX51_PAD_CSPI1_RDY__GPIO4_26 0x80000000 >; }; @@ -350,6 +351,12 @@ >; }; + pinctrl_clkcodec: clkcodecgrp { + fsl,pins = < + MX51_PAD_CSPI1_RDY__GPIO4_26 0x80000000 + >; + }; + pinctrl_ecspi1: ecspi1grp { fsl,pins = < MX51_PAD_CSPI1_MISO__ECSPI1_MISO 0x185
This patch moves GPIOs definitions for "fixed-clock" into a separate pingroup. Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- arch/arm/boot/dts/imx51-babbage.dts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)