| Message ID | 1397479700-15864-2-git-send-email-chanho61.park@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Chanho, On 14.04.2014 14:48, Chanho Park wrote: > This patch adds a PMU(Power Management Unit) syscon node. This > should be required for USB Phy syscon regmap I/F. > > Cc: Tomasz Figa <t.figa@samsung.com> > Cc: Kamil Debski <k.debski@samsung.com> > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > --- > arch/arm/boot/dts/exynos4.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index 2f8bcd0..e565b86 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -110,6 +110,11 @@ > reg = <0x10010000 0x400>; > }; > > + pmu_reg: syscon@10020000 { > + compatible = "samsung,exynos4-pmureg", "syscon"; This compatible string doesn't seem to be defined in [1], please add it there, [1] Documentation/devicetree/bindings/arm/samsung/pmu.txt Otherwise looks good, so after fixing that you may add my Reviewed-by: Tomasz Figa <t.figa@samsung.com> Best regards, Tomasz
Hi, On Thu, Apr 24, 2014 at 9:37 PM, Tomasz Figa <t.figa@samsung.com> wrote: > Hi Chanho, > > > On 14.04.2014 14:48, Chanho Park wrote: >> >> This patch adds a PMU(Power Management Unit) syscon node. This >> should be required for USB Phy syscon regmap I/F. >> >> Cc: Tomasz Figa <t.figa@samsung.com> >> Cc: Kamil Debski <k.debski@samsung.com> >> Signed-off-by: Chanho Park <chanho61.park@samsung.com> >> --- >> arch/arm/boot/dts/exynos4.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos4.dtsi >> b/arch/arm/boot/dts/exynos4.dtsi >> index 2f8bcd0..e565b86 100644 >> --- a/arch/arm/boot/dts/exynos4.dtsi >> +++ b/arch/arm/boot/dts/exynos4.dtsi >> @@ -110,6 +110,11 @@ >> reg = <0x10010000 0x400>; >> }; >> >> + pmu_reg: syscon@10020000 { >> + compatible = "samsung,exynos4-pmureg", "syscon"; > Assume a case where exynos PMU is made as platform driver [1] and we need use the compatible "samsung,exynos4-pmureg" in the driver. But since syscon driver uses compatible "syscon" and once the syscon driver is probed, the exynos PMU platform driver [1] will NEVER be probed. So my question is, can we have 2 compatible strings for a DT node, and both the compatible strings are used for probing purpose? Recently I faced this issue on exynos5250, where i was testing PMU driver [1] and I noticed that PMU driver [1] was NEVER probed, if I enable syscon driver in menuconfig. [1] http://www.spinics.net/lists/linux-samsung-soc/msg28038.html > > This compatible string doesn't seem to be defined in [1], please add it > there, > > [1] Documentation/devicetree/bindings/arm/samsung/pmu.txt > > Otherwise looks good, so after fixing that you may add my > > Reviewed-by: Tomasz Figa <t.figa@samsung.com> > > Best regards, > Tomasz > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Vikas, On 25.04.2014 10:05, Vikas Sajjan wrote: > Hi, > > > On Thu, Apr 24, 2014 at 9:37 PM, Tomasz Figa <t.figa@samsung.com> wrote: >> Hi Chanho, >> >> >> On 14.04.2014 14:48, Chanho Park wrote: >>> >>> This patch adds a PMU(Power Management Unit) syscon node. This >>> should be required for USB Phy syscon regmap I/F. >>> >>> Cc: Tomasz Figa <t.figa@samsung.com> >>> Cc: Kamil Debski <k.debski@samsung.com> >>> Signed-off-by: Chanho Park <chanho61.park@samsung.com> >>> --- >>> arch/arm/boot/dts/exynos4.dtsi | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/exynos4.dtsi >>> b/arch/arm/boot/dts/exynos4.dtsi >>> index 2f8bcd0..e565b86 100644 >>> --- a/arch/arm/boot/dts/exynos4.dtsi >>> +++ b/arch/arm/boot/dts/exynos4.dtsi >>> @@ -110,6 +110,11 @@ >>> reg = <0x10010000 0x400>; >>> }; >>> >>> + pmu_reg: syscon@10020000 { >>> + compatible = "samsung,exynos4-pmureg", "syscon"; >> > > Assume a case where exynos PMU is made as platform driver [1] and we > need use the compatible "samsung,exynos4-pmureg" in the driver. > But since syscon driver uses compatible "syscon" and once the syscon > driver is probed, the exynos PMU platform driver [1] will NEVER be > probed. > So my question is, can we have 2 compatible strings for a DT node, and > both the compatible strings are used for probing purpose? > Recently I faced this issue on exynos5250, where i was testing PMU > driver [1] and I noticed that PMU driver [1] was NEVER probed, if I > enable syscon driver in menuconfig. No, it is not possible to bind two drivers with different compatible strings to the same node. Basically this is because only one platform driver can be bound to particular platform device. The rule is that the most specific compatible string (e.g. the first from the left) that matches should be used, but I'm not sure if this is implemented this way in Linux kernel, especially considering that a platform driver usually probes when it is being registered. So we might have a race here, which you can work around by making sure that your PMU driver is always registered first (e.g. by lowering its initcall level). Best regards, Tomasz
Hi Tomasz, On Sat, Apr 26, 2014 at 8:52 AM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Vikas, > > > On 25.04.2014 10:05, Vikas Sajjan wrote: >> >> Hi, >> >> >> On Thu, Apr 24, 2014 at 9:37 PM, Tomasz Figa <t.figa@samsung.com> wrote: >>> >>> Hi Chanho, >>> >>> >>> On 14.04.2014 14:48, Chanho Park wrote: >>>> >>>> >>>> This patch adds a PMU(Power Management Unit) syscon node. This >>>> should be required for USB Phy syscon regmap I/F. >>>> >>>> Cc: Tomasz Figa <t.figa@samsung.com> >>>> Cc: Kamil Debski <k.debski@samsung.com> >>>> Signed-off-by: Chanho Park <chanho61.park@samsung.com> >>>> --- >>>> arch/arm/boot/dts/exynos4.dtsi | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos4.dtsi >>>> b/arch/arm/boot/dts/exynos4.dtsi >>>> index 2f8bcd0..e565b86 100644 >>>> --- a/arch/arm/boot/dts/exynos4.dtsi >>>> +++ b/arch/arm/boot/dts/exynos4.dtsi >>>> @@ -110,6 +110,11 @@ >>>> reg = <0x10010000 0x400>; >>>> }; >>>> >>>> + pmu_reg: syscon@10020000 { >>>> + compatible = "samsung,exynos4-pmureg", "syscon"; >>> >>> >> >> Assume a case where exynos PMU is made as platform driver [1] and we >> need use the compatible "samsung,exynos4-pmureg" in the driver. >> But since syscon driver uses compatible "syscon" and once the syscon >> driver is probed, the exynos PMU platform driver [1] will NEVER be >> probed. >> So my question is, can we have 2 compatible strings for a DT node, and >> both the compatible strings are used for probing purpose? >> Recently I faced this issue on exynos5250, where i was testing PMU >> driver [1] and I noticed that PMU driver [1] was NEVER probed, if I >> enable syscon driver in menuconfig. > > > No, it is not possible to bind two drivers with different compatible strings > to the same node. Basically this is because only one platform driver can be > bound to particular platform device. > Yes, correct. > The rule is that the most specific compatible string (e.g. the first from > the left) that matches should be used, but I'm not sure if this is > implemented this way in Linux kernel, especially considering that a platform > driver usually probes when it is being registered. So we might have a race > here, which you can work around by making sure that your PMU driver is > always registered first (e.g. by lowering its initcall level). > I don't see it's using first compatible string from the left. I can see whichever driver registers platform driver first, it's probe is getting called. As in this particular case, PMU has two compatibility string as "samsung, exynosxxx-pmu", "syscon". But since "syscon" driver registers it's platform driver in postcore_initcall where as PMU platform driver [1], was registering as arch_initcall, only "syscon" probe got called. In my V2 patch for converting PMU as driver form, I dropped idea of converting into platform driver, because we can't remove "syscon" from binding as many other driver wants to access PMU register via regmap handle. By lowering it's initcall level may be I can make PMU probe gets called but then how other drivers will be able to access PMU regmap handles? > Best regards, > Tomasz > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 2f8bcd0..e565b86 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -110,6 +110,11 @@ reg = <0x10010000 0x400>; }; + pmu_reg: syscon@10020000 { + compatible = "samsung,exynos4-pmureg", "syscon"; + reg = <0x10020000 0x4000>; + }; + dsi_0: dsi@11C80000 { compatible = "samsung,exynos4210-mipi-dsi"; reg = <0x11C80000 0x10000>;
This patch adds a PMU(Power Management Unit) syscon node. This should be required for USB Phy syscon regmap I/F. Cc: Tomasz Figa <t.figa@samsung.com> Cc: Kamil Debski <k.debski@samsung.com> Signed-off-by: Chanho Park <chanho61.park@samsung.com> --- arch/arm/boot/dts/exynos4.dtsi | 5 +++++ 1 file changed, 5 insertions(+)