| Message ID | 1397479700-15864-4-git-send-email-chanho61.park@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Chanho, On 14.04.2014 14:48, Chanho Park wrote: > This patch adds a hsotg node for exynos4 USB2.0 device controller. > > Cc: Tomasz Figa <t.figa@samsung.com> > Cc: Kamil Debski <k.debski@samsung.com> > Cc: Marek Szyprowski <m.szyprowski@samsung.com> > Signed-off-by: Chanho Park <chanho61.park@samsung.com> > --- > arch/arm/boot/dts/exynos4.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi > index 0e32d7f..e541ecb 100644 > --- a/arch/arm/boot/dts/exynos4.dtsi > +++ b/arch/arm/boot/dts/exynos4.dtsi > @@ -288,6 +288,17 @@ > #phy-cells = <1>; > }; > > + hsotg@12480000 { > + compatible = "samsung,s3c6400-hsotg"; > + reg = <0x12480000 0x20000>; > + interrupts = <0 71 0>; > + clocks = <&clock 305>; Please use clock macros. > + clock-names = "otg"; > + phys = <&exynos_usbphy 0>; > + phy-names = "device"; This is not the correct phy name for this binding. According to what the driver uses and the example in ...bindings/usb/dwc2.txt "usb2-phy" should be used. Best regards, Tomasz
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index 0e32d7f..e541ecb 100644 --- a/arch/arm/boot/dts/exynos4.dtsi +++ b/arch/arm/boot/dts/exynos4.dtsi @@ -288,6 +288,17 @@ #phy-cells = <1>; }; + hsotg@12480000 { + compatible = "samsung,s3c6400-hsotg"; + reg = <0x12480000 0x20000>; + interrupts = <0 71 0>; + clocks = <&clock 305>; + clock-names = "otg"; + phys = <&exynos_usbphy 0>; + phy-names = "device"; + status = "disabled"; + }; + ehci@12580000 { compatible = "samsung,exynos4210-ehci"; reg = <0x12580000 0x100>;
This patch adds a hsotg node for exynos4 USB2.0 device controller. Cc: Tomasz Figa <t.figa@samsung.com> Cc: Kamil Debski <k.debski@samsung.com> Cc: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Chanho Park <chanho61.park@samsung.com> --- arch/arm/boot/dts/exynos4.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)