diff mbox

[v8,1/3] ARM: EXYNOS: initial board support for exynos5260 SoC

Message ID 1397620738-14431-2-git-send-email-rahul.sharma@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Rahul Sharma April 16, 2014, 3:58 a.m. UTC 
From: Pankaj Dubey <pankaj.dubey@samsung.com>

This patch add basic arch side support for exynos5260 SoC.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
 arch/arm/mach-exynos/Kconfig |    5 +++++
 1 file changed, 5 insertions(+)

Comments

Tomasz Figa April 16, 2014, 7:57 a.m. UTC | #1 
Hi Rahul,

On 16.04.2014 05:58, Rahul Sharma wrote:
> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>
> This patch add basic arch side support for exynos5260 SoC.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> ---
>   arch/arm/mach-exynos/Kconfig |    5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index fc8bf18..bf4ed87 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -84,6 +84,11 @@ config SOC_EXYNOS5250
>   	help
>   	  Enable EXYNOS5250 SoC support
>
> +config SOC_EXYNOS5260
> +	bool "SAMSUNG EXYNOS5260"
> +	default y
> +	depends on ARCH_EXYNOS5
> +
>   config SOC_EXYNOS5420
>   	bool "SAMSUNG EXYNOS5420"
>   	default y
>

Is this patch necessary now? After Sachin's consolidation series there 
are no per SoC entries anymore.

Best regards,
Tomasz
Sachin Kamat April 16, 2014, 8:08 a.m. UTC | #2 
Hi Tomasz,

On 16 April 2014 13:27, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> Hi Rahul,
>
>
> On 16.04.2014 05:58, Rahul Sharma wrote:
>>
>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>>
>> This patch add basic arch side support for exynos5260 SoC.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>> ---
>>   arch/arm/mach-exynos/Kconfig |    5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
>> index fc8bf18..bf4ed87 100644
>> --- a/arch/arm/mach-exynos/Kconfig
>> +++ b/arch/arm/mach-exynos/Kconfig
>> @@ -84,6 +84,11 @@ config SOC_EXYNOS5250
>>         help
>>           Enable EXYNOS5250 SoC support
>>
>> +config SOC_EXYNOS5260
>> +       bool "SAMSUNG EXYNOS5260"
>> +       default y
>> +       depends on ARCH_EXYNOS5
>> +
>>   config SOC_EXYNOS5420
>>         bool "SAMSUNG EXYNOS5420"
>>         default y
>>
>
> Is this patch necessary now? After Sachin's consolidation series there are
> no per SoC entries anymore.

Kukjin still wanted individual SoCs to be selectable. Please refer [1].

[1] http://www.spinics.net/lists/devicetree/msg27040.html
Tomasz Figa April 16, 2014, 8:10 a.m. UTC | #3 
On 16.04.2014 10:08, Sachin Kamat wrote:
> Hi Tomasz,
>
> On 16 April 2014 13:27, Tomasz Figa <tomasz.figa@gmail.com> wrote:
>> Hi Rahul,
>>
>>
>> On 16.04.2014 05:58, Rahul Sharma wrote:
>>>
>>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>>>
>>> This patch add basic arch side support for exynos5260 SoC.
>>>
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
>>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>>> ---
>>>    arch/arm/mach-exynos/Kconfig |    5 +++++
>>>    1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
>>> index fc8bf18..bf4ed87 100644
>>> --- a/arch/arm/mach-exynos/Kconfig
>>> +++ b/arch/arm/mach-exynos/Kconfig
>>> @@ -84,6 +84,11 @@ config SOC_EXYNOS5250
>>>          help
>>>            Enable EXYNOS5250 SoC support
>>>
>>> +config SOC_EXYNOS5260
>>> +       bool "SAMSUNG EXYNOS5260"
>>> +       default y
>>> +       depends on ARCH_EXYNOS5
>>> +
>>>    config SOC_EXYNOS5420
>>>          bool "SAMSUNG EXYNOS5420"
>>>          default y
>>>
>>
>> Is this patch necessary now? After Sachin's consolidation series there are
>> no per SoC entries anymore.
>
> Kukjin still wanted individual SoCs to be selectable. Please refer [1].
>
> [1] http://www.spinics.net/lists/devicetree/msg27040.html

I don't think any valid reason was presented there. Features in code 
should not be selected using #ifdef CONFIG_ anymore, so I don't really 
see any reason to not proceed with this consolidation. Olof, Arnd?

Best regards,
Tomasz
Kim Kukjin April 22, 2014, 10:36 p.m. UTC | #4 
Tomasz Figa wrote:
> 
> On 16.04.2014 10:08, Sachin Kamat wrote:
> > Hi Tomasz,
> >
> > On 16 April 2014 13:27, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> >> Hi Rahul,
> >>
> >>
> >> On 16.04.2014 05:58, Rahul Sharma wrote:
> >>>
> >>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
> >>>
> >>> This patch add basic arch side support for exynos5260 SoC.
> >>>
> >>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> >>> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> >>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> >>> ---
> >>>    arch/arm/mach-exynos/Kconfig |    5 +++++
> >>>    1 file changed, 5 insertions(+)
> >>>
> >>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-
> exynos/Kconfig
> >>> index fc8bf18..bf4ed87 100644
> >>> --- a/arch/arm/mach-exynos/Kconfig
> >>> +++ b/arch/arm/mach-exynos/Kconfig
> >>> @@ -84,6 +84,11 @@ config SOC_EXYNOS5250
> >>>          help
> >>>            Enable EXYNOS5250 SoC support
> >>>
> >>> +config SOC_EXYNOS5260
> >>> +       bool "SAMSUNG EXYNOS5260"
> >>> +       default y
> >>> +       depends on ARCH_EXYNOS5
> >>> +
> >>>    config SOC_EXYNOS5420
> >>>          bool "SAMSUNG EXYNOS5420"
> >>>          default y
> >>>
> >>
> >> Is this patch necessary now? After Sachin's consolidation series there
> are
> >> no per SoC entries anymore.
> >
> > Kukjin still wanted individual SoCs to be selectable. Please refer [1].
> >
> > [1] http://www.spinics.net/lists/devicetree/msg27040.html
> 
> I don't think any valid reason was presented there. Features in code
> should not be selected using #ifdef CONFIG_ anymore, so I don't really
> see any reason to not proceed with this consolidation. Olof, Arnd?
> 
Hi,

Yeah, in this case, nothing happened with adding SOC_EXYNOS5260. So I don't have any idea why this is required.

- Kukjin
Rahul Sharma April 24, 2014, 7:09 p.m. UTC | #5 
Hi Kukjin,

Need this macro to enable build for clock driver.

Regards,
Rahul Sharma.


On 22 April 2014 15:36, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Tomasz Figa wrote:
>>
>> On 16.04.2014 10:08, Sachin Kamat wrote:
>> > Hi Tomasz,
>> >
>> > On 16 April 2014 13:27, Tomasz Figa <tomasz.figa@gmail.com> wrote:
>> >> Hi Rahul,
>> >>
>> >>
>> >> On 16.04.2014 05:58, Rahul Sharma wrote:
>> >>>
>> >>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>> >>>
>> >>> This patch add basic arch side support for exynos5260 SoC.
>> >>>
>> >>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> >>> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
>> >>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>> >>> ---
>> >>>    arch/arm/mach-exynos/Kconfig |    5 +++++
>> >>>    1 file changed, 5 insertions(+)
>> >>>
>> >>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-
>> exynos/Kconfig
>> >>> index fc8bf18..bf4ed87 100644
>> >>> --- a/arch/arm/mach-exynos/Kconfig
>> >>> +++ b/arch/arm/mach-exynos/Kconfig
>> >>> @@ -84,6 +84,11 @@ config SOC_EXYNOS5250
>> >>>          help
>> >>>            Enable EXYNOS5250 SoC support
>> >>>
>> >>> +config SOC_EXYNOS5260
>> >>> +       bool "SAMSUNG EXYNOS5260"
>> >>> +       default y
>> >>> +       depends on ARCH_EXYNOS5
>> >>> +
>> >>>    config SOC_EXYNOS5420
>> >>>          bool "SAMSUNG EXYNOS5420"
>> >>>          default y
>> >>>
>> >>
>> >> Is this patch necessary now? After Sachin's consolidation series there
>> are
>> >> no per SoC entries anymore.
>> >
>> > Kukjin still wanted individual SoCs to be selectable. Please refer [1].
>> >
>> > [1] http://www.spinics.net/lists/devicetree/msg27040.html
>>
>> I don't think any valid reason was presented there. Features in code
>> should not be selected using #ifdef CONFIG_ anymore, so I don't really
>> see any reason to not proceed with this consolidation. Olof, Arnd?
>>
> Hi,
>
> Yeah, in this case, nothing happened with adding SOC_EXYNOS5260. So I don't have any idea why this is required.
>
> - Kukjin
>
Kim Kukjin April 26, 2014, 11:01 a.m. UTC | #6 
Rahul Sharma wrote:
> 
> Hi Kukjin,
> 
Hi,

> Need this macro to enable build for clock driver.
> 
I found it in your patch, "clk/exynos5260: add clock file for exynos5260".
For consistency, I'm fine on this, if Tomasz has no objection me to pick
this into samsung tree for the 5260 clock stuff
"drivers/clk/samsung/Makefile".

Thanks,
Kukjin

> Regards,
> Rahul Sharma.
> 
> 
> On 22 April 2014 15:36, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Tomasz Figa wrote:
> >>
> >> On 16.04.2014 10:08, Sachin Kamat wrote:
> >> > Hi Tomasz,
> >> >
> >> > On 16 April 2014 13:27, Tomasz Figa <tomasz.figa@gmail.com> wrote:
> >> >> Hi Rahul,
> >> >>
> >> >>
> >> >> On 16.04.2014 05:58, Rahul Sharma wrote:
> >> >>>
> >> >>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
> >> >>>
> >> >>> This patch add basic arch side support for exynos5260 SoC.
> >> >>>
> >> >>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> >> >>> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> >> >>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> >> >>> ---
> >> >>>    arch/arm/mach-exynos/Kconfig |    5 +++++
> >> >>>    1 file changed, 5 insertions(+)
> >> >>>
> >> >>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-
> >> exynos/Kconfig
> >> >>> index fc8bf18..bf4ed87 100644
> >> >>> --- a/arch/arm/mach-exynos/Kconfig
> >> >>> +++ b/arch/arm/mach-exynos/Kconfig
> >> >>> @@ -84,6 +84,11 @@ config SOC_EXYNOS5250
> >> >>>          help
> >> >>>            Enable EXYNOS5250 SoC support
> >> >>>
> >> >>> +config SOC_EXYNOS5260
> >> >>> +       bool "SAMSUNG EXYNOS5260"
> >> >>> +       default y
> >> >>> +       depends on ARCH_EXYNOS5
> >> >>> +
> >> >>>    config SOC_EXYNOS5420
> >> >>>          bool "SAMSUNG EXYNOS5420"
> >> >>>          default y
> >> >>>
> >> >>
> >> >> Is this patch necessary now? After Sachin's consolidation series
> there
> >> are
> >> >> no per SoC entries anymore.
> >> >
> >> > Kukjin still wanted individual SoCs to be selectable. Please refer
> [1].
> >> >
> >> > [1] http://www.spinics.net/lists/devicetree/msg27040.html
> >>
> >> I don't think any valid reason was presented there. Features in code
> >> should not be selected using #ifdef CONFIG_ anymore, so I don't really
> >> see any reason to not proceed with this consolidation. Olof, Arnd?
> >>
> > Hi,
> >
> > Yeah, in this case, nothing happened with adding SOC_EXYNOS5260. So I
> don't have any idea why this is required.
> >
> > - Kukjin
> >
Rahul Sharma April 28, 2014, 6:33 a.m. UTC | #7 
Hi Tomasz,

Please share your opinion.

Regards,
Rahul Sharma

On 26 April 2014 16:31, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Rahul Sharma wrote:
>>
>> Hi Kukjin,
>>
> Hi,
>
>> Need this macro to enable build for clock driver.
>>
> I found it in your patch, "clk/exynos5260: add clock file for exynos5260".
> For consistency, I'm fine on this, if Tomasz has no objection me to pick
> this into samsung tree for the 5260 clock stuff
> "drivers/clk/samsung/Makefile".
>
> Thanks,
> Kukjin
>
>> Regards,
>> Rahul Sharma.
>>
>>
>> On 22 April 2014 15:36, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> > Tomasz Figa wrote:
>> >>
>> >> On 16.04.2014 10:08, Sachin Kamat wrote:
>> >> > Hi Tomasz,
>> >> >
>> >> > On 16 April 2014 13:27, Tomasz Figa <tomasz.figa@gmail.com> wrote:
>> >> >> Hi Rahul,
>> >> >>
>> >> >>
>> >> >> On 16.04.2014 05:58, Rahul Sharma wrote:
>> >> >>>
>> >> >>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>> >> >>>
>> >> >>> This patch add basic arch side support for exynos5260 SoC.
>> >> >>>
>> >> >>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> >> >>> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
>> >> >>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>> >> >>> ---
>> >> >>>    arch/arm/mach-exynos/Kconfig |    5 +++++
>> >> >>>    1 file changed, 5 insertions(+)
>> >> >>>
>> >> >>> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-
>> >> exynos/Kconfig
>> >> >>> index fc8bf18..bf4ed87 100644
>> >> >>> --- a/arch/arm/mach-exynos/Kconfig
>> >> >>> +++ b/arch/arm/mach-exynos/Kconfig
>> >> >>> @@ -84,6 +84,11 @@ config SOC_EXYNOS5250
>> >> >>>          help
>> >> >>>            Enable EXYNOS5250 SoC support
>> >> >>>
>> >> >>> +config SOC_EXYNOS5260
>> >> >>> +       bool "SAMSUNG EXYNOS5260"
>> >> >>> +       default y
>> >> >>> +       depends on ARCH_EXYNOS5
>> >> >>> +
>> >> >>>    config SOC_EXYNOS5420
>> >> >>>          bool "SAMSUNG EXYNOS5420"
>> >> >>>          default y
>> >> >>>
>> >> >>
>> >> >> Is this patch necessary now? After Sachin's consolidation series
>> there
>> >> are
>> >> >> no per SoC entries anymore.
>> >> >
>> >> > Kukjin still wanted individual SoCs to be selectable. Please refer
>> [1].
>> >> >
>> >> > [1] http://www.spinics.net/lists/devicetree/msg27040.html
>> >>
>> >> I don't think any valid reason was presented there. Features in code
>> >> should not be selected using #ifdef CONFIG_ anymore, so I don't really
>> >> see any reason to not proceed with this consolidation. Olof, Arnd?
>> >>
>> > Hi,
>> >
>> > Yeah, in this case, nothing happened with adding SOC_EXYNOS5260. So I
>> don't have any idea why this is required.
>> >
>> > - Kukjin
>> >
>
Tomasz Figa May 8, 2014, 5:37 p.m. UTC | #8 
Hi Kukjin,

On 26.04.2014 13:01, Kukjin Kim wrote:
> Rahul Sharma wrote:
>>
>> Hi Kukjin,
>>
> Hi,
> 
>> Need this macro to enable build for clock driver.
>>
> I found it in your patch, "clk/exynos5260: add clock file for exynos5260".
> For consistency, I'm fine on this, if Tomasz has no objection me to pick
> this into samsung tree for the 5260 clock stuff
> "drivers/clk/samsung/Makefile".

Yes, this should go through Samsung tree, but let me prepare a branch
for you to pull from with all the necessary dependencies.

Best regards,
Tomasz
diff mbox

Patch

diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index fc8bf18..bf4ed87 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -84,6 +84,11 @@  config SOC_EXYNOS5250
 	help
 	  Enable EXYNOS5250 SoC support
 
+config SOC_EXYNOS5260
+	bool "SAMSUNG EXYNOS5260"
+	default y
+	depends on ARCH_EXYNOS5
+
 config SOC_EXYNOS5420
 	bool "SAMSUNG EXYNOS5420"
 	default y