diff mbox

[V2] arm64: Fix PSCI part of booting.txt

Message ID 1397763592.30572.56.camel@smoke (mailing list archive)
State New, archived
Headers show

Commit Message

Geoff Levand April 17, 2014, 7:39 p.m. UTC
Correct the PSCI booting text to reflect the requirements
of the PSCI spec.

Signed-off-by: Geoff Levand <geoff@infradead.org>
---
v2: Change to mention online CPUs only.

 Documentation/arm64/booting.txt | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

   Documentation/devicetree/bindings/arm/psci.txt.

Comments

Mark Rutland April 17, 2014, 7:53 p.m. UTC | #1
On Thu, Apr 17, 2014 at 08:39:52PM +0100, Geoff Levand wrote:
> Correct the PSCI booting text to reflect the requirements
> of the PSCI spec.
> 
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> v2: Change to mention online CPUs only.
> 
>  Documentation/arm64/booting.txt | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/arm64/booting.txt
> b/Documentation/arm64/booting.txt
> index beb754e..e5b9c81 100644
> --- a/Documentation/arm64/booting.txt
> +++ b/Documentation/arm64/booting.txt
> @@ -167,13 +167,12 @@ following manner:
>    value, so CPUs must convert the read value to their native endianness
>    before jumping to it.
>  
> -- CPUs with a "psci" enable method should remain outside of
> -  the kernel (i.e. outside of the regions of memory described to the
> -  kernel in the memory node, or in a reserved area of memory described
> -  to the kernel by a /memreserve/ region in the device tree).  The
> -  kernel will issue CPU_ON calls as described in ARM document number
> ARM
> -  DEN 0022A ("Power State Coordination Interface System Software on ARM
> -  processors") to bring CPUs into the kernel.
> +- CPUs with a "psci" enable method should use the PSCI CPU control
> +  functions described in ARM document number ARM DEN 0022A or newer
> +  ("Power State Coordination Interface System Software on ARM
> +  processors").  The boot loader must power off any of these CPUs that
> +  have been brought online using the PSCI CPU_OFF function.  The kernel
> +  will issue CPU_ON calls to bring CPUs into the kernel.

Can we not just say that the bootloader must ensure these CPUs are in
the OFF state? That covers those onlined then offlined by the bootloader
and any others (which we don't currently define the state of).

Mark.
diff mbox

Patch

diff --git a/Documentation/arm64/booting.txt
b/Documentation/arm64/booting.txt
index beb754e..e5b9c81 100644
--- a/Documentation/arm64/booting.txt
+++ b/Documentation/arm64/booting.txt
@@ -167,13 +167,12 @@  following manner:
   value, so CPUs must convert the read value to their native endianness
   before jumping to it.
 
-- CPUs with a "psci" enable method should remain outside of
-  the kernel (i.e. outside of the regions of memory described to the
-  kernel in the memory node, or in a reserved area of memory described
-  to the kernel by a /memreserve/ region in the device tree).  The
-  kernel will issue CPU_ON calls as described in ARM document number
ARM
-  DEN 0022A ("Power State Coordination Interface System Software on ARM
-  processors") to bring CPUs into the kernel.
+- CPUs with a "psci" enable method should use the PSCI CPU control
+  functions described in ARM document number ARM DEN 0022A or newer
+  ("Power State Coordination Interface System Software on ARM
+  processors").  The boot loader must power off any of these CPUs that
+  have been brought online using the PSCI CPU_OFF function.  The kernel
+  will issue CPU_ON calls to bring CPUs into the kernel.
 
   The device tree should contain a 'psci' node, as described in