From patchwork Mon Apr 21 21:11:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 4026261 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A8E959F391 for ; Mon, 21 Apr 2014 21:16:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BC37F202B8 for ; Mon, 21 Apr 2014 21:16:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF52920265 for ; Mon, 21 Apr 2014 21:16:08 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WcLVm-0002OX-Aw; Mon, 21 Apr 2014 21:12:22 +0000 Received: from mail-yk0-f171.google.com ([209.85.160.171]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WcLVj-0002IL-IH for linux-arm-kernel@lists.infradead.org; Mon, 21 Apr 2014 21:12:20 +0000 Received: by mail-yk0-f171.google.com with SMTP id q9so3874447ykb.30 for ; Mon, 21 Apr 2014 14:11:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=J8NdJNCmOpNTOAXiboKlqY+4HnLrQRRRUdV7Cuzydwk=; b=Giq3d5J50C+0EGudv3sBjON2ru9YOv4aGlPwztV7VkweUENJvBYl7omSmLZ9r1bwTm NGVwWHNGmE9DFbKdXetOm0deu8MBJOgKQ4fTIxvc26U0ev1YLUyAdzSEgfEBZ7S+2kIe vC6S9xM/ioQV4ii/UNx/U4yDlGG6UYyAyMx4XZQa0X/YyIWAb4xMlKgdDEQheN3cHhub onTXalRBa0bj/ccBzK7vm1MhK3bahsRWLTuZAVvJMYYi7PUeLbcF7hZCO8nyYmhjcFmx QU/o2SLCUpwKRl27XFOdNXouihh1jI57YoiB+sXp47aJRrL9c6/rdfQ9bkC68hnqCfR3 SfIQ== X-Gm-Message-State: ALoCoQnZMA72B1EQxB19cLAgM+2uwKyLNhk0gan7MoTCpnzayHP3wVRW0Y4f0PlcUNXMMhTP6b0A X-Received: by 10.236.156.65 with SMTP id l41mr55127957yhk.9.1398114717698; Mon, 21 Apr 2014 14:11:57 -0700 (PDT) Received: from localhost.localdomain (c-71-195-31-37.hsd1.mn.comcast.net. [71.195.31.37]) by mx.google.com with ESMTPSA id d68sm73391492yhc.37.2014.04.21.14.11.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Apr 2014 14:11:56 -0700 (PDT) From: Alex Elder To: mturquette@linaro.org, mporter@linaro.org, bcm@fixthebug.org Subject: [PATCH v4 RESEND 1/7] clk: bcm281xx: warn if ccu_wait_bit() fails Date: Mon, 21 Apr 2014 16:11:37 -0500 Message-Id: <1398114703-32410-2-git-send-email-elder@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1398114703-32410-1-git-send-email-elder@linaro.org> References: <1398114703-32410-1-git-send-email-elder@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140421_141219_690159_AB07ED9F X-CRM114-Status: UNSURE ( 9.03 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.7 (/) Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Don't let a failure of ccu_wait_bit() go unnoticed. Signed-off-by: Alex Elder --- drivers/clk/bcm/clk-kona.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/bcm/clk-kona.c b/drivers/clk/bcm/clk-kona.c index db11a87..4b4e35a 100644 --- a/drivers/clk/bcm/clk-kona.c +++ b/drivers/clk/bcm/clk-kona.c @@ -207,6 +207,9 @@ __ccu_wait_bit(struct ccu_data *ccu, u32 reg_offset, u32 bit, bool want) return true; udelay(1); } + pr_warn("%s: %s/0x%04x bit %u was never %s\n", __func__, + ccu->name, reg_offset, bit, want ? "set" : "clear"); + return false; }