From patchwork Tue Apr 22 14:19:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 4032821 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5FE259F1F4 for ; Tue, 22 Apr 2014 14:23:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3BEB12025B for ; Tue, 22 Apr 2014 14:23:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8C80201B4 for ; Tue, 22 Apr 2014 14:23:24 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WcbYm-0006gk-3p; Tue, 22 Apr 2014 14:20:32 +0000 Received: from mail-yk0-f177.google.com ([209.85.160.177]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WcbYi-0006Sx-3a for linux-arm-kernel@lists.infradead.org; Tue, 22 Apr 2014 14:20:30 +0000 Received: by mail-yk0-f177.google.com with SMTP id q200so4594699ykb.8 for ; Tue, 22 Apr 2014 07:20:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=JUoa2zrmzX16bKqNgzELXVJQ4Uxn2MsZDDHxn6PHcqY=; b=HFg34EhC9xFu79qMtKSIEVOSzFk4oKGSmErNRql3CduF6bH+Lsyx2WDHiglpW+FGSs lUsnu4EglsoksppJ+AuT7kdC3Z1uD3QOVH643XIR346pJwzpUxRUlYp0hV7bmQi21RR4 S5U6aTvZURzQ27WbpglOvhJdtNoZ9wbnp/PH9i5tOS4VHEHllXQYTXNwvsbE3PChOg5t 9sP/f9TSy0fYg2DFjXfjkGSHSPwh1W5f55mbKC7zqowwRKiWQOAfBoDoeJVBsV61ugzP xGXSeotJxKkJpsLp9PogrksMZir434GfWmI0DnbSHPMLbxK4ekU6JrTeWExE5aTBvdXz Ouyw== X-Gm-Message-State: ALoCoQl3tIBkCmjeauEN6SNybe+IXDT/kk1cD5wNDLP+y/p4mGtbMKtr5om90OsSi4gX7aZGjBPq X-Received: by 10.236.137.8 with SMTP id x8mr59454956yhi.4.1398176403787; Tue, 22 Apr 2014 07:20:03 -0700 (PDT) Received: from localhost.localdomain ([190.2.108.30]) by mx.google.com with ESMTPSA id t9sm78972854yhg.18.2014.04.22.07.20.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 22 Apr 2014 07:20:03 -0700 (PDT) From: Ezequiel Garcia To: , , Subject: [PATCH] ARM: dts: am33xx: Move the cppi41dma node so it's probed early Date: Tue, 22 Apr 2014 11:19:31 -0300 Message-Id: <1398176371-26468-1-git-send-email-ezequiel@vanguardiasur.com.ar> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140422_072028_221249_3A838F5F X-CRM114-Status: GOOD ( 11.95 ) X-Spam-Score: -0.7 (/) Cc: Ezequiel Garcia , Sebastian Andrzej Siewior , =?UTF-8?q?Guido=20Mart=C3=ADnez?= , Felipe Balbi , Daniel Mack X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The DMA controller is needed for the USB controller to be correctly registered. Therefore, if the DMA node is located at the end an unecessary probe deferral is produced systematically. This is easily fixed by moving the node at the beggining of the child list, so it's probed first. Signed-off-by: Ezequiel Garcia --- Felipe, Sebastian: I cannot see why the cppi41dma node must be placed inside the "ti,am33xx-usb" compatible node. Tried to move it out so it's probed just like the edma engine, but the USB doesn't work properly in that case. Can you enlighten me? In any case, this change is good enough to remove the deferral probe. Thanks! arch/arm/boot/dts/am33xx.dtsi | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index 9770e35..c673be4 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -453,6 +453,21 @@ ti,hwmods = "usb_otg_hs"; status = "disabled"; + cppi41dma: dma-controller@47402000 { + compatible = "ti,am3359-cppi41"; + reg = <0x47400000 0x1000 + 0x47402000 0x1000 + 0x47403000 0x1000 + 0x47404000 0x4000>; + reg-names = "glue", "controller", "scheduler", "queuemgr"; + interrupts = <17>; + interrupt-names = "glue"; + #dma-cells = <2>; + #dma-channels = <30>; + #dma-requests = <256>; + status = "disabled"; + }; + usb_ctrl_mod: control@44e10620 { compatible = "ti,am335x-usb-ctrl-module"; reg = <0x44e10620 0x10 @@ -556,20 +571,6 @@ "tx14", "tx15"; }; - cppi41dma: dma-controller@47402000 { - compatible = "ti,am3359-cppi41"; - reg = <0x47400000 0x1000 - 0x47402000 0x1000 - 0x47403000 0x1000 - 0x47404000 0x4000>; - reg-names = "glue", "controller", "scheduler", "queuemgr"; - interrupts = <17>; - interrupt-names = "glue"; - #dma-cells = <2>; - #dma-channels = <30>; - #dma-requests = <256>; - status = "disabled"; - }; }; epwmss0: epwmss@48300000 {