| Message ID | 1398295293-11033-5-git-send-email-mporter@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> Adds additional nodes to support GPLDO1-6 and VBUS regulators which > are now supported in the bcm590xx regulator driver. > > Signed-off-by: Matt Porter <mporter@linaro.org> > --- > arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) I'm not going to apply this with the rest of the set. It will have to go in via your normal arch/arm route. > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi > index dfadaaa..066adfb 100644 > --- a/arch/arm/boot/dts/bcm59056.dtsi > +++ b/arch/arm/boot/dts/bcm59056.dtsi > @@ -70,5 +70,26 @@ > > vsr_reg: vsr { > }; > + > + gpldo1_reg: gpldo1 { > + }; What do these empty nodes do in any case? Don't you at least need a status property in there or something? > + gpldo2_reg: gpldo2 { > + }; > + > + gpldo3_reg: gpldo3 { > + }; > + > + gpldo4_reg: gpldo4 { > + }; > + > + gpldo5_reg: gpldo5 { > + }; > + > + gpldo6_reg: gpldo6 { > + }; > + > + vbus_reg: vbus { > + }; > }; > };
On Wed, May 21, 2014 at 10:29:13AM +0100, Lee Jones wrote: > > Adds additional nodes to support GPLDO1-6 and VBUS regulators which > > are now supported in the bcm590xx regulator driver. > > > > Signed-off-by: Matt Porter <mporter@linaro.org> > > --- > > arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > I'm not going to apply this with the rest of the set. It will have to > go in via your normal arch/arm route. Ok > > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi > > index dfadaaa..066adfb 100644 > > --- a/arch/arm/boot/dts/bcm59056.dtsi > > +++ b/arch/arm/boot/dts/bcm59056.dtsi > > @@ -70,5 +70,26 @@ > > > > vsr_reg: vsr { > > }; > > + > > + gpldo1_reg: gpldo1 { > > + }; > > What do these empty nodes do in any case? They instantiate regulators. The bcm590xx binding specifies the allowable subnode names permitted here. This replaces the old method of specifying an index or the deprecated regulator-compatible property. The board-specific dts includes this dtsi and applies any board constraints to a subset of regulators that need them. Unused regulators are all disabled which is what we want. > Don't you at least need a status property in there or something? Not necessary for these subnodes. -Matt
> > > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi > > > index dfadaaa..066adfb 100644 > > > --- a/arch/arm/boot/dts/bcm59056.dtsi > > > +++ b/arch/arm/boot/dts/bcm59056.dtsi > > > @@ -70,5 +70,26 @@ > > > > > > vsr_reg: vsr { > > > }; > > > + > > > + gpldo1_reg: gpldo1 { > > > + }; > > > > What do these empty nodes do in any case? > > They instantiate regulators. The bcm590xx binding specifies the > allowable subnode names permitted here. This replaces the old method > of specifying an index or the deprecated regulator-compatible property. > The board-specific dts includes this dtsi and applies any board > constraints to a subset of regulators that need them. Unused regulators > are all disabled which is what we want. > > > Don't you at least need a status property in there or something? > > Not necessary for these subnodes. Very well, thanks for the clarification.
On Wed, Apr 23, 2014 at 07:21:33PM -0400, Matt Porter wrote: > Adds additional nodes to support GPLDO1-6 and VBUS regulators which > are now supported in the bcm590xx regulator driver. Applied to mach-bcm for-3.16/dt > arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi > index dfadaaa..066adfb 100644 > --- a/arch/arm/boot/dts/bcm59056.dtsi > +++ b/arch/arm/boot/dts/bcm59056.dtsi > @@ -70,5 +70,26 @@ > > vsr_reg: vsr { > }; > + > + gpldo1_reg: gpldo1 { > + }; > + > + gpldo2_reg: gpldo2 { > + }; > + > + gpldo3_reg: gpldo3 { > + }; > + > + gpldo4_reg: gpldo4 { > + }; > + > + gpldo5_reg: gpldo5 { > + }; > + > + gpldo6_reg: gpldo6 { > + }; > + > + vbus_reg: vbus { > + }; > }; > }; > -- > 1.8.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
diff --git a/arch/arm/boot/dts/bcm59056.dtsi b/arch/arm/boot/dts/bcm59056.dtsi index dfadaaa..066adfb 100644 --- a/arch/arm/boot/dts/bcm59056.dtsi +++ b/arch/arm/boot/dts/bcm59056.dtsi @@ -70,5 +70,26 @@ vsr_reg: vsr { }; + + gpldo1_reg: gpldo1 { + }; + + gpldo2_reg: gpldo2 { + }; + + gpldo3_reg: gpldo3 { + }; + + gpldo4_reg: gpldo4 { + }; + + gpldo5_reg: gpldo5 { + }; + + gpldo6_reg: gpldo6 { + }; + + vbus_reg: vbus { + }; }; };
Adds additional nodes to support GPLDO1-6 and VBUS regulators which are now supported in the bcm590xx regulator driver. Signed-off-by: Matt Porter <mporter@linaro.org> --- arch/arm/boot/dts/bcm59056.dtsi | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)