diff mbox

mmc: wmt-sdmmc: Use GFP_KERNEL instead of hard-coded value

Message ID 1398646711.10750.0.camel@phoenix (mailing list archive)
State New, archived
Headers show

Commit Message

Axel Lin April 28, 2014, 12:58 a.m. UTC 
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/mmc/host/wmt-sdmmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Axel Lin May 14, 2014, 11:01 a.m. UTC | #1 
2014-04-28 8:58 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/mmc/host/wmt-sdmmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
> index 34231d5..3605c37 100644
> --- a/drivers/mmc/host/wmt-sdmmc.c
> +++ b/drivers/mmc/host/wmt-sdmmc.c
> @@ -852,7 +852,7 @@ static int wmt_mci_probe(struct platform_device *pdev)
>         priv->dma_desc_buffer = dma_alloc_coherent(&pdev->dev,
>                                                    mmc->max_blk_count * 16,
>                                                    &priv->dma_desc_device_addr,
> -                                                  208);
> +                                                  GFP_KERNEL);

Hi Ulf,
This is a pretty trivial patch.
Would you pick up this patch?

Regards,
Axel
Ulf Hansson May 14, 2014, 11:13 a.m. UTC | #2 
On 14 May 2014 13:01, Axel Lin <axel.lin@ingics.com> wrote:
> 2014-04-28 8:58 GMT+08:00 Axel Lin <axel.lin@ingics.com>:
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>>  drivers/mmc/host/wmt-sdmmc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
>> index 34231d5..3605c37 100644
>> --- a/drivers/mmc/host/wmt-sdmmc.c
>> +++ b/drivers/mmc/host/wmt-sdmmc.c
>> @@ -852,7 +852,7 @@ static int wmt_mci_probe(struct platform_device *pdev)
>>         priv->dma_desc_buffer = dma_alloc_coherent(&pdev->dev,
>>                                                    mmc->max_blk_count * 16,
>>                                                    &priv->dma_desc_device_addr,
>> -                                                  208);
>> +                                                  GFP_KERNEL);
>
> Hi Ulf,
> This is a pretty trivial patch.
> Would you pick up this patch?

Done.

Kind regards
Ulf Hansson

>
> Regards,
> Axel
diff mbox

Patch

diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
index 34231d5..3605c37 100644
--- a/drivers/mmc/host/wmt-sdmmc.c
+++ b/drivers/mmc/host/wmt-sdmmc.c
@@ -852,7 +852,7 @@  static int wmt_mci_probe(struct platform_device *pdev)
 	priv->dma_desc_buffer = dma_alloc_coherent(&pdev->dev,
 						   mmc->max_blk_count * 16,
 						   &priv->dma_desc_device_addr,
-						   208);
+						   GFP_KERNEL);
 	if (!priv->dma_desc_buffer) {
 		dev_err(&pdev->dev, "DMA alloc fail\n");
 		ret = -EPERM;