| Message ID | 1399082069-6666-1-git-send-email-agross@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 2014-05-02 at 20:54 -0500, Andy Gross wrote: > This patch corrects the error check on the call to pm_runtime_get_sync. > > Signed-off-by: Andy Gross <agross@codeaurora.org> Reviewed-by: Ivan T. Ivanov <iivanov@mm-sol.com> > --- > drivers/i2c/busses/i2c-qup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c > index 1b4cf14..2a5efb5 100644 > --- a/drivers/i2c/busses/i2c-qup.c > +++ b/drivers/i2c/busses/i2c-qup.c > @@ -479,7 +479,7 @@ static int qup_i2c_xfer(struct i2c_adapter *adap, > int ret, idx; > > ret = pm_runtime_get_sync(qup->dev); > - if (ret) > + if (ret < 0) > goto out; > > writel(1, qup->base + QUP_SW_RESET);
On Fri, May 2, 2014 at 6:54 PM, Andy Gross <agross@codeaurora.org> wrote: [...] > @@ -479,7 +479,7 @@ static int qup_i2c_xfer(struct i2c_adapter *adap, > int ret, idx; > > ret = pm_runtime_get_sync(qup->dev); > - if (ret) > + if (ret < 0) > goto out; Sorry about that, thought I tested that path properly. Wolfram, please pick this up as soon as possible as it renders the driver useless if one enables pm runtime. Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> Regards, Bjorn
On Fri, May 02, 2014 at 08:54:29PM -0500, Andy Gross wrote: > This patch corrects the error check on the call to pm_runtime_get_sync. > > Signed-off-by: Andy Gross <agross@codeaurora.org> Applied to for-current, thanks!
diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 1b4cf14..2a5efb5 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b/drivers/i2c/busses/i2c-qup.c @@ -479,7 +479,7 @@ static int qup_i2c_xfer(struct i2c_adapter *adap, int ret, idx; ret = pm_runtime_get_sync(qup->dev); - if (ret) + if (ret < 0) goto out; writel(1, qup->base + QUP_SW_RESET);
This patch corrects the error check on the call to pm_runtime_get_sync. Signed-off-by: Andy Gross <agross@codeaurora.org> --- drivers/i2c/busses/i2c-qup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)