| Message ID | 1399883209-31169-2-git-send-email-acourbot@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/12/2014 02:26 AM, Alexandre Courbot wrote: > NVIDIA SHIELD embeds a USB controller. Compile the corresponding support USB controller or USB joystick? > as a module in tegra_defconfig. Why make this a module rather than built-in. Almost everything else in tegra_defconfig is built-in, except brcmfmac since it doesn't handle lack of firmware availability at probe time.
On Tue, May 13, 2014 at 1:32 AM, Stephen Warren <swarren@wwwdotorg.org> wrote: > On 05/12/2014 02:26 AM, Alexandre Courbot wrote: >> NVIDIA SHIELD embeds a USB controller. Compile the corresponding support > > USB controller or USB joystick? I understand this sounds like "EHCI controller" here. Will reword. > >> as a module in tegra_defconfig. > > Why make this a module rather than built-in. Almost everything else in > tegra_defconfig is built-in, except brcmfmac since it doesn't handle > lack of firmware availability at probe time. Goal is to minimize the image size, especially since this is not a feature I expect to be used much outside of SHIELD. If you prefer it built-in, I'm fine with it too. Thanks, Alex.
On 05/12/2014 09:45 PM, Alexandre Courbot wrote: > On Tue, May 13, 2014 at 1:32 AM, Stephen Warren <swarren@wwwdotorg.org> wrote: >> On 05/12/2014 02:26 AM, Alexandre Courbot wrote: >>> NVIDIA SHIELD embeds a USB controller. Compile the corresponding support >>> as a module in tegra_defconfig. >> >> Why make this a module rather than built-in. Almost everything else in >> tegra_defconfig is built-in, except brcmfmac since it doesn't handle >> lack of firmware availability at probe time. > > Goal is to minimize the image size, especially since this is not a > feature I expect to be used much outside of SHIELD. If you prefer it > built-in, I'm fine with it too. Yes, built-in for everything makes most sense to me, except for code that doesn't actually work unless it's a module.
diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig index 8c1625b78034..f99121b78968 100644 --- a/arch/arm/configs/tegra_defconfig +++ b/arch/arm/configs/tegra_defconfig @@ -114,6 +114,7 @@ CONFIG_USB_NET_SMSC95XX=y CONFIG_BRCMFMAC=m CONFIG_RT2X00=y CONFIG_RT2800USB=m +CONFIG_INPUT_JOYDEV=m CONFIG_INPUT_EVDEV=y CONFIG_KEYBOARD_GPIO=y CONFIG_KEYBOARD_TEGRA=y
NVIDIA SHIELD embeds a USB controller. Compile the corresponding support as a module in tegra_defconfig. Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> --- arch/arm/configs/tegra_defconfig | 1 + 1 file changed, 1 insertion(+)