| Message ID | 1400029380-5372-3-git-send-email-thomas.ab@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 13, 2014 at 8:03 PM, Thomas Abraham <ta.omasab@gmail.com> wrote: > From: Thomas Abraham <thomas.ab@samsung.com> > > Add a new optional boost-frequency binding for specifying the frequencies > usable in boost mode. > > Cc: Nishanth Menon <nm@ti.com> > Cc: Lukasz Majewski <l.majewski@samsung.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Pawel Moll <pawel.moll@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> > Cc: Kumar Gala <galak@codeaurora.org> > Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> > --- > .../devicetree/bindings/cpufreq/cpufreq-boost.txt | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt > > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt > new file mode 100644 > index 0000000..d925e38 > --- /dev/null > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt > @@ -0,0 +1,11 @@ > +* Device tree binding for CPU boost frequency (aka over-clocking) > + > +Certain CPU's can be operated in optional 'boost' mode (or sometimes referred as > +overclocking) in which the CPU can operate in frequencies beyond the normal "operate at"? > +operating conditions. "normal operating conditions" probably need a little bit of an expansion here perhaps? > + > +Optional Properties: > +- boost-frequency: list of frequencies in KHz to be used only in boost mode. probably boost-frequencies? > + This list should be a subset of frequencies listed in "operating-points" > + property. Refer to Documentation/devicetree/bindings/power/opp.txt for > + details about "operating-points" property. an example is expected here. personally, I think I understand the intent here, but as a hardware description, will let folks comment if it is acceptable. -- Regards, Nishanth Menon
On Wed, May 14, 2014 at 7:32 AM, Nishanth Menon <nm@ti.com> wrote: > On Tue, May 13, 2014 at 8:03 PM, Thomas Abraham <ta.omasab@gmail.com> wrote: >> From: Thomas Abraham <thomas.ab@samsung.com> >> >> Add a new optional boost-frequency binding for specifying the frequencies >> usable in boost mode. >> >> Cc: Nishanth Menon <nm@ti.com> >> Cc: Lukasz Majewski <l.majewski@samsung.com> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Pawel Moll <pawel.moll@arm.com> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> >> Cc: Kumar Gala <galak@codeaurora.org> >> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> >> --- >> .../devicetree/bindings/cpufreq/cpufreq-boost.txt | 11 +++++++++++ >> 1 files changed, 11 insertions(+), 0 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt >> >> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt >> new file mode 100644 >> index 0000000..d925e38 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt >> @@ -0,0 +1,11 @@ >> +* Device tree binding for CPU boost frequency (aka over-clocking) >> + >> +Certain CPU's can be operated in optional 'boost' mode (or sometimes referred as >> +overclocking) in which the CPU can operate in frequencies beyond the normal > > "operate at"? > >> +operating conditions. > > "normal operating conditions" probably need a little bit of an > expansion here perhaps? > >> + >> +Optional Properties: >> +- boost-frequency: list of frequencies in KHz to be used only in boost mode. > > probably boost-frequencies? > >> + This list should be a subset of frequencies listed in "operating-points" >> + property. Refer to Documentation/devicetree/bindings/power/opp.txt for >> + details about "operating-points" property. > > > an example is expected here. > > personally, I think I understand the intent here, but as a hardware > description, will let folks comment if it is acceptable. Thanks for your review Nishanth. I will do the changes you have suggested. Regards, Thomas. > > -- > Regards, > Nishanth Menon
On 14/05/14 02:03, Thomas Abraham wrote: > From: Thomas Abraham <thomas.ab@samsung.com> > > Add a new optional boost-frequency binding for specifying the frequencies > usable in boost mode. > > Cc: Nishanth Menon <nm@ti.com> > Cc: Lukasz Majewski <l.majewski@samsung.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Pawel Moll <pawel.moll@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> > Cc: Kumar Gala <galak@codeaurora.org> > Signed-off-by: Thomas Abraham <thomas.ab@samsung.com> > --- > .../devicetree/bindings/cpufreq/cpufreq-boost.txt | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt > > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt > new file mode 100644 > index 0000000..d925e38 > --- /dev/null > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt > @@ -0,0 +1,11 @@ > +* Device tree binding for CPU boost frequency (aka over-clocking) > + > +Certain CPU's can be operated in optional 'boost' mode (or sometimes referred as > +overclocking) in which the CPU can operate in frequencies beyond the normal > +operating conditions. > + > +Optional Properties: > +- boost-frequency: list of frequencies in KHz to be used only in boost mode. > + This list should be a subset of frequencies listed in "operating-points" > + property. Refer to Documentation/devicetree/bindings/power/opp.txt for > + details about "operating-points" property. > Though I understand the need of it, I think the binding is designed to suffice the need of the boost frequency support in cpufreq. Typically SoC would provide characteristics like under-drive(hits performance but most energy efficient), nominal(highest sustained performance w/o any external constraint like power, thermal) and over-drive(maximum performance but not sustainable for long periods) IMO the binding could represent these unique points on the curve instead. Regards, Sudeep
diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt new file mode 100644 index 0000000..d925e38 --- /dev/null +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt @@ -0,0 +1,11 @@ +* Device tree binding for CPU boost frequency (aka over-clocking) + +Certain CPU's can be operated in optional 'boost' mode (or sometimes referred as +overclocking) in which the CPU can operate in frequencies beyond the normal +operating conditions. + +Optional Properties: +- boost-frequency: list of frequencies in KHz to be used only in boost mode. + This list should be a subset of frequencies listed in "operating-points" + property. Refer to Documentation/devicetree/bindings/power/opp.txt for + details about "operating-points" property.