| Message ID | 1400035562-16832-5-git-send-email-rahul.sharma@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/14/14 11:46, Rahul Sharma wrote: > From: Rahul Sharma<Rahul.Sharma@samsung.com> > > "gpx3-7" is chip specific pin in Exynos5420 for hdmi > hotplug. This pin is moved to exynos5420-pinctrl.dts > and removed from the board file. Rahul, you may need to put the change (moving the pin from smdk5420 board to exynos5420-pinctrl.dts) before the patch 3/5. - Kukjin > > Signed-off-by: Rahul Sharma<Rahul.Sharma@samsung.com> > --- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts > index 6910485..11cd9bf 100644 > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > @@ -131,15 +131,6 @@ > }; > }; > > - pinctrl@13400000 { > - hdmi_hpd_irq: hdmi-hpd-irq { > - samsung,pins = "gpx3-7"; > - samsung,pin-function =<0>; > - samsung,pin-pud =<1>; > - samsung,pin-drv =<0>; > - }; > - }; > - > hdmi@14530000 { > status = "okay"; > hpd-gpio =<&gpx3 7 0>;
On 15 May 2014 00:15, Kukjin Kim <kgene.kim@samsung.com> wrote: > On 05/14/14 11:46, Rahul Sharma wrote: >> >> From: Rahul Sharma<Rahul.Sharma@samsung.com> >> >> "gpx3-7" is chip specific pin in Exynos5420 for hdmi >> hotplug. This pin is moved to exynos5420-pinctrl.dts >> and removed from the board file. > > > Rahul, you may need to put the change (moving the pin from smdk5420 board to > exynos5420-pinctrl.dts) before the patch 3/5. > Hi Kukjin, Ok. I will post with that change tomorrow. Regards, Rahul Sharma. > - Kukjin > > >> >> Signed-off-by: Rahul Sharma<Rahul.Sharma@samsung.com> >> --- >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 9 --------- >> 1 file changed, 9 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> index 6910485..11cd9bf 100644 >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> @@ -131,15 +131,6 @@ >> }; >> }; >> >> - pinctrl@13400000 { >> - hdmi_hpd_irq: hdmi-hpd-irq { >> - samsung,pins = "gpx3-7"; >> - samsung,pin-function =<0>; >> - samsung,pin-pud =<1>; >> - samsung,pin-drv =<0>; >> - }; >> - }; >> - >> hdmi@14530000 { >> status = "okay"; >> hpd-gpio =<&gpx3 7 0>;
Hi Rahul, On 14.05.2014 04:46, Rahul Sharma wrote: > From: Rahul Sharma <Rahul.Sharma@samsung.com> > > "gpx3-7" is chip specific pin in Exynos5420 for hdmi > hotplug. This pin is moved to exynos5420-pinctrl.dts > and removed from the board file. > > Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com> > --- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts > index 6910485..11cd9bf 100644 > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > @@ -131,15 +131,6 @@ > }; > }; > > - pinctrl@13400000 { > - hdmi_hpd_irq: hdmi-hpd-irq { > - samsung,pins = "gpx3-7"; > - samsung,pin-function = <0>; > - samsung,pin-pud = <1>; > - samsung,pin-drv = <0>; Again, the same comment as for patch 1/5. This pin is being configured as input, which doesn't look like a dedicated special function pin. Shouldn't this node rather stay here? Best regards, Tomasz
On 15 May 2014 01:21, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Rahul, > > On 14.05.2014 04:46, Rahul Sharma wrote: >> From: Rahul Sharma <Rahul.Sharma@samsung.com> >> >> "gpx3-7" is chip specific pin in Exynos5420 for hdmi >> hotplug. This pin is moved to exynos5420-pinctrl.dts >> and removed from the board file. >> >> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com> >> --- >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 9 --------- >> 1 file changed, 9 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> index 6910485..11cd9bf 100644 >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> @@ -131,15 +131,6 @@ >> }; >> }; >> >> - pinctrl@13400000 { >> - hdmi_hpd_irq: hdmi-hpd-irq { >> - samsung,pins = "gpx3-7"; >> - samsung,pin-function = <0>; >> - samsung,pin-pud = <1>; >> - samsung,pin-drv = <0>; > > Again, the same comment as for patch 1/5. This pin is being configured > as input, which doesn't look like a dedicated special function pin. > Shouldn't this node rather stay here? > Yea, I will take care fo this in v5. > Best regards, > Tomasz
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts index 6910485..11cd9bf 100644 --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts @@ -131,15 +131,6 @@ }; }; - pinctrl@13400000 { - hdmi_hpd_irq: hdmi-hpd-irq { - samsung,pins = "gpx3-7"; - samsung,pin-function = <0>; - samsung,pin-pud = <1>; - samsung,pin-drv = <0>; - }; - }; - hdmi@14530000 { status = "okay"; hpd-gpio = <&gpx3 7 0>;