| Message ID | 1400035562-16832-6-git-send-email-rahul.sharma@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Rahul, On 14.05.2014 04:46, Rahul Sharma wrote: > From: Rahul Sharma <Rahul.Sharma@samsung.com> > > Enable hdmi for peach-pi board. > > Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com> > --- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index 742655b..2a6f23b8 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -134,6 +134,25 @@ > }; > }; > > +&i2c_2 { > + status = "okay"; > + samsung,i2c-sda-delay = <100>; > + samsung,i2c-max-bus-freq = <66000>; > + samsung,i2c-slave-addr = <0x50>; > + > + hdmiddc@50 { > + reg = <0x50>; > + }; > +}; > + > +&hdmi { > + status = "okay"; > + hpd-gpio = <&gpx3 7 2>; What is the 2 flag? I don't see any value other than 0 and 1 defined in include/dt-bindings/gpio/gpio.h. Also it would be better to use preprocessor macros instead of magic numbers for flags like this. Best regards, Tomasz
On 14.05.2014 21:56, Tomasz Figa wrote: > Hi Rahul, > > On 14.05.2014 04:46, Rahul Sharma wrote: >> From: Rahul Sharma <Rahul.Sharma@samsung.com> >> >> Enable hdmi for peach-pi board. >> >> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com> >> --- >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> index 742655b..2a6f23b8 100644 >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> @@ -134,6 +134,25 @@ >> }; >> }; >> >> +&i2c_2 { >> + status = "okay"; >> + samsung,i2c-sda-delay = <100>; >> + samsung,i2c-max-bus-freq = <66000>; >> + samsung,i2c-slave-addr = <0x50>; >> + >> + hdmiddc@50 { >> + reg = <0x50>; >> + }; Aha, also with the new Exynos HDMI bindings, I don't think the DDC device node is necessary any longer. Best regards, Tomasz
On 15 May 2014 01:27, Tomasz Figa <tomasz.figa@gmail.com> wrote: > > > On 14.05.2014 21:56, Tomasz Figa wrote: >> Hi Rahul, >> >> On 14.05.2014 04:46, Rahul Sharma wrote: >>> From: Rahul Sharma <Rahul.Sharma@samsung.com> >>> >>> Enable hdmi for peach-pi board. >>> >>> Signed-off-by: Rahul Sharma <Rahul.Sharma@samsung.com> >>> --- >>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 19 +++++++++++++++++++ >>> 1 file changed, 19 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >>> index 742655b..2a6f23b8 100644 >>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >>> @@ -134,6 +134,25 @@ >>> }; >>> }; >>> >>> +&i2c_2 { >>> + status = "okay"; >>> + samsung,i2c-sda-delay = <100>; >>> + samsung,i2c-max-bus-freq = <66000>; >>> + samsung,i2c-slave-addr = <0x50>; >>> + >>> + hdmiddc@50 { >>> + reg = <0x50>; >>> + }; > > Aha, also with the new Exynos HDMI bindings, I don't think the DDC > device node is necessary any longer. Yea it is not necessary now. I added it to list the i2c devices under controller node. Just for completion. > > Best regards, > Tomasz
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index 742655b..2a6f23b8 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -134,6 +134,25 @@ }; }; +&i2c_2 { + status = "okay"; + samsung,i2c-sda-delay = <100>; + samsung,i2c-max-bus-freq = <66000>; + samsung,i2c-slave-addr = <0x50>; + + hdmiddc@50 { + reg = <0x50>; + }; +}; + +&hdmi { + status = "okay"; + hpd-gpio = <&gpx3 7 2>; + pinctrl-names = "default"; + pinctrl-0 = <&hdmi_hpd_irq>; + ddc = <&i2c_2>; +}; + /* * Use longest HW watchdog in SoC (32 seconds) since the hardware * watchdog provides no debugging information (compared to soft/hard