From patchwork Wed May 14 22:30:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Soren Brinkmann X-Patchwork-Id: 4178571 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 46CAFBFF02 for ; Wed, 14 May 2014 22:36:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6F5D9202FF for ; Wed, 14 May 2014 22:36:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3FF120265 for ; Wed, 14 May 2014 22:36:13 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wkhkf-000412-AP; Wed, 14 May 2014 22:34:17 +0000 Received: from mail-qg0-x229.google.com ([2607:f8b0:400d:c04::229]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wkhk2-0003hU-7D for linux-arm-kernel@lists.infradead.org; Wed, 14 May 2014 22:33:38 +0000 Received: by mail-qg0-f41.google.com with SMTP id j5so398445qga.28 for ; Wed, 14 May 2014 15:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=nC4fiuXXQY1dWx+NvCUO9GqFAopY0WI11rEPDlKzpDc=; b=dvH/SXQcdGOWSc8uDs238PPPjjcstiPIiHtjM2FzHJ8LoDoj9CO1Sq5bgCsF0uyltW 3jpFuTNd/sptDp96coXkOhBYzIoXvJ9iF7VOl1XbGGkpWYaxh3+7eOhxzc/tentmAK/2 VdjPmhIW9pCcxIRsn/lDmuaeJDjCH4aB68zRDi/sy78Jdt4RSVCJEcuOT0F3et5UiG0/ 1mMDU2j14xkkH8pRXZQA6srJIjNDsUMm0Ne1d5SvkuotdgxPkA6YOi0UkvH22TcoCgrj fVxGnpcwAXsw2ZRENqVRwiFGsbHeqxnEGLJMWsN1mBIQ187dQWFYUscrdyW15T+ENX51 QpqA== X-Received: by 10.224.92.144 with SMTP id r16mr8119612qam.10.1400106796531; Wed, 14 May 2014 15:33:16 -0700 (PDT) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id f7sm4897282qar.42.2014.05.14.15.33.15 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 14 May 2014 15:33:15 -0700 (PDT) From: Soren Brinkmann To: Mike Turquette , "Rafael J. Wysocki" , Viresh Kumar , Russell King Subject: [RFC PATCH 5/5] net: macb: Use clk_round_rate_nearest() API Date: Wed, 14 May 2014 15:30:55 -0700 Message-Id: <1400106655-22465-6-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 1.9.3.1.ga73a6ad In-Reply-To: <1400106655-22465-1-git-send-email-soren.brinkmann@xilinx.com> References: <1400106655-22465-1-git-send-email-soren.brinkmann@xilinx.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140514_153338_354268_2FF19505 X-CRM114-Status: GOOD ( 10.50 ) X-Spam-Score: 0.0 (/) Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, Michal Simek , Soren Brinkmann , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The current way of rounding clock frequencies always rounds down and doesn't allow deviations above the requested frequency. For the Ethernet case though, it is more important to minimize deviations than not exceeding the requested frequency. Signed-off-by: Soren Brinkmann --- --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index e9daa072ebb4..4fdbfcbc38bc 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b/drivers/net/ethernet/cadence/macb.c @@ -223,7 +223,7 @@ static void macb_set_tx_clk(struct clk *clk, int speed, struct net_device *dev) return; } - rate_rounded = clk_round_rate(clk, rate); + rate_rounded = clk_round_rate_nearest(clk, rate); if (rate_rounded < 0) return;