| Message ID | 1400771902-26553-3-git-send-email-peter.griffin@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/22/2014 05:18 PM, Peter Griffin wrote: > This patch adds the device tree binding documentation for ST > SDHCI driver. It contains the differences between the core properties > in mmc.txt and the properties used by the sdhci-st driver. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> > --- > Documentation/devicetree/bindings/mmc/sdhci-st.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-st.txt > You can add my: Acked-by: Maxime Coquelin <maxime.coquelin@st.com> [...]
> This patch adds the device tree binding documentation for ST > SDHCI driver. It contains the differences between the core properties > in mmc.txt and the properties used by the sdhci-st driver. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> > --- > Documentation/devicetree/bindings/mmc/sdhci-st.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-st.txt > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-st.txt b/Documentation/devicetree/bindings/mmc/sdhci-st.txt > new file mode 100644 > index 0000000..ae3dae0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/sdhci-st.txt > @@ -0,0 +1,26 @@ > +* STMicroelectronics sdhci-st MMC/SD controller > + > +This file documents differences between the core properties in mmc.txt Where is mmc.txt? > +and the properties used by the sdhci-st driver > + > +Required properties: > +- compatible: "st,sdhci" > +- clocks: card clock, must be "mmc". This isn't correct. I think you mean it must be a phandle to the 'mmc' clock. It's also worth referencing the clock DT documentation here. > +Optional properties: > +- reset: to provide a reset to the HC. What is it; integer, string, phandle, something else? > +- non-removable: non-removable slot (bindings/mmc/mmc.txt). This however, _is_ a string, so you need to put it in "'s like you did with "mmc" above and/or reference the file which documents it. > + > +Example: > + > +mmc0: sdhci@fe81e000 { > + compatible = "st,sdhci"; > + status = "disabled"; > + reg = <0xfe81e000 0x1000>; > + interrupts = <GIC_SPI 127 IRQ_TYPE_NONE>; > + interrupt-names = "mmcirq"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_mmc0>; > + clock-names = "mmc"; I don't think you need clock-names if you only have one clock. > + clocks = <&clk_s_a1_ls 1>; > +}; Once fixed you can add my Ack for the next submission: Acked-by: Lee Jones <lee.jones@linaro.org>
On 22 May 2014 17:18, Peter Griffin <peter.griffin@linaro.org> wrote: > This patch adds the device tree binding documentation for ST > SDHCI driver. It contains the differences between the core properties > in mmc.txt and the properties used by the sdhci-st driver. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> Assuming this patch adds does what is says; the patch1 - adding the actual driver will have checkpatch warnings around missing DT-bindings. Kind regards Ulf Hansson > --- > Documentation/devicetree/bindings/mmc/sdhci-st.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-st.txt > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-st.txt b/Documentation/devicetree/bindings/mmc/sdhci-st.txt > new file mode 100644 > index 0000000..ae3dae0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/sdhci-st.txt > @@ -0,0 +1,26 @@ > +* STMicroelectronics sdhci-st MMC/SD controller > + > +This file documents differences between the core properties in mmc.txt > +and the properties used by the sdhci-st driver > + > +Required properties: > +- compatible: "st,sdhci" > +- clocks: card clock, must be "mmc". > + > +Optional properties: > +- reset: to provide a reset to the HC. > +- non-removable: non-removable slot (bindings/mmc/mmc.txt). > + > +Example: > + > +mmc0: sdhci@fe81e000 { > + compatible = "st,sdhci"; > + status = "disabled"; > + reg = <0xfe81e000 0x1000>; > + interrupts = <GIC_SPI 127 IRQ_TYPE_NONE>; > + interrupt-names = "mmcirq"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_mmc0>; > + clock-names = "mmc"; > + clocks = <&clk_s_a1_ls 1>; > +}; > -- > 1.9.1 >
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-st.txt b/Documentation/devicetree/bindings/mmc/sdhci-st.txt new file mode 100644 index 0000000..ae3dae0 --- /dev/null +++ b/Documentation/devicetree/bindings/mmc/sdhci-st.txt @@ -0,0 +1,26 @@ +* STMicroelectronics sdhci-st MMC/SD controller + +This file documents differences between the core properties in mmc.txt +and the properties used by the sdhci-st driver + +Required properties: +- compatible: "st,sdhci" +- clocks: card clock, must be "mmc". + +Optional properties: +- reset: to provide a reset to the HC. +- non-removable: non-removable slot (bindings/mmc/mmc.txt). + +Example: + +mmc0: sdhci@fe81e000 { + compatible = "st,sdhci"; + status = "disabled"; + reg = <0xfe81e000 0x1000>; + interrupts = <GIC_SPI 127 IRQ_TYPE_NONE>; + interrupt-names = "mmcirq"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_mmc0>; + clock-names = "mmc"; + clocks = <&clk_s_a1_ls 1>; +};